Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Oliver Kopp
    @koppor
    Delete buildSrc/build folder. If there is buildSrc/out, delete that too
    Anoop Kumar Kushwaha
    @a1819644
    Thanks @koppor .. Its working now
    Linh Dang
    @danglt
    JabRef/jabref#6601
    I am a bit confused about add/remove vs. show/hide columns in the requirement of Right-click menu for the main table header. I understand that the past group have done is confused since now they have 2 ways to show/hide the column in the maintable: By changing the columns in the preferences AND also by showing/hiding them in the right-click menu. My understanding is you want to add/remove a column or a set of columns (maybe commonly used columns) that are different from these columns already shown in the main table? Could someone please clarify it for me? Thank you very much!
    Carl Christian Snethlage
    @calixtus
    Yes. We have a column factory providing main table columns. Those should be added by demand to the table or removed.
    4 replies
    That comes for performance reasons, because invisible columns are still rendered.
    the-rabbit-tiger
    @the-rabbit-tiger:matrix.org
    [m]

    @Yancy10-1: When I asked Carl about causes for Index out of bounds error he mentioned this: "I am not an expert for this, but I know that this often indicates a problem with threading / concurrency. Especially between UI thread and others.
    It can be problematic when trying to add or remove individual items in a list in another thread, when that list is not in the same thread. The solution can be to use concurrency-safe methods to populate a list (e.g. setAll) or multithreading-safe lists. This is not the default in Java and Java-lists (because performance), but you have to consider it during development."

    Translated with www.DeepL.com/Translator (free version)

    For methods about preventing index out of bounds issues, he refered me to these two websites:

    https://www.baeldung.com/java-concurrency
    https://www.baeldung.com/java-thread-safety

    1 reply
    the-rabbit-tiger
    @the-rabbit-tiger:matrix.org
    [m]
    hey, since my Windows machine is broken, I can be contacted via Gitter. I am using Element for access, so videoconferencing would work too, but not via skype.
    siedlerchr
    @siedlerchr:matrix.org
    [m]
    I also created a matrix account ThiloteE
    Christoph
    @Siedlerchr
    @siedlerchr:matrix.org test
    ThiloteE
    @the-rabbit-tiger:matrix.org
    [m]

    Found

    Maybe it could be forked and adapted to only find issues in JabRef.

    ThiloteE
    @the-rabbit-tiger:matrix.org
    [m]
    As a reminder to the "real" developers: I am assigning labels (e.g. entry table, bug, unicode, etc.), but I will refrain from assigning "good first issues", because I am not knowledgable enough about coding to estimate the workload.
    I trust others can help out with that
    Anoop Kumar Kushwaha
    @a1819644
    Hi Team, how to make the otherFieldsTab visible when we select an Article as document type? Currently Im trying to fix the issue (JabRef/jabref#46888 )of merging part.
    Sim Teck Lim
    @LIM0000
    Hi teams, I am working on JabRef/jabref#8390 and have figured out a solution to fix this issue.
    Solution (please refer to image below):
    I have planned to run a loop to remove selected groups instead of just remove the only group that fire setOnAction().
    Issue with this solution:
    If a group has been deleted, the iterator will skip the next element due to that element is now at that deleted element index. Refer (https://stackoverflow.com/questions/17852412/foreach-skips-an-element-when-a-previous-element-is-deleted)
    Really appreciate if someone could provide insight to this issue, thanks!
    issue_1.png
    Anoop Kumar Kushwaha
    @a1819644
    Hi Team, how to make the otherFieldsTab visible when we select an Article as document type? Currently Im trying to fix the issue (JabRef/jabref#46888 )of merging part
    issue .png
    issue with merging files.png
    issue .png
    Thanks in advance!
    siedlerchr
    @siedlerchr:matrix.org
    [m]
    @a1819644: For me it's there. Try resetting your preferences. in both bibtex and biblatex it's visible
    @LIM0000: Can you please open a PR with your things?
    Tusharshirose
    @Tusharshirose
    Hi Jabref team,
    Are we allowed to use QF-test for GUI testing?
    Carl Christian Snethlage
    @calixtus
    Hi @Tusharshirose , thanks for your interest in jabref programming. Unfortunately qf-test is not free Software. In order to integrate tests using qf-test into the jabref test workflow, we would probably have to buy a license of that software, which is not an option for us if there is an urgent need. Also this would additional dependencies to jabrefs build script, but dependencies are currently a limited resource. I'd like to invite you to take a look at a software called testfx which is a free alternative to qf-test. Thanks!
    *if there isn't an urgent need
    Tusharshirose
    @Tusharshirose
    Can you please tell us how to setup testfx on intellij? @calixtus
    siedlerchr
    @siedlerchr:matrix.org
    [m]
    Have a look at the existing gui tets
    *tests
    Carl Christian Snethlage
    @calixtus
    There is also a very good documentation for TestFX at https://github.com/TestFX/TestFX/wiki
    TestFX does not have to be set up for intelliJ, but for the JavaFX project you are testing. Fortunatley JabRef already uses testfx on other gui tests. So using testfx for your own tests in JabRef should be pretty straigtforward. Godspeed!
    Tusharshirose
    @Tusharshirose
    Thank you @siedlerchr:matrix.org and @calixtus
    Prateek Arora
    @pratt33k

    Hello everyone! My team is working on this JabRef/jabref#8762 and we are wondering if you had any suggestions (functions) for adding a column to the mainTable. (or which class / function is used to add columns in Preferences /Entry Table)

    We have found a way to remove the column from the MainTable (which also removes it from the preferences/entry table) using a context menu we created (removing it just by comparing the names of the column in our context menu with the maintable when a user clicks an item from our context menu)

    Carl Christian Snethlage
    @calixtus
    Creating a Column for the MainTable is done in the MainTableColumnFactory. This new Colum can then be added to the preferences and the MainTable.
    Prateek Arora
    @pratt33k
    image.png
    Thank you @calixtus ! Was trying to understand what lines (101 to 109) in MainTable.java do?
    siedlerchr
    @siedlerchr:matrix.org
    [m]
    The MainTableColumnFactory builds the actual TableColumn for each type e.g. if it's a link/url column, or any other special column with different formatting. Then the build columns are returned and added to the MainTable's javafx table
    ShaunChang
    @ShaunChang
    思路.PNG
    I'm doing a GUI test for pr (#8762) about right clicking the main table to display the right-click menu. I found a very similar test called sourcetabtest. Based on this test, my whole idea is to draw the MainTable interface separately on a new stage, and then conduct a click test. But I've been stuck in the instantiation of MainTable. I tried the mock method and the new method, but both failed. I would appreciate it if someone could tell me how to instantiate a MainTable object in the test.
    In addition, although we know that testfx is a better choice. However, we have completed the GUI test based on QF test. Can we check the ‘Tests created for changes’ option of PR?
    Christoph
    @Siedlerchr
    @ShaunChang It's okay, you could however show us the code or a screenshot from the QF stuff
    Anoop Kumar Kushwaha
    @a1819644
    Hi Team, I'm struggling to remove some of the unwanted fields such as Author, title and so on. I am currently trying to fix the issue 4688.
    Any assistance of who to filter the remaining field would be highly appreciated.
    help -4688.png
    Anoop Kumar Kushwaha
    @a1819644
    Any assistance of who to filter the remaining field would be highly appreciated.
    Any assistance of how to filter the remaining field would be highly appreciated.
    ThiloteE
    @the-rabbit-tiger:matrix.org
    [m]
    ThiloteE
    @the-rabbit-tiger:matrix.org
    [m]

    Anoop, there are different entry types. E.g. Article, book, misc or patent (see screenshot).

    For each entry type there are specific fields REQUIRED and some OPTIONAL, as defined by BibTeX and BibLaTeX. JabRef follows these standards and offers two specific library modes by default: BibTeX library mode and BibLaTeX library mode. The required and optional fields CHANGE when you change the library mode.

    As I understand it, all custom fields that users manually add to their library and that are NOT defined in these required and optional fields under options > customize entry types will currently show in the other fields tab.

    About the code: I don't know exactly which classes and methods deal with that, but since you deleted some, I guess experimenting a little will eventually show you.

    At the end of the day: It is not wanted to get rid of the various entry types. The task is NOT to get rid of these fields. The task is simply to let all the fields that are not part of an entry type to also show in the optional fields tab, but in a separate section (Maybe with title "Other fields" and/or separate colour/icon.

    Anoop Kumar Kushwaha
    @a1819644

    Anoop, there are different entry types. E.g. Article, book, misc or patent (see screenshot).

    For each entry type there are specific fields REQUIRED and some OPTIONAL, as defined by BibTeX and BibLaTeX. JabRef follows these standards and offers two specific library modes by default: BibTeX library mode and BibLaTeX library mode. The required and optional fields CHANGE when you change the library mode.

    As I understand it, all custom fields that users manually add to their library and that are NOT defined in these required and optional fields under options > customize entry types will currently show in the other fields tab.

    About the code: I don't know exactly which classes and methods deal with that, but since you deleted some, I guess experimenting a little will eventually show you.

    At the end of the day: It is not wanted to get rid of the various entry types. The task is NOT to get rid of these fields. The task is simply to let all the fields that are not part of an entry type to also show in the optional fields tab, but in a separate section (Maybe with title "Other fields" and/or separate colour/icon.

    Thanks

    1 reply
    soumyadeep9474
    @soumyadeep9474
    Hello all, Myself Soumyadeep , an undergrad from IIT Kharagpur. I am a newbie to opensource. I am well aware of Java, JS , CSS , HTML, Python, C++ . I have a decent knowledge of Dart and Flutter. I would like to contribute to your organization and gain hands on experience. It will be very helpful for me if someone can suggest and guide me further.
    Carl Christian Snethlage
    @calixtus
    Hello @soumyadeep9474 welcome to jabref development. A good start is to read the contribution guide to jabref and to pick a good first issue to solve. https://devdocs.jabref.org/contributing