Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 02 08:34
    47degdev unlabeled #123
  • Dec 02 08:34
    47degdev labeled #123
  • Dec 02 08:33
    47degdev labeled #48
  • Dec 02 08:33
    47degdev unlabeled #48
  • Dec 02 08:33
    47degdev labeled #48
  • Dec 02 08:33
    47degdev unlabeled #48
  • Dec 02 08:27
    BenFradet closed #303
  • Dec 02 08:19
    47degdev unlabeled #123
  • Dec 02 08:19
    47degdev labeled #123
  • Dec 02 08:19
    47degdev labeled #48
  • Dec 02 08:19
    47degdev unlabeled #48
  • Dec 02 08:18
    47degdev labeled #48
  • Dec 02 08:18
    47degdev unlabeled #48
  • Dec 02 08:13
    BenFradet closed #301
  • Dec 01 09:49
    scala-steward opened #303
  • Nov 29 18:51
    duanebester closed #297
  • Nov 29 18:51
    duanebester opened #302
  • Nov 29 18:33
    duanebester opened #301
  • Nov 29 10:29
    BenFradet opened #300
  • Nov 29 09:49
    47degdev unlabeled #123
Ben Fradet
@BenFradet
yup that'd be great! thanks
Pepe García
@pepegar
:+1:
Pepe García
@pepegar
47deg/github4s#195 there we go :)
Ben Fradet
@BenFradet
thanks I think we'll release 0.18.1 following the merge of your pr
Pepe García
@pepegar
:dancer: :dancer:
Cool!
Pepe García
@pepegar
I think I broke the build :-/ . I can see tests are failing. or the build was broken before?
Ben Fradet
@BenFradet
only members have access to the github api token so that might be why tests are failing
I'll have a look later today
Pepe García
@pepegar
ah, gotcha! thanks then, I'll wait!
sravanthi
@sravant82987105_twitter
Hi
Is anyone there?
am looking for an java API which can fork a repo, commit something and give a pull request.
This should be programatically done.
I have figured out the commiting part. but struck in forking and giving a PR.
Suggestions are appreciated.
Ben Fradet
@BenFradet
creating a pr is supported however creating a fork is not, yet
feel free to open a pull request, there is a contributing guide here
neharamdeo
@neharamdeo
Is it possible to change the defaultUrls and use this API for GHE?
If it doesn't work it should be easy to build support for GHE providing a default implicit strategy for regular Github but that allows an implicit override with other sets of URLs
Rohan Kulkarni
@vendettacoder
Does this library have support for the SearchAPI?
Ben Fradet
@BenFradet
not yet no unfortunately
Jakub Kozłowski
@kubukoz
hey
I'm using github4s in an ammonite script, and the problem is that ammonite uses an incompatible version of scalaj-http (2.3.0, as opposed to github4s's 2.4.0) - some argument was added to a class in 2.4.0 and github4s calls the copy method of that class - and apparently the version picked doesn't have an appropriate variant of the copy method... wondering how to solve this
option 1: upgrading scalaj in ammonite
option 2: not calling the copy method directly but some builder-like method
the culprit is scalaj.http.HttpRequest#copy called in github4s/HttpRequestBuilderExtensionJVM.scala:57
problem is... there's no builder-like method to set the urlBuilder
which led me to wonder if the urlBuilder even needs to be replaced - so I wanted to try removing that line and seeing what happens, but I can't even get the tests to pass with the original source
getting 27 failed tests when running github4s.integration.IntegrationSpec
Jakub Kozłowski
@kubukoz
gotcha, missing token
Jakub Kozłowski
@kubukoz
alright, so apparently the default url builder does URL encoding of the query parameters, which is something we don't want to do for some reason
and it actually causes more test failures (5 instead of 3 which I'd get without modifying anything)

so a way to avoid such incompatibilities might be:

  1. changing scalaj to have a method to update the urlBuilder without calling .copy directly, waiting for a release
  2. using the new scalaj version with that method and calling it instead of copy, publishing a release
  3. then I update github4s and everything's working :joy:

...or I could just issue a PR to bump scalaj in ammonite. WDYT?

Ben Fradet
@BenFradet
bumping scalaj in ammonite seems like the shortest path to get to where you want to be :)
Jakub Kozłowski
@kubukoz
right, but it's kinda an ugly workaround - what if they add more fields to that case class? The copy call will be incompatible again
anyways, yeah, it's the shortest
Ben Fradet
@BenFradet
hey I might need help with publishing, 0.18.7 is in sonatype but doesn't seem to have been mirrored to central
danieltsoy
@danieltsoy

FYI, I believe there's a typo in the documentation for Create a comment section for github4s.

"Github(accessToken).issues.create(...)"

should be "Github(accessToken).issues.createComment(...)"

Ben Fradet
@BenFradet
true, feel free to open a pr :+1:
oybek
@oybek
Hello! Does Github4s library allows to get list of contributors for the repo? I found this method. But it seems like it returns List[User] where User case class doesn't have field contributions as it described in github api spec: https://developer.github.com/v3/repos/#list-contributors
Ben Fradet
@BenFradet
You can add that optional field to User and it should be picked up :+1:
oybek
@oybek
@BenFradet so I need to change library and do custom patch for myself? Or is there any way to do it simpler (may be by implicits conversion)?
Ben Fradet
@BenFradet
yes you'll need to open a PR
oybek
@oybek
I clonned Github4s made changes, and trying to build local .jar file, how can I do it correctly? I tried sbt package and got .jar file in target/ folder, but when importing it to my project it is not working
Ben Fradet
@BenFradet
sbt +publishLocal
oybek
@oybek
@BenFradet 👍 worked
KiranKumar BS
@kirankbs
Hello Folks, i am using this library now. I would like to contribute. Please let me know that how can i help?
Ben Fradet
@BenFradet
hey @kirankbs , usually people contribute features they want to use but are missing :+1: