Food for thought: I’m writing tests following a blog post I found about testing tagless final (https://medium.com/wix-engineering/functional-testing-with-tagless-final-50eeacf5df6). When creating the implicit for
Issues, I get a huge amount of methods to define. Even leaving stuff defined as ???, it’s still a big chunk of lines with very few actual definitions, since I only need to deal with labels.
There’s some clear divisions in that algebra: issues, comments, labels, milestones. Instead of breaking the algebra by Github’s v3 classification, it would be neater to break it up in smaller chunks.
issues is further broken down on the website https://developer.github.com/v3/issues/, it's just that we started from a very small set of endpoints and never made the leap to further divide what we had
[error] github4s.GithubResponses$JsonParsingException: Invalid message body: Could not decode JSON: {
[error] "message" : "Not Found",
[error] "documentation_url" : "https://developer.github.com/v3"
[error] }
Unfortunately, there’s not way of knowing which API was called that returned this error. It would have been helpfull if more information about the request was included.
Mind you, it might not be on one of the existing APIs, since I used
HttpClient when writing the extra ones I needed.
I’ve worked around it by calling http4s’s
Uri.encode on it before passing it to g4s. It encodes the space, but not the colon. I’ve also confirmed it using curl.
https://github.com/firstcontributions/first-contributions might be a useful resource to get started
Submitted my first PR! 47degrees/github4s#528 . Little confused by the codecov report though... Impacted files are ones I haven't even changed 🤔
This label throws errors on decoding: https://api.github.com/repos/precog/quasar-datasource-kafka/labels/:robot:
and this doesn’t: https://api.github.com/repos/precog/quasar-datasource-mongo/labels/:robot:
and this doesn’t: https://api.github.com/repos/precog/quasar-datasource-mongo/labels/:robot:
@BenFradet Do you think it would be possible to get a release out quickly to fix this? I mean, I can (will) submit a PR for it and it is a trivial change, but this broke my build infrastructure and I have to figure out quickly whether to go with a new github4s version fixing it or come up with something else.
So, I cannot use the snapshot to solve my issue with label ids. I use github4s on a plugin, and since plugins cannot add a resolver I’d have to add the resolver to every project, instead of just changing the version (which I do automatically). I’d really like a new version of github4s, to get this fixed.
Hey guys! I am currently working with github4s and i have a problem that my program won't terminate. It is not stuck somewhere but after executing the last line of code it just won't stop. I figured out that it does terminate when i don't execute the code that fetches files from github. The methods that relate to github4s that i use are
private val TIMEOUT_DURATION = Duration(1,duration.SECONDS)
private val httpClient: Client[IO] = {
val N_THREADS = 5
val blockingPool = Executors.newFixedThreadPool(N_THREADS)
val blocker = Blocker.liftExecutorService(blockingPool)
implicit val cs: ContextShift[IO] = IO.contextShift(global)
JavaNetClientBuilder[IO](blocker).create
}
private val accessToken = sys.env.get("GITHUB_TOKEN")
private val gh = Github[IO](httpClient, accessToken)
gh.repos.getContents(...)
val response = getContents
.unsafeRunTimed(TIMEOUT_DURATION)
.getOrElse(throw new IOException(s"Unable to fetch content of: $path"))Does anybody know if there might be some running thread problem here ? Thx.
New release v0.28.0. Contains one significant breaking change due to the GitHub API removing basic auth, and a small bug fix for search query parameters. https://github.com/47degrees/github4s/releases/tag/v0.28.0
Do you have a more specific feature request? Maybe a certain search endpoint or two? The API is rather large, and we tend to only add things on an as-needed basis so we can add your feature request if it's something specific and not all-encompassing.
I can add repository search, if it is not already present. And, I will also look into your auth issue now to see what's up with that.
1 reply
@kell18 Alright, I was able to slap this together over what little free time I had the past day and a half between regular work + playing Hades. Next version of github4s should have repository search once this goes through! 47degrees/github4s#611
1 reply