Yes, I think there’s value, but I’m not sure what would make a good API design. Having out-of-box support to interacting with GitHub graphql API by providing nothing more than graphql query files, and having those queries checked for syntax and against the schema, and having type safety and codecs for query variables and result, there is a lot of value there.
I could easily have this implemented directly through HTTP, but github4s’s HttpClient handles a lot of of the boilerplate already, of github specifics. The extra two classes/codecs I added would make life easier on people as well, since it was a bit of a discovery process.
And, of course, doing everything in
F.
I can’t see a way of handling the second one, however, since the cursors would be returned as part of
A#Data.
I had this for auto-pagination using graphql: https://github.com/BenFradet/dashing/blob/master/server/src/main/scala/dashing/server/GraphQL.scala#L126-L155
I think it might be more simply implemented with unfold, like in https://github.com/47degrees/github4s/issues/169#issuecomment-611821491, though that’s on v3 not v4. At that,
nextPage there could be injected, so that the same solution would apply to both v3 and v4, by just changing a parameter.
I’d rather return
Stream[F, T] over F[List[T]] as well. Depending on one’s needs, it might not be necessary to fetch the entire set of results, and that will save on API usage as well as getting results out faster.
Damn, that means I’ll have to refactor all my stuff!
I had hoped to submit a couple of PRs adding a few methods I’ve had need for, and which do not require feature flags.
Alas… too much work.
Food for thought: I’m writing tests following a blog post I found about testing tagless final (https://medium.com/wix-engineering/functional-testing-with-tagless-final-50eeacf5df6). When creating the implicit for
Issues, I get a huge amount of methods to define. Even leaving stuff defined as ???, it’s still a big chunk of lines with very few actual definitions, since I only need to deal with labels.
There’s some clear divisions in that algebra: issues, comments, labels, milestones. Instead of breaking the algebra by Github’s v3 classification, it would be neater to break it up in smaller chunks.
issues is further broken down on the website https://developer.github.com/v3/issues/, it's just that we started from a very small set of endpoints and never made the leap to further divide what we had
[error] github4s.GithubResponses$JsonParsingException: Invalid message body: Could not decode JSON: {
[error] "message" : "Not Found",
[error] "documentation_url" : "https://developer.github.com/v3"
[error] }
Unfortunately, there’s not way of knowing which API was called that returned this error. It would have been helpfull if more information about the request was included.
Mind you, it might not be on one of the existing APIs, since I used
HttpClient when writing the extra ones I needed.
I’ve worked around it by calling http4s’s
Uri.encode on it before passing it to g4s. It encodes the space, but not the colon. I’ve also confirmed it using curl.
https://github.com/firstcontributions/first-contributions might be a useful resource to get started
Submitted my first PR! 47degrees/github4s#528 . Little confused by the codecov report though... Impacted files are ones I haven't even changed 🤔
This label throws errors on decoding: https://api.github.com/repos/precog/quasar-datasource-kafka/labels/:robot:
and this doesn’t: https://api.github.com/repos/precog/quasar-datasource-mongo/labels/:robot:
and this doesn’t: https://api.github.com/repos/precog/quasar-datasource-mongo/labels/:robot:
@BenFradet Do you think it would be possible to get a release out quickly to fix this? I mean, I can (will) submit a PR for it and it is a trivial change, but this broke my build infrastructure and I have to figure out quickly whether to go with a new github4s version fixing it or come up with something else.
So, I cannot use the snapshot to solve my issue with label ids. I use github4s on a plugin, and since plugins cannot add a resolver I’d have to add the resolver to every project, instead of just changing the version (which I do automatically). I’d really like a new version of github4s, to get this fixed.
