Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    madhavgaba
    @madhavgaba_gitlab
    Not just that if we can add lint rules as well
    Ghost
    @ghost~5c70f4fad73408ce4fb8b1b8
    Hey, I have a small doubt as mentioned in the Readme the node version is 8.x recommended
    Screenshot from 2020-04-01 04-36-45.png
    Screenshot from 2020-04-01 04-36-18.png
    Ghost
    @ghost~5c70f4fad73408ce4fb8b1b8
    Referencing to above comments "node version: v8.17.0, java: openjdk version "1.8.0_232", react-native-cli: 2.0.1. Please try using these versions" and @Ritesh-Ag was updating the versions of all libraries and react-cli too
    @Ritesh-Ag could you help me with this?
    Ritesh Agrawal
    @Ritesh-Ag
    @iharshit009 which comment are you talking about and sorry, i didn't get you. What is your doubt?
    Ghost
    @ghost~5c70f4fad73408ce4fb8b1b8

    @Ritesh-Ag @ayushns9 I think only you two are working on carbonfootprint-mobile.

    can you look into updating all dependency versions including react-native ?

    @Ritesh-Ag this

    Ritesh Agrawal
    @Ritesh-Ag
    Yes, i have already opened an MR which update the react, react native version and few more dependencies.
    Ghost
    @ghost~5c70f4fad73408ce4fb8b1b8
    Okay @Ritesh-Ag
    Ritesh Agrawal
    @Ritesh-Ag
    @prudhvir3ddy @madhavgaba_gitlab @sagar-kalra Please review my MRs so that i can work on some other issues.
    Ritesh Agrawal
    @Ritesh-Ag
    I am very much thankful to @madhavgaba_gitlab for giving me this opportunity. Thank you @madhavgaba_gitlab and @prudhvir3ddy for guiding me throughout my journey till now. I look forward to accomplish great things this summer. :)
    Ghost
    @ghost~5c70f4fad73408ce4fb8b1b8
    Congratulations @Ritesh-Ag
    Ritesh Agrawal
    @Ritesh-Ag
    Thank you 😁
    Sagar Kalra
    @sagar-kalra
    Congrats @Ritesh-Ag
    madhavgaba
    @madhavgaba_gitlab
    Congrats @Ritesh-Ag. For other contributors we are very happy to see your enthusiasm towards the project. I'd highly recommend not to lose hope and continue contributing, not just this project but anything that sparks you :)
    Ritesh Agrawal
    @Ritesh-Ag
    Thank you.. :) @madhavgaba_gitlab @sagar-kalra
    Himanshu
    @himanshuc3
    Hey guys, apologies for not being able to contribute here. Have not been getting enough time to stay in the loop and help. In the current situation, I would be mostly only be able to take small tasks but would like to help in any way possible. Are there any on going tasks that I could help someone with or maybe pickup a task not assigned yet. Also, will go through the codebase once again to see the design/architecture and provide any suggestions possible. Once again, I mismanage my time, so spare me If I am late in replying.
    Himanshu
    @himanshuc3
    There are some good practices that we could follow, that would take less to no effort to get accomodated to (these are suggestions which would make the development experience consistent and help ease release cycle):
    1. Follow the git flow model (https://nvie.com/posts/a-successful-git-branching-model/)
    2. Add changelog for each release and update package json.
    3. Before every release, audit npm packages for checking security vulnerabilities.
    4. (opinionated) Follow conventional commits (https://www.conventionalcommits.org/en/v1.0.0/) which automates generation of changelog (https://www.npmjs.com/package/conventional-changelog-cli) and helps the pr to be restricted to a particular task ( feature, bugfix, refactor, breaking change etc. )
    Himanshu
    @himanshuc3
    Another approach for release convention could be following feature flags (https://reactjs.org/docs/how-to-contribute.html#feature-flags).
    Ritesh Agrawal
    @Ritesh-Ag
    Hey @himanshuc3 , Recently I have made an MR related to the performance of the application and updated all the class component using hooks as the performance of the app was not so impressive. So, It will be very much helpful if you go through that MR and suggest me any further changes related to the architecture or better approach. Although my mentors are helping me a lot but your help will make the project better. And about release, We are planning to release the app during this GSoC period. So, will definitely add the changelog according to your recommendations.
    Himanshu
    @himanshuc3

    I have suggested some comments but the mr is pretty big.

    In general, it is better to not make a mr above a certain number of changes (+500-600), so that it is easy for the reviewer to go through the code and examine the quality of the code. Also, it makes the mr atomic, every merge request should only solve a single problem like a function has a specific task, so that we know the purpose of the mr. This has another advantage that we are not hesitant in merging the pr because it can introduce breaking changes.

    In your case, the idea of the mr is very general and therefore could have been broken down to Conversion of react components to hooks (which in itself could be broken down into 3-4 mrs), removing redundant code (which could also be said to be refactoring) and removing memory leaks.

    Probably too much of an information, so try to slowly think in this way or take up any other way in which code is manageable.

    Ritesh Agrawal
    @Ritesh-Ag
    I was thinking the same. I will take care of that from my next MR. And thank you for the suggestions, I will go through each and every comments and will try to resolve those.
    Abhishek Sharma
    @abhi0504
    hello everyone My name is Abhishek I am trying to install CarbonFootprint-Mobile but got some errors
    I followed all the steps of readme section
    also watched the linked video https://www.youtube.com/watch?v=NpKVA5hL3pM
    Hyper 04-10-2020 22_19_49.png
    Hyper 04-10-2020 22_19_23.png
    Hyper 04-10-2020 22_19_37.png
    Also i didn't find my problems on errors-and-fixes.md and stackoverflow
    madhavgaba
    @madhavgaba_gitlab
    @Ritesh-Ag can you have a look?
    Ritesh Agrawal
    @Ritesh-Ag
    @abhi0504 I think there is some problem with your android sdk. I haven't faced this issue yet. Try building your project using android studio first.
    Abhishek Sharma
    @abhi0504
    how to do this can you share any related video or documentaion
    Ritesh Agrawal
    @Ritesh-Ag
    There ain't ang video. For documentation, I have updated the readme file. Once the MR is merged, You can go through that.
    Abhishek Sharma
    @abhi0504
    ok , thank you
    Abhishek Sharma
    @abhi0504
    @Ritesh-Ag I saw ur new readme file and deleted by whole copy and start with a new one and facing some issues
    image.png
    Ritik Jain
    @Rits1272
    @Ritesh-Ag can you please give access rights to the apk link given in the readme section. I am not able to download the apk. Thanks
    Ritesh Agrawal
    @Ritesh-Ag
    @Rits1272 I think I have given the access
    Although I will cross check it.
    Ritik Jain
    @Rits1272
    I have also requested for access. So you may also check your mail @Ritesh-Ag
    Ritesh Agrawal
    @Ritesh-Ag
    @Rits1272 I have checked. No special access is required. just download the apk or you can check in appetize too.
    Abhishek Sharma
    @abhi0504
    @Ritesh-Ag @Rits1272 I have solved that problem that is due to internet issue now another problem comes up
    image.png
    Ritesh Agrawal
    @Ritesh-Ag
    @Rits1272 You should read the messages carefully. I have told that I have made an MR which is not merged yet. So please wait.
    Abhishek Sharma
    @abhi0504
    @Ritesh-Ag @Rits1272 can You plz help me out
    Ritesh Agrawal
    @Ritesh-Ag
    Have you run the scripts file?
    Ritik Jain
    @Rits1272