Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Harkishen Singh
@Harkishen-Singh
@Aman28temp sure sudo for building purposes. That should solve most issues.
Since dist folder has read permissions only, sudo should be used before building, even though it's a npm install, jspm install or gulp build.
Mohnish Goyal
@mohnishgoyal26_gitlab
Screenshot from 2020-02-04 23-30-05.png
Arteev Raina
@arteevraina
Please Review aossie/MindTheWord/-!522
Lakhman Singh
@Lakhsi_gitlab
@mohnishgoyal26_gitlab please tell some line that what you r trying to do single screenshot is of no use i suppose
@Harkishen-Singh thank for answer
deadpool1999
@deadpool1999_gitlab
can anyone please help me understanding what is this error
Arteev Raina
@arteevraina
can i see the build log?
Arteev Raina
@arteevraina
It says you forgot to run prettier
You may have imported it but not used it
deadpool1999
@deadpool1999_gitlab
yes, but that is in the build process right.
ohh ok fine , will check that thanks !! :)
Kartik Singhal
@KSNINJA
@deadpool1999_gitlab run this command, npm run prettier
It's used to make sure that the code is properly intended. It fails if the code is not formatted properly.
Arteev Raina
@arteevraina
When i select a word and search for similar words using google search, bing search and other respective options but i am not understanding where it has been implemented in the code
??
Kartik Singhal
@KSNINJA
ContextMenu
Arteev Raina
@arteevraina
Thanks @KSNINJA
Arteev Raina
@arteevraina
I was able to find the url for these searchplatforms
I added a new search platform but not able to see it in browser
Arteev Raina
@arteevraina
I created a new context menu but i am not able to see it in chrome
Mohnish Goyal
@mohnishgoyal26_gitlab
@Lakhsi_gitlab Sorry I am new on open source, actually I used the code 'jsdoc -c config.json' but it was not working.
Lakhman Singh
@Lakhsi_gitlab
@arteevraina any error in console ?
Arteev Raina
@arteevraina
No
Lakhman Singh
@Lakhsi_gitlab
@mohnishgoyal26_gitlab dont worry me too new here only telling you to give some error desc
Mohnish Goyal
@mohnishgoyal26_gitlab
Screenshot from 2020-02-08 02-23-58.png
I used the code 'jsdoc -c config.json' but it was not working.
Lakhman Singh
@Lakhsi_gitlab
Are u using ubuntu ? @mohnishgoyal26_gitlab
Dhhyey Desai
@dhhyey-desai
yes he is @Lakhsi_gitlab
Arteev Raina
@arteevraina
I pushed a commit in MindTheWord
But then the pipeline failed for it and in build log it was written that i forgot to run prettier. Then i ran the command npm run prettier and created another commit and pushed it would it create any pipeline fail in the MR?
Kartik Singhal
@KSNINJA
@arteevraina I didn't get your question.
C. Anirudh
@C-Anirudh
@arteevraina use this command to check if your files are formatted correctly prettier --check -- lib/assets/js/main.js lib/scripts/**/*.js test/**/*.js
@Harkishen-Singh could you please review aossie/MindTheWord/-!500
Arteev Raina
@arteevraina
okay
Thanks @C-Anirudh
Pulkit
@pulkit1joshi
I have made changes in my forked repo ... to check it out i am building the project and loading the extension in chrome. But some files (like popup.js) revert back to original. Can anyone help me out with that,
?*
C. Anirudh
@C-Anirudh

Hey @tobehonest this is the basic workflow:

  1. Make changes
  2. Build the project using gulp build command
  3. Refresh if extension already loaded or load the extension as per browser (instructions given in README.md)

Can you please explain what you are doing, so we can figure out where you may be going wrong?

Lakhman Singh
@Lakhsi_gitlab
@C-Anirudh
It means ur changes were not reflected ?
C. Anirudh
@C-Anirudh
@Lakhsi_gitlab yes, unless @tobehonest explains more about what he did, it will be difficult to help..
Pulkit
@pulkit1joshi
I edited popup.js and index.html and then build the project to check it in chrome. However popup.js reverted back to original. I am not sure why it is happening.
C. Anirudh
@C-Anirudh
@tobehonest I think you made changes to popup.jswhich is present at lib/, if you want to make changes to popup.js you must do it at the file present at lib/scripts/controllers. Can you confirm this?
Pulkit
@pulkit1joshi
Yes I did it in lib folder instead of controllers
C. Anirudh
@C-Anirudh
The popup.js in the lib/ folder is generated during build, changes must be made at lib/scripts/controllers/popup.js. Glad you could solve the issue.
Pulkit
@pulkit1joshi
Yes! My Bad ... Thanks
Lakhman Singh
@Lakhsi_gitlab
@C-Anirudh now changes reflecting or not??