Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Arteev Raina
@arteevraina
Thanks @KSNINJA
Arteev Raina
@arteevraina
I was able to find the url for these searchplatforms
I added a new search platform but not able to see it in browser
Arteev Raina
@arteevraina
I created a new context menu but i am not able to see it in chrome
Mohnish Goyal
@mohnishgoyal26_gitlab
@Lakhsi_gitlab Sorry I am new on open source, actually I used the code 'jsdoc -c config.json' but it was not working.
Lakhman Singh
@Lakhsi_gitlab
@arteevraina any error in console ?
Arteev Raina
@arteevraina
No
Lakhman Singh
@Lakhsi_gitlab
@mohnishgoyal26_gitlab dont worry me too new here only telling you to give some error desc
Mohnish Goyal
@mohnishgoyal26_gitlab
Screenshot from 2020-02-08 02-23-58.png
I used the code 'jsdoc -c config.json' but it was not working.
Lakhman Singh
@Lakhsi_gitlab
Are u using ubuntu ? @mohnishgoyal26_gitlab
Dhhyey Desai
@dhhyey-desai
yes he is @Lakhsi_gitlab
Arteev Raina
@arteevraina
I pushed a commit in MindTheWord
But then the pipeline failed for it and in build log it was written that i forgot to run prettier. Then i ran the command npm run prettier and created another commit and pushed it would it create any pipeline fail in the MR?
Kartik Singhal
@KSNINJA
@arteevraina I didn't get your question.
C. Anirudh
@C-Anirudh
@arteevraina use this command to check if your files are formatted correctly prettier --check -- lib/assets/js/main.js lib/scripts/**/*.js test/**/*.js
@Harkishen-Singh could you please review aossie/MindTheWord/-!500
Arteev Raina
@arteevraina
okay
Thanks @C-Anirudh
Pulkit
@pulkit1joshi
I have made changes in my forked repo ... to check it out i am building the project and loading the extension in chrome. But some files (like popup.js) revert back to original. Can anyone help me out with that,
?*
C. Anirudh
@C-Anirudh

Hey @tobehonest this is the basic workflow:

  1. Make changes
  2. Build the project using gulp build command
  3. Refresh if extension already loaded or load the extension as per browser (instructions given in README.md)

Can you please explain what you are doing, so we can figure out where you may be going wrong?

Lakhman Singh
@Lakhsi_gitlab
@C-Anirudh
It means ur changes were not reflected ?
C. Anirudh
@C-Anirudh
@Lakhsi_gitlab yes, unless @tobehonest explains more about what he did, it will be difficult to help..
Pulkit
@pulkit1joshi
I edited popup.js and index.html and then build the project to check it in chrome. However popup.js reverted back to original. I am not sure why it is happening.
C. Anirudh
@C-Anirudh
@tobehonest I think you made changes to popup.jswhich is present at lib/, if you want to make changes to popup.js you must do it at the file present at lib/scripts/controllers. Can you confirm this?
Pulkit
@pulkit1joshi
Yes I did it in lib folder instead of controllers
C. Anirudh
@C-Anirudh
The popup.js in the lib/ folder is generated during build, changes must be made at lib/scripts/controllers/popup.js. Glad you could solve the issue.
Pulkit
@pulkit1joshi
Yes! My Bad ... Thanks
Lakhman Singh
@Lakhsi_gitlab
@C-Anirudh now changes reflecting or not??
C. Anirudh
@C-Anirudh
@Lakhsi_gitlab it was @tobehonest who was facing the issue, I guess it is solved now :)
Lakhman Singh
@Lakhsi_gitlab
Ok
I think most of issue is solved for this project .
C. Anirudh
@C-Anirudh
@Lakhsi_gitlab There is a lot of scope for improvement in the project. You can search for open unresolved issues or create your own
Lakhman Singh
@Lakhsi_gitlab
@C-Anirudh thanx for suggestion let's start working on them
Lakhman Singh
@Lakhsi_gitlab
Can u help us for gsoc , i mean will u be gsoc mentor for this project @Harkishen-Singh
Arteev Raina
@arteevraina
Is this project coming in GSOC 2020?
Harkishen Singh
@Harkishen-Singh
Yes, Mind the word would be participating.
Arteev Raina
@arteevraina
But in this list https://aossie.gitlab.io/pages/ideas.html name of MTW is not mentioned.
Harkishen Singh
@Harkishen-Singh
Would be updated soon
Arteev Raina
@arteevraina
okay thanks @Harkishen-Singh sir
Pulkit
@pulkit1joshi
mtw.png
mtw.png
after cloning and following instructions given here https://gitlab.com/aossie/MindTheWord/blob/master/CONTRIBUTE.md , i am getting following changes using git diff.
C. Anirudh
@C-Anirudh
@tobehonest you have to commit only the changes made to the lib folder for most issues, ignore changes to package.json file,etc
Arteev Raina
@arteevraina
@Harkishen-Singh sir can we work on UI related issues now?
Is the new UI you talked about merged?
Harkishen Singh
@Harkishen-Singh
Yes you can. The New UI is the one in the New-UI-MTW branch.
Arteev Raina
@arteevraina
Idea list still not updated with MTW project?