GitLab | Harkishen Singh pushed 2 commits to MindTheWord
Lakhman Singh
@Lakhsi_gitlab
@C-Anirudh
It means ur changes were not reflected ?
C. Anirudh
@C-Anirudh
@Lakhsi_gitlab yes, unless @tobehonest explains more about what he did, it will be difficult to help..
Pulkit
@pulkit1joshi
I edited popup.js and index.html and then build the project to check it in chrome. However popup.js reverted back to original. I am not sure why it is happening.
C. Anirudh
@C-Anirudh
@tobehonest I think you made changes to popup.jswhich is present at lib/, if you want to make changes to popup.js you must do it at the file present at lib/scripts/controllers. Can you confirm this?
Pulkit
@pulkit1joshi
Yes I did it in lib folder instead of controllers
C. Anirudh
@C-Anirudh
The popup.js in the lib/ folder is generated during build, changes must be made at lib/scripts/controllers/popup.js. Glad you could solve the issue.
Pulkit
@pulkit1joshi
Yes! My Bad ... Thanks
Lakhman Singh
@Lakhsi_gitlab
@C-Anirudh now changes reflecting or not??
C. Anirudh
@C-Anirudh
@Lakhsi_gitlab it was @tobehonest who was facing the issue, I guess it is solved now :)
Lakhman Singh
@Lakhsi_gitlab
Ok
I think most of issue is solved for this project .
C. Anirudh
@C-Anirudh
@Lakhsi_gitlab There is a lot of scope for improvement in the project. You can search for open unresolved issues or create your own
Lakhman Singh
@Lakhsi_gitlab
@C-Anirudh thanx for suggestion let's start working on them
Lakhman Singh
@Lakhsi_gitlab
Can u help us for gsoc , i mean will u be gsoc mentor for this project @Harkishen-Singh