Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Adam M. Szalkowski
    @butzist
    Or to enable/disable root support
    Right now I'm checking for a "su" binary on first startup and set a shared preference
    Ismael
    @Ismael034
    You can leave that and then an option to modify that Shared Preference. Then in the AllTasksListAdapter read that preference and only set the ones that dont need root / all
    I dont think the android-pr.yml will work as you are crating a bundle
    Ismael
    @Ismael034
    Gonna make a PR ;)
    Adam M. Szalkowski
    @butzist
    oops, let me fix that :)
    No, nevermind, I can quickliy force-push :)
    It's assembleDebug, right?
    Ismael
    @Ismael034
    Yep

    name: Debug Build for PR

    on: [pull_request]

    jobs:
    build:

    runs-on: ubuntu-latest
    
    steps:
    - uses: actions/checkout@v2
    - name: set up JDK 11
      uses: actions/setup-java@v2
      with:
        distribution: 'temurin'
        java-version: 11
        cache: 'gradle'
    - name: Download dependencies
      run: ./gradlew androidDependencies
    - name: Build debug
      run: ./gradlew assembleDebug
    - name: Upload APK
      uses: actions/upload-artifact@v1
      with:
        name: apk
        path: ActivityLauncherApp/build/outputs/apk/debug/ActivityLauncherApp-debug.apk

    deploy:
    needs: build
    runs-on: ubuntu-latest
    steps:

    - name: 'Download artifact'
      uses: actions/download-artifact@v2
      with:
        name: apk
        path: ${{ runner.temp }}
    Thats what I did
    Adam M. Szalkowski
    @butzist
    Got it
    Didn't understand why you need the download step
    Ismael
    @Ismael034
    I thought it was neccesary to be able to download the artifact
    I mean I am pretty new to workflows so dont expect much
    Adam M. Szalkowski
    @butzist
    AFAIK this is more about downloading an artifact from another stage...
    Ismael
    @Ismael034
    Can I make a PR to test it out?
    I dont thin kyou can test it manually
    Adam M. Szalkowski
    @butzist
    sure, go ahead
    Ismael
    @Ismael034
    And then delete it
    Adam M. Szalkowski
    @butzist
    btw, sorry about being pedantic on the code review. But the app has 1.5M active users, no QA, and me not having much time :D
    oh, and many angry Russians, if I change anything :D
    Apparently 20% of the users
    Ismael
    @Ismael034
    What happens with the russians? hahaha
    Adam M. Szalkowski
    @butzist
    They seem to like complaining in reviews
    Ismael
    @Ismael034
    Oh, I guess you cant create a workflow if there is a conflic ups
    Adam M. Szalkowski
    @butzist
    created a separate dev channel
    Ismael
    @Ismael034
    Nice! Thanks

    They seem to like complaining in reviews

    What do they say?

    Adam M. Szalkowski
    @butzist
    most complain that I forbid them to open some cache cleaning activity
    Ismael
    @Ismael034
    The workflow is working fine. Nice
    Adam M. Szalkowski
    @butzist
    sweet
    funny thing is that the app should be showing more activities than before :)
    and with the root feature they can potentially open more than before
    Ismael
    @Ismael034

    most complain that I forbid them to open some cache cleaning activity

    I saw a review that said that afer installing the app the screen was reduced in size by half and the browser took control of the phone and couldnt close it lol

    And that the 1 review in Spanish
    Adam M. Szalkowski
    @butzist
    also most of those people seems to have read some tutorial that asks them to use this app
    oh, and then there are those people who accuse me of stealing their data
    probably the same people afraid of bill gates chips in vaccines :P
    Ismael
    @Ismael034
    Wow, this is a super useful app when testing for vulnerabilities in apps. Have been using for a long time and when I saw the comaintainer request I knew I needed to help :D
    Adam M. Szalkowski
    @butzist
    Appreciate :)
    i'm actually not using the app a lot by myself
    and I'm not a fan of Java :P
    What are you doing for a living?
    Ismael
    @Ismael034
    Currently studyding

    and I'm not a fan of Java :P

    Saw there is a kotlin version ;)

    I mean sort of xd
    Adam M. Szalkowski
    @butzist
    Yeah, but Kotlin adds too much size to the binary
    Ismael
    @Ismael034
    @butzist Is the launch Activity functionality working?
    Doesnt seems to do anything, tried on emulator and phone