Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 30 23:07
    mbattersby commented #393
  • Sep 30 17:33
    Rainrider closed #393
  • Sep 30 17:33
    Rainrider commented #393
  • Sep 23 23:37
    mbattersby edited #393
  • Sep 23 23:35
    mbattersby opened #393
  • Sep 23 23:35
    mbattersby labeled #393
  • Sep 22 21:33
    Rainrider closed #383
  • Sep 22 21:33
    Rainrider commented #383
  • Sep 21 05:32
    Rainrider closed #381
  • Sep 14 07:43
    mbattersby commented #363
  • Sep 13 20:06
    Rainrider commented #387
  • Sep 13 19:59
    Rainrider commented #387
  • Sep 13 19:56
    Rainrider commented #387
  • Sep 13 19:50
    Rainrider unlabeled #387
  • Sep 13 19:50
    Rainrider labeled #387
  • Sep 13 19:49
    Rainrider commented #387
  • Sep 13 17:48
    Rainrider closed #386
  • Sep 13 17:48
    Rainrider commented #386
  • Sep 13 01:59
    PaCozz commented #381
  • Sep 13 00:08
    mbattersby commented #366
Rainrider
@Rainrider
Yes, only heroism/ bloodlust is still here
Rainrider
@Rainrider
Adirelle
@Adirelle
are you pushing to both wowace and github in one command (multiple pushurl in .git/config) ?
Adirelle
@Adirelle
(or have you pushed the tag directly to wowace afterwards ?)
Rainrider
@Rainrider
have pushed directly afterwards
after I saw it hadn't pushed automatically
Rainrider
@Rainrider
May I ask about the bit masks in LPS just to be sure I got this right
a word is 32 bits
the lower 13 are for class + racials
the upper 17 are for specials, targeting and flags
the raidbuff mask overlap the lower bits (those for the sources)
so we have 2 bits to spare
and this means that sources for raidbuffs are unobtainable from the mask, but we are not interested in those either way
so I could actually move both DR and Dispels in to replace the current raidbuff masks
as Dispels are currently only 4 (magic, curse, poison and disease)
Rainrider
@Rainrider
and there are actually 5 DR categories we can detect through UNIT_AURA - stuns, roots, incapacitates, disorients and taunts
so we even have room for 4 more to come plus the 2 spare bits available
Rainrider
@Rainrider
I'm unsure though if we need to know the source that provides the dispel but I assume it could be handled like raid buffs
Adirelle
@Adirelle
er... I'll reread that slowly when I'll have more time
btw, could you check that tags on AdiAddons are now pushed correctly, I tried to fix the condition and the pushed reference
Rainrider
@Rainrider
ok, I'll push a beta in a sec
underway
Rainrider
@Rainrider
I can push those manually, it is not a deal
Rainrider
@Rainrider
tags are being pushed now
Rainrider
@Rainrider
LPS bitmasks.png
This is what I said about the bitmasks
1 pic = 1000 words :)
need to figure out how to allow multiple sources for a given aura in LPS now
Adirelle
@Adirelle
hrm, you broke ABA with some totem
I mean, you broke the tests, not the addon
there is a reference to the global UnitName
Rainrider
@Rainrider
Yes, forgot to add this to the globals
The way we check for globals is somewhat strange :)
Adirelle
@Adirelle
why is it strange ?
(or how)
Rainrider
@Rainrider
It is a list of comments which is hard to keep in sync across the diffenrent files
Adding something to the safe env requires changes to all the files using the list
Rainrider
@Rainrider
I switched linting and globals checking to luacheck - see https://github.com/Rainrider/AdiButtonAuras/commits/luacheck
this allows for a single list of allowed globals - see https://github.com/Rainrider/AdiButtonAuras/blob/luacheck/.luacheckrc
Rainrider
@Rainrider
there is also a luacheck package for the atom editor (which I personally prefer for Lua) and it picks .luacheckrc for configuration automatically
other editors are supported as well - see https://github.com/mpeterv/luacheck#editor-support
Please tell me if you are opposed to the change or if I need to add something more
else I'd merge this into master
Adirelle
@Adirelle
Just a small comment, directly on your commit. Beside this, it looks fine to me.
Rainrider
@Rainrider
I answered that. Is there a disadvantage in before_script?
I'll merge to master then. I can move the luacheck command to the script section later if you want that
Adirelle
@Adirelle
is there a way to display the number at the top of a button when the spell actually displays charges ?
Adirelle
@Adirelle
nvm, i'll manage to display the data on another spell
Rainrider
@Rainrider
@Adirelle could you please run the dataminer for LibItemBuffs. See #238
Rainrider
@Rainrider
I ran the extractor myself. It's just crazy how you created all this, respect