(btw, this chan seems to save everything that is said, so some will eventually read anything that is said)
@Adirelle bitmasks for raid buffs seem to be broken
i.e. I would expect that something like
Say I want to remove Mind Quickening and try to use
the bitmasks for SOURCE and RAIDBUFF overlap, is that the issue? maybe
Could you please take a look, as this would take me days
i.e. I would expect that something like
LPS:IterateSpells("RAIDBUFF", nil, "BURST_HASTE") would return all raid buffs except for the bloodlust type. Well it returns Time Warp and Netherwinds among others.LPS:IterateSpells("RAIDBUFF", "CRITICAL") should return all raid buffs that increase critical strike. It returns Mind Quickening, which is haste and multistrike, and Power Word: Fortitude, which is stamina (both are the only priest raid buffs LPS knows about if that matters)Say I want to remove Mind Quickening and try to use
LPS:IterateSpells("RAIDBUFF", "CRITICAL", 49868), then I get totally different results (all the raidbuffs of the following classes if that matters: death knight, druid, monk, paladin, shaman and warrior)the bitmasks for SOURCE and RAIDBUFF overlap, is that the issue? maybe
GetFlagTester needs some special handling of this?Could you please take a look, as this would take me days
they are stored in separate table, because their wasn't enough space in a 32-bit word for all masks
there*
this is a limitation of the current implementation, maybe should it be mentioned in the doc
it would be nice if you could review Rainrider/LibPlayerSpells-1.0@efe500d if your time permits
one test failed, but that is good news in this case, I can fix that if you don't see any issues with it
the only minor issue that remains is that sources[spellId] should return a string for a present category, so the new behavior leads to this:
this is just cosmetics though
115804 is the spellid for Mortal Wounds and Warriors' Mortal Strike applies it
s/many/enough/*
aren't some pet attack on CC DR ? like intimidation ?
we can't tell from which class comes a dispel or a CC
because the bitmasks overlap
the source information for CC is actually available - see https://github.com/AdiAddons/LibPlayerSpells-1.0/blob/master/LibPlayerSpells-1.0.lua#L535-L545
yes, intimidation should be a stun I think
conserning bit masks, basically I followed the way you had done it with raid buffs previously
I missed a few CC in the hunter data
will fix right away
but it is rather ABA related and not LPS
I think it would be better if we would also cache the dispel type
the current rule for dispels, the one that uses LD, iterates over all auras on every UNIT_AURA to find dispellable ones
and I cannot do it with LPS, since it has either the dispel type (which I also need) or the source...
and not exclusives
mortal wounds is a debuff provided by hunter pets, warrior and monk
CC spells could also be combined, but normaly one spells belongs to only one DR category