Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Rainrider
@Rainrider
Adi, I don't know if you are still here, but I just wanted to say thank you for your addons, your code and your patience, I've learned a lot from you
Adirelle
@Adirelle
oh, thanks.
(btw, this chan seems to save everything that is said, so some will eventually read anything that is said)
Hjalte Thor
@hjaltethor
@Adirelle Hey man, I love AdiButtonAuras. Is there a reason you changed Pulverize to Important? Seeing it with the glimmer border, instead of green, seems odd when it's a personal cooldown, much like Savage Defense.
Hjalte Thor
@hjaltethor
@Rainrider I created a pull request to get Stellar Flare added for Druids. Found out it was missing when I had to go Moonkin in a raid the other day.
Rainrider
@Rainrider
@Adirelle bitmasks for raid buffs seem to be broken
i.e. I would expect that something like LPS:IterateSpells("RAIDBUFF", nil, "BURST_HASTE") would return all raid buffs except for the bloodlust type. Well it returns Time Warp and Netherwinds among others.
LPS:IterateSpells("RAIDBUFF", "CRITICAL") should return all raid buffs that increase critical strike. It returns Mind Quickening, which is haste and multistrike, and Power Word: Fortitude, which is stamina (both are the only priest raid buffs LPS knows about if that matters)
Say I want to remove Mind Quickening and try to use LPS:IterateSpells("RAIDBUFF", "CRITICAL", 49868), then I get totally different results (all the raidbuffs of the following classes if that matters: death knight, druid, monk, paladin, shaman and warrior)
the bitmasks for SOURCE and RAIDBUFF overlap, is that the issue? maybe GetFlagTester needs some special handling of this?
Could you please take a look, as this would take me days
Adirelle
@Adirelle
you cannot filter by raid buff, period
they are stored in separate table, because their wasn't enough space in a 32-bit word for all masks
there*
this is a limitation of the current implementation, maybe should it be mentioned in the doc
Rainrider
@Rainrider
I can use the buffMask return of the LPS:IterateSpells("RAIDBUFF") to filter those out then. Thank you for verifiying
Rainrider
@Rainrider
@Adirelle I know I'm getting on your nerves, but I kind of managed to allow for auras with multiple sources (currently Moral Wounds is such a case)
it would be nice if you could review Rainrider/LibPlayerSpells-1.0@efe500d if your time permits
one test failed, but that is good news in this case, I can fix that if you don't see any issues with it
the only minor issue that remains is that sources[spellId] should return a string for a present category, so the new behavior leads to this:
Rainrider
@Rainrider
monks' Rising Sun Kick applies Mortal Wounds, but since Warrior is the last class that gets loaded sources[115804] returns "WARRIOR", so ABA would return that instead of "MONK" through DescribeLPSSource
this is just cosmetics though
115804 is the spellid for Mortal Wounds and Warriors' Mortal Strike applies it
Adirelle
@Adirelle
no, you're not, it's just that I don't have many time to answer
s/many/enough/*
Rainrider
@Rainrider
take your time, nothing is urgent
Adirelle
@Adirelle
looking at your last change to drop DRData and LibDispellable from ouf_Adirelle...
Adirelle
@Adirelle
I see you haven't totally removed LibDispellable from ABA
Adirelle
@Adirelle
I'm reviewing hunter's spells
aren't some pet attack on CC DR ? like intimidation ?
Adirelle
@Adirelle
ok, so looking at the bit masks, I thing we have an issue
we can't tell from which class comes a dispel or a CC
because the bitmasks overlap
Adirelle
@Adirelle
possible solution => AdiAddons/LibPlayerSpells-1.0#102
Rainrider
@Rainrider
nope, LD is not removed since I didn't have the time to re-write the rules for dispels
the source information for CC is actually available - see https://github.com/AdiAddons/LibPlayerSpells-1.0/blob/master/LibPlayerSpells-1.0.lua#L535-L545
yes, intimidation should be a stun I think
conserning bit masks, basically I followed the way you had done it with raid buffs previously
Rainrider
@Rainrider
special flags can be looked up in lib.__specials.CROWD_CTRL and lib.__specials.DISPEL respectively
Rainrider
@Rainrider
sources are in lib.__spells
I missed a few CC in the hunter data
will fix right away
Rainrider
@Rainrider
as for dispels there was also something I wanted to consider before re-writing the rules
but it is rather ABA related and not LPS
I think it would be better if we would also cache the dispel type
the current rule for dispels, the one that uses LD, iterates over all auras on every UNIT_AURA to find dispellable ones
Rainrider
@Rainrider
and that is an extra effort since ABA has also the aura cache for the unit in question
Adirelle
@Adirelle
in ouf_adirelle, I need to know the Dispel spells of the class of the current player
and I cannot do it with LPS, since it has either the dispel type (which I also need) or the source...
Adirelle
@Adirelle
I've just realized that dispel types are combined
and not exclusives
Rainrider
@Rainrider
so are sources
mortal wounds is a debuff provided by hunter pets, warrior and monk
CC spells could also be combined, but normaly one spells belongs to only one DR category
Rainrider
@Rainrider
What do you think about AdiAddons/LibPlayerSpells-1.0#106 Should we accept or decline?