Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 28 2016 04:24

    AlanLGuy on gherkin3

    preliminary refactor of builder… (compare)

  • Jan 26 2016 15:11

    AlanLGuy on gherkin3

    fix gemspec (compare)

  • Jan 26 2016 00:02

    AlanLGuy on gherkin3

    fixing builder to work with Ghe… (compare)

  • Dec 18 2015 12:15
    bbellanc added as member
  • Oct 27 2015 00:31

    AlanLGuy on master

    Fix for Jruby, though we still … fix MRI (cherry picked from com… Merge pull request #8 from Alan… (compare)

  • Oct 27 2015 00:31
    AlanLGuy closed #8
  • Oct 27 2015 00:30
    AlanLGuy opened #8
  • Sep 04 2015 00:22

    AlanLGuy on jruby_fix

    Fix for Jruby, though we still … fix MRI (cherry picked from com… (compare)

  • Apr 09 2015 03:15

    daneandersen on refactor_tests

    Parsed big pile of tests out in… (compare)

  • Apr 07 2015 18:19
    daneandersen labeled #7
  • Apr 07 2015 18:19
    daneandersen labeled #7
  • Apr 07 2015 18:15
    daneandersen opened #7
  • Mar 06 2015 14:11
    AlanLGuy opened #6
  • Mar 03 2015 15:40
    AlanLGuy opened #5
  • Feb 25 2015 14:32
    AlanLGuy commented #3
  • Feb 25 2015 02:30

    AlanLGuy on master

    Fixes #3 - Added Scenario and t… (compare)

  • Feb 25 2015 02:30
    AlanLGuy closed #3
  • Feb 20 2015 00:46

    AlanLGuy on refactor_tests

    Added additional acceptance tes… (compare)

  • Feb 07 2015 01:28

    AlanLGuy on refactor_tests

    Fixes #3 - Added Scenario and t… (compare)

  • Feb 06 2015 03:51

    AlanLGuy on refactor_tests

    add description to scenario for… (compare)

Dane Andersen
@daneandersen
Hello
Alan Guy
@AlanLGuy
Word up
Alan Guy
@AlanLGuy
so basically rspec-gherkin.rb harcode the feature mapping to 'features/*/.feature' which totally screws up all the loader
oops, means features/*/.feature
oh... the chat just screws it up
thats sketchy
Dane Andersen
@daneandersen
Haha nice. Can you describe it with words for symbols?
Alan Guy
@AlanLGuy
rofl, essentially it hardcodes the feature mapping to the features directory to a regex path beneath features, so it will never find that example project directory
Dane Andersen
@daneandersen
Interesting... I don't mind opinionated design too much, but is that too restrictive?
Alan Guy
@AlanLGuy
possibly... though im not entirely convinced that's the issue now that I'm looking at it closer... it's weird... it gets all the way to the specify call in the scenario method... test never gets run by rspec..
yup.. I have no idea whats going on here. I'm thoroughly flumoxed
Alan Guy
@AlanLGuy
So I went ahead and committed some of the changes I made to the refactor_tests branch. I was having some issue with setting up the unit test rake task. currently I've added a tag spec:true to all of the unit tests, which isn't very desirable, but I couldn't find a pattern that excluded the specs in /features. I'm sure the solution is probably incredibly simple... but it escapes me :(
sciros
@sciros
Hey dudes. Just saying hi & joining the conversation.
I'm going to try and pull your work next week and just look through it. I want to mention this work at QA or the Highway, if briefly.
Alan Guy
@AlanLGuy
Sounds good. Dane has started working on refactoring some of the tests, I've been contributing a bit to that effort, but there was also a pretty painful issue I wanted to resolve as well.
Alan Guy
@AlanLGuy

oh and @daneandersen , I don't know if you remember, but I had said a few weeks back that I think most of the RSpecGherkin::DSL could be implemented through RSpec's new API (specifically the ability to alias a method to #example and #example_group). I was looking into it and it looks like it could be done and it would solve some of the weird issues with backtrace line numbers getting lost.

The only real pain point with that is re-implementing the detection of missing scenarios and the update tag. Those could be pretty easily implemented in a hook, but I'm not certain if that's the best approach or not... Maybe Monday I'll get my coffee on the 4th floor (you guys are on the 4th now right?) and bounce some ideas off you.