So yes, please go ahead and merge.
Okay, I pushed those changes ('\0' four times, plus (1+end-begin) fix in dafgsr) to my pr217/master-with-fixes branch, so it is now part of pr218. travis passed all linux tests, failed on osx/Py2.7.13, is working of osx/Py3.x, passed the first two appeyor tests, and coverage is still at 100%.
I tweaked the docstring in dafgsr, and found another typo (happend should be happened).
I could also do a trivial edit on that last requested change to clear the other red [x].
@drbitboy so I merged in your changes using a merge squash to combine all the commits to one. It looks like you may have switched computers or changed your git authorship settings as currently github is not linked with your kinetx.com email account. I can fix this by changing the commit and force pushing to the repo or you can just add it to your account info at https://github.com/settings/emails
If I had saw that earlier I would have made sure to use the gmail address instead
Does it matter which email account is associated with github? My main accounts are drbitboy@gmail.com and briantcarcich@gmail.com. I am wondering how you associated me with my kinetx account?
anyway, thanks, that is great.
okay, I added the kinetx email to my github account.
anyways, I see that you are now credited.
I also issued a PR for the smaller kernel set. That will obviously take a lot more time to review; feel free to ping me back with any queries about what I put in there.
Also, thanks for making the contributing guide; the PRs should take less work now (e.g. I originally had not thought to add the license on the new DE-405S script).
@drbitboy take a look at my most recent commits, there were a number of issues with the newly wrapped ek functions that ended up needing to be fixed. although contributions are great, there were a few too many changes limiting my ability to do a proper review and I can't keep up with the number of PRs I have received either (and I am in grad school).
I understand that you won't be merging these any time soon, that is fine. Let me know when would be a good time issue new PRs.
I was just thinking, the stress tests do exactly the same thing over and over.
In fact, the underlying system (Python, garbage collector O/S, etc.) probably does exactly the same thing too i.e. after the first few passes it probably allocates exactly the same memory for each variable every time.
A way to get around that would be to change something in the underlying system each time. e.g.
guard = []
for iPass in range(500):
guard = guard + range(555)
test_spk14a()
Yup, 33 calls to spice.spk14a, only five unique memory address pairs for coeffs and epochs:
$ git diff
diff --git a/spiceypy/spiceypy.py b/spiceypy/spiceypy.py
index 6de592e..5c5d6cc 100644
--- a/spiceypy/spiceypy.py
+++ b/spiceypy/spiceypy.py
@@ -11119,6 +11119,8 @@ def spk14a(handle, ncsets, coeffs, epochs):
ncsets = ctypes.c_int(ncsets)
coeffs = stypes.toDoubleVector(coeffs)
epochs = stypes.toDoubleVector(epochs)
+ with open('spk14a_pointers.log','ab') as fOut:
+ fOut.write('{},{}\n'.format(coeffs.__repr__(),epochs.__repr__()))
libspice.spk14a_c(handle, ncsets, coeffs, epochs)
$ python setup.py test
...
$ awk '!($0 in d){d[$0]=FNR}{print $0,FNR,d[$0]}' spk14a_pointers.log
<spiceypy.utils.support_types.c_double_Array_80 object at 0x7f9c929bb290>,<spiceypy.utils.libspicehelper.c_double_Array_4 object at 0x7f9c929bb8c0> 1 1
<spiceypy.utils.support_types.c_double_Array_80 object at 0x7f9c929bb4d0>,<spiceypy.utils.libspicehelper.c_double_Array_4 object at 0x7f9c929bb290> 2 2
<spiceypy.utils.support_types.c_double_Array_80 object at 0x7f9c929bb950>,<spiceypy.utils.libspicehelper.c_double_Array_4 object at 0x7f9c929bb4d0> 3 3
<spiceypy.utils.support_types.c_double_Array_80 object at 0x7f9c929bb560>,<spiceypy.utils.libspicehelper.c_double_Array_4 object at 0x7f9c929bb950> 4 4
<spiceypy.utils.support_types.c_double_Array_80 object at 0x7f9c929bb8c0>,<spiceypy.utils.libspicehelper.c_double_Array_4 object at 0x7f9c929bb560> 5 5
<spiceypy.utils.support_types.c_double_Array_80 object at 0x7f9c929bb290>,<spiceypy.utils.libspicehelper.c_double_Array_4 object at 0x7f9c929bb8c0> 6 1
<spiceypy.utils.support_types.c_double_Array_80 object at 0x7f9c929bb4d0>,<spiceypy.utils.libspicehelper.c_double_Array_4 object at 0x7f9c929bb290> 7 2
<spiceypy.utils.support_types.c_double_Array_80 object at 0x7f9c929bb950>,<spiceypy.utils.libspicehelper.c_double_Array_4 object at 0x7f9c929bb4d0> 8 3
<spiceypy.utils.support_types.c_double_Array_80 object at 0x7f9c929bb560>,<spiceypy.utils.libspicehelper.c_double_Array_4 object at 0x7f9c929bb950> 9 4
<spiceypy.utils.support_types.c_double_Array_80 object at 0x7f9c929bb8c0>,<spiceypy.utils.libspicehelper.c_double_Array_4 object at 0x7f9c929bb560> 10 5
<spiceypy.utils.support_types.c_double_Array_80 object at 0x7f9c929bb290>,<spiceypy.utils.libspicehelper.c_double_Array_4 object at 0x7f9c929bb8c0> 11 1
<spiceypy.utils.support_types.c_double_Array_80 object at 0x7f9c929bb4d0>,<spiceypy.utils.libspicehelper.c_double_Array_4 object at 0x7f9c929bb290> 12 2
<spiceypy.utils.support_types.c_double_Array_80 object at 0x7f9c929bb950>,<spiceypy.utils.libspicehelper.c_double_Array_4 object at 0x7f9c929bb4d0> 13 3
<spiceypy.utils.support_types.c_double_Array_80 object at 0x7f9c929bb560>,<spiceypy.utils.libspicehelper.c_double_Array_4 object at 0x7f9c929bb950> 14 4
...
<spiceypy.utils.support_types.c_double_Array_80 object at 0x7f9c929bb560>,<spiceypy.utils.libspicehelper.c_double_Array_4 object at 0x7f9c929bb950> 29 4
<spiceypy.utils.support_types.c_double_Array_80 object at 0x7f9c929bb8c0>,<spiceypy.utils.libspicehelper.c_double_Array_4 object at 0x7f9c929bb560> 30 5
<spiceypy.utils.support_types.c_double_Array_80 object at 0x7f9c929bb290>,<spiceypy.utils.libspicehelper.c_double_Array_4 object at 0x7f9c929bb8c0> 31 1
<spiceypy.utils.support_types.c_double_Array_80 object at 0x7f9c929bb4d0>,<spiceypy.utils.libspicehelper.c_double_Array_4 object at 0x7f9c929bb290> 32 2
<spiceypy.utils.support_types.c_double_Array_80 object at 0x7f9c929bb950>,<spiceypy.utils.libspicehelper.c_double_Array_4 object at 0x7f9c929bb4d0> 33 3
now i'm worried no one is listening... =X
@AndrewAnnex are you around at least? (hail mary here...haha)
i feel a bit more comfortable in slack, so i'll head over there (i was just given the invite today). now that i have access to that workspace, and given that my question(s) are related more to general orbital mechanics and not issues with SpiceyPy itself, i don't want to waste your time...unless you enjoy that type of problem solving in general.. =]
I am planning to use SpiceyPy for a University project and for sure it will be really useful :thumbsup:
Also BTW version 2.2.0 was released a few days ago! Conda forge distribution still needs to be updated though, so it may take a few days.