These are chat archives for AnotherIndieDevStudio/CoopGameMaking

7th
May 2015
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 08:45

kek

Tribuadore
@Tribuadore
May 07 2015 08:58
Hey hey
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 08:58
Hey how's it going?
Tribuadore
@Tribuadore
May 07 2015 08:58
Good idea gitter
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 08:58
Good to know this chat room actually works
Tribuadore
@Tribuadore
May 07 2015 08:58
Yeah, its awesome
So you are reallydankpie?
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 09:00
Yeah
Tribuadore
@Tribuadore
May 07 2015 09:00
Ah k, cool
Yeah get into Node
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 09:00
this is just a shared account for the project
Yeah I have been meaning to for a long time
I just never got around to it
Tribuadore
@Tribuadore
May 07 2015 09:00
Have you seen the other guys pull request for the node server?
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 09:00
Yeah I am just thinking of a good way to implement it
Tribuadore
@Tribuadore
May 07 2015 09:00
I'd like to work on (what I consider) a simpler one
But I don't want to tread on his toes
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 09:01
Well right now it has an issue with saving right?
when the save buttons are pushed etc
Tribuadore
@Tribuadore
May 07 2015 09:01
I could have the Node server deal with save and load events
Yeah, too easy
then you wouldn't need the localstorage hack
cause you could be running the game on localhost:8000 on a Node service
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 09:02
lol yeah
well
Tribuadore
@Tribuadore
May 07 2015 09:02
the node service doesn't need to host the php files
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 09:02
is there a way
nevermind
thought about it and it made no sense
Tribuadore
@Tribuadore
May 07 2015 09:03
it can just see the request for the php files from the client and save the parameters to disk
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 09:03
ah yeah you just reminded me
I need to work on the php files
Tribuadore
@Tribuadore
May 07 2015 09:03
I'm not use to git in a team environment
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 09:04
Neither am I
I am not even used to a team environment
Tribuadore
@Tribuadore
May 07 2015 09:04
do i work on a separate pull request that trumps this other guys?
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 09:04
besides 1-3 people
Tribuadore
@Tribuadore
May 07 2015 09:04
and we vote for the pull request that gets accepted?
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 09:04
Yeah I think that is a good idea
Tribuadore
@Tribuadore
May 07 2015 09:04
ok, i'll work on that now
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 09:04
all right
easy
im going to work on the php files so ill be afk for a bit
Tribuadore
@Tribuadore
May 07 2015 09:05
k
Tribuadore
@Tribuadore
May 07 2015 09:52
Is the save id a calculated value based on the input id?
It's ok, i'll just use the id passed as input on a save event from the client as the save id response
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 10:03
my bad
was eating dinner
Tribuadore
@Tribuadore
May 07 2015 10:03
yeah it's all good
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 10:03
the input_id = save_id
Tribuadore
@Tribuadore
May 07 2015 10:04
looks different on the live version
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 10:04
?
The ID generated in server_handle is just a seed for the one generated in PHP
Tribuadore
@Tribuadore
May 07 2015 10:04
so on the save request the id=68ce5abd-cb7d-4659-8681-053cc865af47
but the response is 7d8bc416cd2dc32e21333e0dc82a7bf7
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 10:05
yeah
Js ID > PHP File > PHP ID
Tribuadore
@Tribuadore
May 07 2015 10:05
so which id is the person entering in the load call?
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 10:06
the response ID
Tribuadore
@Tribuadore
May 07 2015 10:06
the save param id or the response id
oh ok
so i can ignore the param id on the save call
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 10:06
yeah
it's not for the client
just for the server
Tribuadore
@Tribuadore
May 07 2015 10:07
i guess for the purposes of the dev node server, i'll just use the clients generated id param value though
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 10:07
would that be a good idea?
the response ID is the onyl one shown to the user
only*
Tribuadore
@Tribuadore
May 07 2015 10:08
oh ok yeah, this cames down to what id to show the user
i could even make it start at 1
1, 2, 3, 4, 5, ....
ok i understand now, or even a random UUID
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 10:09
yeah
I have tidied the code up a bit as well
Danny
@rawvoltage
May 07 2015 10:09
Night guys, gonna sleep. Good luck with everything.
I'll be back after work.
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 10:09
alright mate good night
cheers for the contributions as well
Tribuadore
@Tribuadore
May 07 2015 10:09
cya
Danny
@rawvoltage
May 07 2015 10:09
Great learning experience. Later guys!
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 10:10
just for your reference
in the cleaner code
HTML id's and classes use the following naming convention: named-variable
in the JS, the variables use the following convention: named_variable
functions should also follow the js convention
except server side functions which should follow namedVariable
Tribuadore
@Tribuadore
May 07 2015 10:11
:(
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 10:11
it's just a way of easily differentiating between what comes from what
it was stated that this should be changed as a bug fix on reddit
Tribuadore
@Tribuadore
May 07 2015 10:12
did you know DOM @id's pollute the global name space
i'm cool with what ever naming convention ppl want
you know how your using jQuery to reference all these elements
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 10:13
I know
Tribuadore
@Tribuadore
May 07 2015 10:13
you can simply reference them directly using the id
type level_s in your javascript console
and press enter
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 10:14
oh I did not know this
Tribuadore
@Tribuadore
May 07 2015 10:15
you don't need jQuery
i fucken hate it
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 10:15
fair enough
well I will probably work on it tomorrow and get rid of all unneeded jquery
Tribuadore
@Tribuadore
May 07 2015 10:17
ok so i'll using namedVariable for server side naming
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 10:17
yeah
Tribuadore
@Tribuadore
May 07 2015 10:17
i was going to call the file itself develoment_server.js
should I be going for develomentServer.js
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 10:18
yeah that would make sense
Tribuadore
@Tribuadore
May 07 2015 10:18
ok
Tribuadore
@Tribuadore
May 07 2015 10:29
omg, haha
your response from a load request
i'll go with it for now
:)
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 10:30
please...
the save/load was a last minute thing
it's good
believe
Tribuadore
@Tribuadore
May 07 2015 10:31
I believe
i want to believe
Tribuadore
@Tribuadore
May 07 2015 10:53
ok i've got save/load working
how do i do a pull request
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 10:54
so you have the project forked right?
modify the code
go to you fork page
Tribuadore
@Tribuadore
May 07 2015 10:54
yeah i forked it
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 10:54
wait hold on
all right
so on the side there should be a button title "Pull Request"
When you are there, there should be a big green button with the text "New Pull Request"
Tribuadore
@Tribuadore
May 07 2015 10:56
on the side of what
of your repo?
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 10:56
of your fork
Tribuadore
@Tribuadore
May 07 2015 10:56
oh ok
gawd, my wife wants me to watch struggle strett
*street
anyway i have time to finish the pull request
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 10:59
aha it's supposed to be shit
Tribuadore
@Tribuadore
May 07 2015 10:59
oh so i should not have push a commit to my fork
or do i do that first
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 11:00
yeah you have to commit to your fork
Tribuadore
@Tribuadore
May 07 2015 11:00
oh good
ok done that
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 11:00
get github for windows
makes things allot easier
if your using windows machine
you're using a*
Tribuadore
@Tribuadore
May 07 2015 11:01
yeah i like the command line
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 07 2015 11:02
I'm going to submit this push and then go play a few games of leauge so ill ttyl
cheers for the contribution as well
Tribuadore
@Tribuadore
May 07 2015 11:03
no worries
cya round
Tribuadore
@Tribuadore
May 07 2015 11:08
ok, pull request #9 created
Drew McArthur
@DrewMcArthur
May 07 2015 20:50
I closed my pull request, since Tribuadore accomplished what I was attempting to do, although better. Pulling in his changes shouldn't break anything server side, so I vote for a merge. It should simply add functionality, rather than changing it.
Armin Stepanjan
@ab-10
May 07 2015 21:00
Hello, I just joined the project, so it possibly has already been reported, but: [BUG] Can't add skillpoints to Dexterity.