These are chat archives for AnotherIndieDevStudio/CoopGameMaking

8th
May 2015
John Alex
@JhonnyAl
May 08 2015 00:31
It's already fixed in the github code.
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 00:32
Will check live site when I get to my Comour
Computer*
Will also be committing node.js implementation
Tribuadore
@Tribuadore
May 08 2015 00:37
Hello people
John Alex
@JhonnyAl
May 08 2015 00:37
Sup
Tribuadore
@Tribuadore
May 08 2015 00:38
Yeah, you are going accept my Node server pull
Happy days
I just created another pull to fix some jshint validation warnings
Pull #11
AnotherIndieDevStudio/Coopgamemaking-01#11
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 00:45
All right. I figured it isn't game play related and is really just a develop QOL update
Tribuadore
@Tribuadore
May 08 2015 00:45
Yeah, that's true
Tribuadore
@Tribuadore
May 08 2015 00:52
The pollution of the global namespace and the way the save response works is hurting my head
They are both tied together as the save response realise on those variables being global to set their values
If I was to clean up the global namespace, we'd need the server response for a save to change aswell
The server files don't seem to be a part of the repository
I post a "Working on" post on reddit, but part of it would need buy-in from the server coder to change the load response.
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 00:56
I can modify the server files if you want to tidy up the global namespace
Tribuadore
@Tribuadore
May 08 2015 00:56
I meant the load response, in my comments above, not the save response
Ok, i'll post that "working on" reddit post
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 00:57
Yeah load Response is dodgy af
Tribuadore
@Tribuadore
May 08 2015 00:57
lol
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 00:58
It works though
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 01:53
Ok
a few QOL changes have been made
Tribuadore
@Tribuadore
May 08 2015 01:53
Yay
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 01:53
Made the ID selectable again on the live version
development server options in the repository
tidied up styling a bit
Patch 0.02 notes being released now on reddit
Also changed reddit style to something readable
Tribuadore
@Tribuadore
May 08 2015 01:56
You didn't merge pull #11
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 01:57
one sec
Tribuadore
@Tribuadore
May 08 2015 01:57
There are still missing semi-colons and such
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 02:09
ok merged
Tribuadore
@Tribuadore
May 08 2015 02:09
Thank you
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 02:10
Thoughts on normalize.css
I don't think it is needed
Tribuadore
@Tribuadore
May 08 2015 02:10
Neither do I
It's great if you are making a textual based website
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 02:10
See where it gets voted to on Sunday
Tribuadore
@Tribuadore
May 08 2015 02:11
If you like I'll add a comment on the reddit post, saying my opinion is that it's not needed
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 02:11
I just did :^)
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 02:59
Ok PHP files updated with prepared statementsz
Tribuadore
@Tribuadore
May 08 2015 03:03
Well done
Lol the dragons life-cycle post is so funny
The guys definitely got a thing about dragons
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 03:04
Yeah aha
I am going to update the loadgame response to return JSON
and create a parser in save_handle.js
Tribuadore
@Tribuadore
May 08 2015 03:05
Cool
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 03:05
just to tidy up things
Tribuadore
@Tribuadore
May 08 2015 03:06
Are you going with the JSON verbatim that I suggested?
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 03:06
Yeah
Tribuadore
@Tribuadore
May 08 2015 03:07
Ok cool, I'll update the node development server to return that now. Which allows me to take all that out of the global namespace
If I don't get distracted by work, I should have a pull soonish
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 03:08
Yeah I am going out for lunch in a bit so it probably won't be done to soon.
Tribuadore
@Tribuadore
May 08 2015 03:08
Enjoy
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 03:09
I'll let you know when it is up
thanks
Tribuadore
@Tribuadore
May 08 2015 05:02
AnotherIndieDevStudio/Coopgamemaking-01#14
Pull request for unpolluted global namespace and loadgame.php response update
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 06:02
ok
I am back and I am goign to work on the response
as well as the server_handle.js file
I will also be adding a Max Health variable
and wiping the database for the new variable introduction
I plan on having it complete by 7PM WST as I have other things to do in the mean time
Tribuadore
@Tribuadore
May 08 2015 06:03
i've already updated server_handle.js in pull #14
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 06:03
oh ok
thanks
ill tkae a look at it
Tribuadore
@Tribuadore
May 08 2015 06:03
thanks
I'm working on a basic renderer layer now
Tribuadore
@Tribuadore
May 08 2015 06:20
Sample rendering layer added AnotherIndieDevStudio/Coopgamemaking-01#15
I have to run, cya's
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 06:26
see you later
thanks for the help as well
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 06:46
ok a few fixes
made to the pull request
  1. Save id returns to the JS generated ID when pressing save again
  1. Request doesn't check for failed ID
2*
Other than that
I have gone through majority of the code and it looks allot easier to work with now
good job
I have fixed the few things that needed to be fixed
updated the server files
will be up asap
and pushed to GIT
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 07:53
Edited code is live
and posted to GitGub
GitHub*
Thanks for the massive contribution @Tribuadore
I have talked to @AnotherBadPie and we decided to create a badge for "Top Contributor" whereby we award anyone who contributes a large amount to this project.
You are the first recipient of this
Thanks again
Ian McCarthy
@killarneyman
May 08 2015 08:16
Hello there, just taking a look at the code there. Is there a list of tickets anywhere for this? Tasks agreed on from the subreddit? Or do we just make pull requests for whatever we fancy?
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 08:45
So basically you submit a pull request and post that pull request on the subreddit
With a description of what the pull request is
Tribuadore
@Tribuadore
May 08 2015 08:47
Thanks for the that guys
Tribuadore
@Tribuadore
May 08 2015 09:30
Is anyone from AIDS available at the moment?
Alex Bickford
@BeatAlex
May 08 2015 10:00
Hi
Tribuadore
@Tribuadore
May 08 2015 10:01
Hello
How ya doing?
Alex Bickford
@BeatAlex
May 08 2015 10:01
Good thanks, you?
Tribuadore
@Tribuadore
May 08 2015 10:02
Yep, well. Its Friday night here. Listening to Live throwing copper on the lounge and coding.
Alex Bickford
@BeatAlex
May 08 2015 10:03
Nice, Friday 11am here.
At work :(
I made my first pull request though! AnotherIndieDevStudio/Coopgamemaking-01#16
Tried to 'tidy' the code up so there's less but does the same.
Tribuadore
@Tribuadore
May 08 2015 10:03
Yeah I say, nice stuff
Alex Bickford
@BeatAlex
May 08 2015 10:03
And added a +1 or +10 depending on stat upgraded that comes from cursor.
Tribuadore
@Tribuadore
May 08 2015 10:03
*saw
Alex Bickford
@BeatAlex
May 08 2015 10:04
Don't know if it's any good but it's all experience :)
Tribuadore
@Tribuadore
May 08 2015 10:04
Is that based off the current upstream master?
Cause I know they did a tidy up not long ago
Alex Bickford
@BeatAlex
May 08 2015 10:04
Yeah I synced about 2 hours ago
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 10:04
I'm here
Alex Bickford
@BeatAlex
May 08 2015 10:05
So after the whole clean up of code :)
Tribuadore
@Tribuadore
May 08 2015 10:05
Hello
Alex Bickford
@BeatAlex
May 08 2015 10:05
Hi
Tribuadore
@Tribuadore
May 08 2015 10:05
Yeah my renderer layer pull looks like a mess
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 10:05
@Tribuadore what did you need?
Tribuadore
@Tribuadore
May 08 2015 10:05
My renderer pull request looks a mess
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 10:06
I haven't look at it yet
I will take a look now
Tribuadore
@Tribuadore
May 08 2015 10:06
Cause its based off my older global namespace branch before it got merged into upstream master
How do I clean up the renderer pull so it looks more in sync with master
its says there are like 7 files different, but they are not
Most of the differences are already in upstream master
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 10:07
So grab the pull on to your machine
and edit it
and then submit a new pull request
I don't know if there is a way to edit a pull
Tribuadore
@Tribuadore
May 08 2015 10:07
Oh ok, so just submit a new pull
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 10:07
pull request*
yeah
Tribuadore
@Tribuadore
May 08 2015 10:07
Ok, that one can be deleted than. Cool
Thanks
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 10:08
All right
@BeatAlex I'll take a look at your code now
Alex Bickford
@BeatAlex
May 08 2015 10:08
Thank you :)
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 10:09
oh nice
the visual stat increase is quite good
I am going to add it to my branch and change a few things then merge it with the master
thank you for your contribution
just changing the css a bit
to make some elements unselectable
Alex Bickford
@BeatAlex
May 08 2015 10:12
Yay! Thanks :)
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 10:29
Wasn't my idea but AnotherBadPie decided to give you a +1 flair. We will be giving out a lot more flairs to those who participate especially during this early phase.
Tribuadore
@Tribuadore
May 08 2015 10:33
Congrats Beat
Oh me. haha
Tribuadore
@Tribuadore
May 08 2015 10:38
Yay, pull #15 only shows two differences now
Alex Bickford
@BeatAlex
May 08 2015 10:50
Need to get contributing now then :D
Congrats Trib
Oh wait I have a +1 too
You're top contributor
Thanks :D
Tribuadore
@Tribuadore
May 08 2015 10:51
Well done
Alex Bickford
@BeatAlex
May 08 2015 10:52
It's confusing seeing flairs before not after the names though :P
Thanks Trib
Alex Bickford
@BeatAlex
May 08 2015 13:46
Made a new thread.
Let me know what you think, if it's worth doing I'll do a pull request, but I don't know what others are doing.
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 13:48
Looks good but this comes under graphical updates so just wait and see what the community thinks
if it gets enough votes, it will be added into the game
Alex Bickford
@BeatAlex
May 08 2015 13:54
Ah ok thanks :)
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 14:01
all right I'm going to play a few games of league and then go to bed
thanks to everyone who contributed
see you guys later
Alex Bickford
@BeatAlex
May 08 2015 14:04
See you later man! Have fun!
I wont be contributed over the weekend or in the chat, but will be on Reddit. :)
contributing*
AnotherIndieDevStudio
@AnotherIndieDevStudio
May 08 2015 14:06
Ok no problem. Remember all qualified submissions will be announced Sunday.
Alex Bickford
@BeatAlex
May 08 2015 14:08
OK Sounds good! Thanks :)