hey @matthid , are you around ?
Hey, yes whats up?
Can you tell me if you recall, in versions prior to 3.5 did RE store the compiled templates on disk or in memory ?
In memory (which has some downsides), but you can still to it with DisableTempFileLocking (so I basically changed the default)
i have a theory on why using linq methods on dynamic properties blows up now and it didn't before
ah, i see
why would it matter on linq methods?
something to do with parts of anon/dynamic objects being internal
and since they are stored outside of the memory now, they are different assembly
and executing assembly not being able to see the internal stuff and blowing up
First if you use dynamic we have some RazorEngine internal trickery in place to wrap the dynamic/anon object so that you can access internal stuff in the template
Second its not a RazorEngine limitation as the following code shows:
using System;
using System.Linq;
public class Test
{
public static dynamic TestMethod()
{
var a = new[] { "first", "second", "self" };
var ext = a.First();
dynamic c = new[] {"first", "second", "self"};
return c.First();
}
public static void Main(string[] args)
{
string ret = TestMethod();
}
}try to compile an run it
yeah, it blows up
sorry if i'm being annoying, i'm just trying to understand what has changed, and why my code blows up now
Sorry if my answers felt rude, I just tried to get them on point. By the way a lot of things changed in 3.5 but I tried my best to make everything as much backwards compatible as possible... This especially this place (dynamic/anonymous classes) is a minefield...
It wasn't rude :)
It might have worked in the past because we used to try to "guess" the type with a combination of generic parameter and "model.GetType()" which often worked as expected, often worked (but not as one would imagine) and sometimes failed in some corner cases.
But from your description I would say it was a bug if it ever worked (without knowing the exact template and RazorEngine call you used)
in my case i tried to construct a dynamic object form a dictionary
var tpl = Razor.GetTemplate(templateHtml, new {}, pageCacheKey);
var viewbag = new DynamicViewBag();
var ctx = new ExecuteContext(viewbag);
var result = tpl.Run(ctx);
Ok I broke this kind of usage anyway: https://github.com/Antaris/RazorEngine/blob/d4db0de27b781dfc10d1f2c5a1e2f48d5f6c4707/src/source/RazorEngine.Core/Templating/ExecuteContext.cs#L34
Getting the template object directly is kind of unsafe
Getting the template object directly is kind of unsafe
Is there something blocking you from updating to the latest API (Documentation: https://antaris.github.io/RazorEngine/index.html)
i was't using the viewbag anyway
no, i've updated fully
but found that couple of client templates broke after the update
(writing my own CMS for clients, and whatnot )
a concrete sample would be nice: the template, the old RazorEngine call and the new call
i will try to get that to you
@matthid Good night, and thanks for the help & your time !
Good night, you are welcome :)