by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 10 2016 13:11
    remojansen closed #10
  • Aug 10 2016 13:11
    remojansen closed #21
  • Aug 10 2016 13:11
    remojansen closed #20
  • Aug 10 2016 13:11
    remojansen closed #15
  • Aug 10 2016 13:11
    remojansen closed #14
  • Aug 10 2016 13:11
    remojansen closed #11
  • Aug 10 2016 13:11
    remojansen closed #17
  • Sep 02 2015 09:35
    remojansen commented #15
  • Sep 02 2015 09:34
    remojansen labeled #15
  • Sep 02 2015 09:34
    remojansen closed #7
  • May 28 2015 09:19
    remojansen labeled #21
  • May 28 2015 09:19
    remojansen opened #21
  • May 28 2015 09:19
    remojansen labeled #21
  • May 27 2015 20:41
    remojansen assigned #20
  • May 27 2015 20:41
    remojansen unlabeled #20
  • May 27 2015 20:41
    remojansen labeled #20
  • May 27 2015 20:41
    remojansen assigned #15
  • May 27 2015 20:41
    remojansen unlabeled #15
  • May 27 2015 20:41
    remojansen labeled #15
  • May 27 2015 20:23
    remojansen unlabeled #3
Remo H. Jansen
@remojansen
I just did the first commit for the AtSpy website http://atspy.github.io/
Remo H. Jansen
@remojansen
I'm going to write a project overview page in the wiki really soon so you have a vision of what we need to implement
Meanwhile you can check the code and the issues at https://github.com/AtSpy/AtSpy/issues
Jakub Jedryszek
@jj09
cool
will take a look
Remo H. Jansen
@remojansen
if you have any questions please let me know
the build is almost working
but the task "bundle-test" is not working because we need to bundle each tests spec into an standalone JS file but browserify is expecting one unique entry point
Jakub Jedryszek
@jj09
Hi, I that originally you had to override class, and add @spy attributes on methods, and now you changed it in such a way so you add @Spy in production code.
This worries me a little, because I think production code should be not polluted by test code (and @Spy attributes are in this case treated as production code).
Remo H. Jansen
@remojansen
Hi Jackub sorry for the late reply
I was talking with @luisbelloch and we thought that it would be great if we could allow developers to use @apy without the need of overriding the existing classes because that would mean a lot of trivial and repetitive work
so we though that a plan B could be to create a Gulp taks
so the @spy annotations are removed before going to production
of course if u are not using gulp
u can still use the previous approach
what are your thoughts on that?
I just did a commit and the build is working but is not integrated with travis yet
if you checkout the code
run npm install & gulp
commands
Remo H. Jansen
@remojansen
that will run each task on the build and execute existing unit test (5 tests) in chrome and firefox
there is a problem with PhantonJS when I try to invoke "performance" (https://github.com/AtSpy/AtSpy/blob/master/source/call.ts#L18) it crashes even thought I'm testing for it to be available and using a fallback.
so in Karma.conf.js I have commented PhantonJS for now: https://github.com/AtSpy/AtSpy/blob/master/karma.conf.js#L7
The code at https://github.com/AtSpy/AtSpy/tree/master/source/interfaces has now a lot of comments
Jakub Jedryszek
@jj09
Wouldn't be better idea to create spy in the same way sinon is doing?
difference would be that this framework will enforce strong typing
Remo H. Jansen
@remojansen
I like the idea of using @spy instead of var var spy = sinon.spy(object, "method"); I don't know how others will feel about it. Maybe we can allow both styles?
Remo H. Jansen
@remojansen
I don't mind assing AtSpy.createSpy(func : Function) & AtSpy.createSpy(object : any, "method" : string)to https://github.com/AtSpy/AtSpy/blob/master/source/interfaces/atspy.d.ts in the future
adding*
Jakub Jedryszek
@jj09

Hi Remo,
I took a brief look at the code, and I have a few suggestions:

  1. rename 'source' to 'src', and put 'typings' directory inside 'src' dir.
  2. add examples (in examples directory) - e.g., move code examples from readme there
  3. add dev / user 'tutorials' to README (how to install with npm/bower, and how to use it - link to examples)

Let me know what do you think, and create (or I will) issues for them.

We probably shouldn't put much effort in website/docs now, but focus on code/tests/exmaples, right?

Remo H. Jansen
@remojansen
Hi I'm happy with those suggestions. I'm working on the spy class now. Matcher, TypeChecker and Call are implemented and tested.
I have also been thinking about allow to create spies without using decorators and I have figured out a way to do it without changing too much the existing code.
Documentation is not the priority as you said but I like to do it along the way. I get lazy if I have to spend a full week working on docs... :)