These are chat archives for AvaloniaUI/Avalonia

3rd
Aug 2015
danwalmsley
@danwalmsley
Aug 03 2015 09:49 UTC
@SuperJMN hey I've pulled in your OmniXamled branch
I've got a few undefined types
IXamlLoader and WindowResourceProvider
ahh it was a missing reference to Perspex.Xaml.Desktop
José Manuel Nieto
@SuperJMN
Aug 03 2015 10:55 UTC
Oh! so the code is broken?
Steven Kirk
@grokys
Aug 03 2015 11:54 UTC
@BSick7 nice article, but isn't a lot of that not needed now that VS2015 has node/bower/gulp/grunt integrated?
i.e. installing node
Brad Sickles
@BSick7
Aug 03 2015 11:59 UTC
sometimes visual studio can't do everything, it's good to know how to use the command line for that world
Steven Kirk
@grokys
Aug 03 2015 12:54 UTC
yeah, i just meant that you shouldn't need to install it separately any more, is that not right?
danwalmsley
@danwalmsley
Aug 03 2015 13:16 UTC
@SuperJMN I got it to compile now
just a missing reference in the test app
but I am having other issues
1 sec
when trying to parse PerspexWindow-Full.xaml(XamlTestApplication)
I was getting errors
so I thought id better clone latest OmniXaml instead of the nugget package
but there is missing ITypeFactory?
danwalmsley
@danwalmsley
Aug 03 2015 13:22 UTC
ok iv reset my repository
When parsing the file "Views\PerspexWindow-Full.xaml" I get Additional information: Requested value 'Centered' was not found.
caused by TextAlignment="Centered"
(Line 49)
If I remove those lines
I get
Object reference not set to an instance of an object.
in PerspexXamlMember.cs
its a call from OmniXaml during parsing....
but I'll need to consume OmniXaml via its source to see whats really happening...
Nelson Carrillo
@ncarrillo
Aug 03 2015 13:38 UTC
try changing it to Center
I believe the TextAlginment enum changed from Centered to Center to match WPF
and the XAML in the demo app may not have been updated to match
danwalmsley
@danwalmsley
Aug 03 2015 13:41 UTC
@ncarrillo ahhh that sorted that one!
thanks
Nelson Carrillo
@ncarrillo
Aug 03 2015 13:42 UTC
sure np!
danwalmsley
@danwalmsley
Aug 03 2015 13:57 UTC
@SuperJMN I tried <Button Grid.Column="1">Test</Button>
which didn't work
before I implemented the converters as WPF does
I wonder if OmniXaml looks for a converted and I just need to add them in, so that it can convert a string to a button for example?
*looks for a converter!
José Manuel Nieto
@SuperJMN
Aug 03 2015 14:34 UTC
hey, Dan, sorry for the delay
I'll take a look. Since I'm doing a lot of changes in the code, some of the files can have problems during the parsing
could you please try to load them using OmniXAML?
danwalmsley
@danwalmsley
Aug 03 2015 14:36 UTC
hey @SuperJMN no delay!
José Manuel Nieto
@SuperJMN
Aug 03 2015 14:36 UTC
I'm keeping XAMLed-Perspex is on hold a bit while I'm implementing new features in OmniXAML
danwalmsley
@danwalmsley
Aug 03 2015 14:36 UTC
I see
Was having a go at updating it to make the full Perspex demo parse and load again
I think I must have to add some attributes to some of the Perspex.Controls
José Manuel Nieto
@SuperJMN
Aug 03 2015 14:37 UTC
which ones?
and ContentPropertyAttribute
José Manuel Nieto
@SuperJMN
Aug 03 2015 14:38 UTC
ah, OK!
danwalmsley
@danwalmsley
Aug 03 2015 14:38 UTC
which I assume is the reason <Button> Text </Button> doesn't work
as there is no converter for string to textblock or something like that
José Manuel Nieto
@SuperJMN
Aug 03 2015 14:38 UTC
Aha! try for the moment with <Button Content="Text" />
danwalmsley
@danwalmsley
Aug 03 2015 14:38 UTC
that works fine
José Manuel Nieto
@SuperJMN
Aug 03 2015 14:38 UTC
it doesn't need the converter
danwalmsley
@danwalmsley
Aug 03 2015 14:39 UTC
I just thought id have a go a fixing that tiny problem
but ignore that for now
José Manuel Nieto
@SuperJMN
Aug 03 2015 14:39 UTC
haha, OK!
you know, if there is a problem with XAMLed-Perspex, don't worry
at least, while OmniXAML is stabilized!
danwalmsley
@danwalmsley
Aug 03 2015 14:40 UTC
ok cool
whats happening with that at the moment? anything I can look at?
something small!
to ease into it!
José Manuel Nieto
@SuperJMN
Aug 03 2015 14:40 UTC
Hahaha
something easy!? let me think
something about names
renaming!
danwalmsley
@danwalmsley
Aug 03 2015 14:41 UTC
ok what needs renaming?
José Manuel Nieto
@SuperJMN
Aug 03 2015 14:42 UTC
or even better
you can locate calls like this: ProtoXamlNodeAssert.AreEqualWithLooseXamlTypeComparison(expectedNodes, actualNodes);
and replace them with:
CollectionAssert.AreEqual(expectedNodes, actualNodes)
all tests should pass
also, it's necessary to remove the ProtoXamlNodeAssert class
it's an easy tast to do
I wanted to get rid of that!
danwalmsley
@danwalmsley
Aug 03 2015 14:43 UTC
the repo on GitHub yes?
José Manuel Nieto
@SuperJMN
Aug 03 2015 14:43 UTC
yes
the master branch, of course
Also, I would like to organize all the .xaml files in the test in a good way
danwalmsley
@danwalmsley
Aug 03 2015 14:45 UTC
just pulling in the latest!
ok
I will look at the ProtoXamlNodeAssert
José Manuel Nieto
@SuperJMN
Aug 03 2015 14:45 UTC
right now, they are being stored as .resx files with "shortcuts" to the real files
OK!
danwalmsley
@danwalmsley
Aug 03 2015 14:45 UTC
and then have a look at the xaml files.
José Manuel Nieto
@SuperJMN
Aug 03 2015 14:45 UTC
OK!
thank you!
danwalmsley
@danwalmsley
Aug 03 2015 14:46 UTC
hows married life?
José Manuel Nieto
@SuperJMN
Aug 03 2015 14:46 UTC
you're the first person that actually has taken some duty apart from me!
haha, it's great !
my wife is wonderful
danwalmsley
@danwalmsley
Aug 03 2015 14:46 UTC
ahhh nice!
good honey moon?
José Manuel Nieto
@SuperJMN
Aug 03 2015 14:46 UTC
haha
and she lets me code a lot
yes, Thailand is charming!
danwalmsley
@danwalmsley
Aug 03 2015 14:47 UTC
haha important
coding takes a lot of time!
whats Glass?
José Manuel Nieto
@SuperJMN
Aug 03 2015 14:50 UTC
Glass is a sidekick
it provides common functionalities like reflection and quite generic methods
like Guard.ThrowIfNull...
It's not directly related with XAML. It's about cross-cutting functionalies, if you will.
danwalmsley
@danwalmsley
Aug 03 2015 14:52 UTC
ok
I moved them over to CollectionAssert
but ExpandedStringPropertyTest Fails!
José Manuel Nieto
@SuperJMN
Aug 03 2015 14:59 UTC
Mmmm!
let me check!
in which file?
(there are more than one called the same name ExpandedStringProperty :))
ah! located!
checking now!
OK, that IS a bug!
put a [Ignore] attribute in that test
and a // TODO above it
just to indicate that it should be fixed
José Manuel Nieto
@SuperJMN
Aug 03 2015 15:06 UTC
arghh, that's why I wanted to remove that "loose" comparison. It's too permissive! and it hides bugs like this.
José Manuel Nieto
@SuperJMN
Aug 03 2015 15:13 UTC

caused by TextAlignment="Centered"

Hey, that's due a rename in Perspex :) the attribute should be "Center"

José Manuel Nieto
@SuperJMN
Aug 03 2015 15:30 UTC
Due to*