These are chat archives for AvaloniaUI/Avalonia

30th
Apr 2016
Steven Kirk
@grokys
Apr 30 2016 09:19
sorry i said visual when i meant logical earlier
Jeremy Koritzinsky
@jkoritzinsky
Apr 30 2016 20:06
I realized that.
Jeremy Koritzinsky
@jkoritzinsky
Apr 30 2016 20:40
I found a test case that breaks my band-aid fix, so we can't use that fix. The only way that I see to fix this up for good is to have a way to not have a DataTemplate match (or exclude it some other way) if a control is materialized from that specific DataTemplate. That way we can avoid having this problem appearing in any possible case. @grokys @danwalmsley what do you guys think of this fix? Should I work on implementing it?
Steven Kirk
@grokys
Apr 30 2016 20:41
sorry, i've still not had chance to look at it - hopefully later today...
things have been quite hectic the last week!
Jeremy Koritzinsky
@jkoritzinsky
Apr 30 2016 20:43
That's why I've kept investigating and trying to make good test cases so when we fix the bug we actually fix it. Btw the tests I've added are in this branch on my fork: https://github.com/jkoritzinsky/Perspex/tree/issue_510_524
Steven Kirk
@grokys
Apr 30 2016 20:52
thanks for all the work @jkoritzinsky ! i will hopefully have time to check it out this evening
Steven Kirk
@grokys
Apr 30 2016 23:47
@jkoritzinsky could you submit a PR from your branch with the tests?
Jeremy Koritzinsky
@jkoritzinsky
Apr 30 2016 23:47
Will do.
Tests are in #525