These are chat archives for AvaloniaUI/Avalonia

3rd
Aug 2016
Steven Kirk
@grokys
Aug 03 2016 06:24
@danwalmsley just writing the release notes for alpha 4. you implemented system dialogs right? was anyone else involved?
oh actually it looks like it was also @kekeks
Andrey Kunchev
@donandren
Aug 03 2016 06:57
@grokys about #643 I've added in the comment the solution that works for me
Steven Kirk
@grokys
Aug 03 2016 07:03
ah sorry, i missed that one!
not looked at that one yet but i don't think removing that line is the correct solution
Andrey Kunchev
@donandren
Aug 03 2016 07:03
that's why i've added it as a comment
i was also not sure
Steven Kirk
@grokys
Aug 03 2016 07:04
sure :)
Andrey Kunchev
@donandren
Aug 03 2016 07:04
but at least that's solving the issue
and can be a clue
another solution for #643 can be the check from previous measure to involve bit more checks
danwalmsley
@danwalmsley
Aug 03 2016 07:30
@grokys
I did a little on open file dialog
I added open folder dialog
danwalmsley
@danwalmsley
Aug 03 2016 10:20
@grokys iv realised what the weird issue is on the virtualized listbox
you don't recycle selected item
in some cases
I will try and get you a repro commit.
Jeremy Koritzinsky
@jkoritzinsky
Aug 03 2016 15:04
@wieslawsoltes Reviewed and merged!
Wiesław Šoltés
@wieslawsoltes
Aug 03 2016 18:39
@jkoritzinsky Thanks. Looks like there is issue with SkiaSharp, it can not decode github_icon.png in VisualBrushTests for Skia :(
Yeah look like its new Skia version issue
Wiesław Šoltés
@wieslawsoltes
Aug 03 2016 19:03
@jkoritzinsky I have submited PR with fix AvaloniaUI/Avalonia#649
Not sure if this was my fault or SkiaSharp, submited the issue to SkiaSharp mono/SkiaSharp#128
Wiesław Šoltés
@wieslawsoltes
Aug 03 2016 19:10
All tests are passing :)
Steven Kirk
@grokys
Aug 03 2016 19:10
even on travis? ;)
Wiesław Šoltés
@wieslawsoltes
Aug 03 2016 19:10
no, but that is not related to Skia
i mean failing tests on TravisCI
Steven Kirk
@grokys
Aug 03 2016 19:11
i know ;)
Wiesław Šoltés
@wieslawsoltes
Aug 03 2016 19:11
:)
Steven Kirk
@grokys
Aug 03 2016 19:11
maybe we shoudl remove the travis build hooks for now as they make every PR look like its failing
Wiesław Šoltés
@wieslawsoltes
Aug 03 2016 19:12
yeah, they even fail when they should pass
randomly
Steven Kirk
@grokys
Aug 03 2016 19:12
any idea why?
Wiesław Šoltés
@wieslawsoltes
Aug 03 2016 19:12
probably some issues with mono
this is good example
of random failures
when I restart the failing build it will for 99% pass :)
Steven Kirk
@grokys
Aug 03 2016 19:13
so mono just randomly hangs when running tests?
Wiesław Šoltés
@wieslawsoltes
Aug 03 2016 19:14
hangs or throws some exception
really hard to find a pattern here or debug
Steven Kirk
@grokys
Aug 03 2016 19:17
are we using unstable mono? that could be it if so
looks like latest stable
from 1st of August 2016
Steven Kirk
@grokys
Aug 03 2016 19:25
oh :(
aspnet/KestrelHttpServer#338
wonder if that's relevant?
Jeremy Koritzinsky
@jkoritzinsky
Aug 03 2016 19:28
I'll merge in #649
Wiesław Šoltés
@wieslawsoltes
Aug 03 2016 19:31
@grokys Not sure what they have done to fix the issues.
@jkoritzinsky Thanks!
aspnet/dnx#2964
After #2932 there are still timeouts on Travis, though a little less frequent. :)
Wiesław Šoltés
@wieslawsoltes
Aug 03 2016 20:05
cake-build/cake#366
maybe this would help xunit.console.exe -noappdomain
Steven Kirk
@grokys
Aug 03 2016 21:09
@wieslawsoltes well that seemed to help - there's just a single test failing now afaics
Wiesław Šoltés
@wieslawsoltes
Aug 03 2016 21:09
I hoped all would pass
but its step closer
Steven Kirk
@grokys
Aug 03 2016 21:12
yeah it's weird that one test failed
let me try re-running the build
its happened before
Darnell Williams
@Seeker1437
Aug 03 2016 21:13
I recommend using a stable mono build
Wiesław Šoltés
@wieslawsoltes
Aug 03 2016 21:13
We are using latest stable
Darnell Williams
@Seeker1437
Aug 03 2016 21:13
Hmm
Okay xD
A project I have tests against 3 versions of mono with travis
Wiesław Šoltés
@wieslawsoltes
Aug 03 2016 21:15
Jeremy Koritzinsky
@jkoritzinsky
Aug 03 2016 21:38
The test that's failing on Mac I'm pretty sure has failed every time.
Maybe WeakReference on Mono on Mac is broken?
Darnell Williams
@Seeker1437
Aug 03 2016 22:12
@jkoritzinsky what do you think of this?
Jeremy Koritzinsky
@jkoritzinsky
Aug 03 2016 22:41
Looks like that's whats causing the test failure
Looks like we'll have to do a little refactoring to account for the implementation detail.
Confused why it doesn't fail on Linux though