These are chat archives for AvaloniaUI/Avalonia

13th
Nov 2016
Wiesław Šoltés
@wieslawsoltes
Nov 13 2016 06:53

@wieslawsoltes hey man, I get the impression xamlbehaviors and core2d, is automatically re-building against the latest avalonia nugets whenever a new version is published
how did you achieve this?

@danwalmsley I update manually packages using VS :)

danwalmsley
@danwalmsley
Nov 13 2016 13:03
@grokys just added an extra unit test, around #799 ;) if you get chance to review let me know if anything else needs to be done, but checked with Avalon studio and it really solves my problems with memory leaks and logical tree stuff!
only 1 remaining leak problem with popup! see #804!
iv tried to step through an debug, but might need to get you to have a look with me to point me to the correct path :)
danwalmsley
@danwalmsley
Nov 13 2016 13:10
is this an intermittent error in leak tests?
Avalonia.LeakTests.MemberSelectorTests.Should_Not_Hold_Reference_To_Object [FAIL]

      DotMemoryUnitException : xUnit does not capture the standard output stream which is used by dotMemory Unit to report issues and save workspaces. Use JetBrains.dotMemoryUnit.DotMemoryUnitTestOutput.SetOutputMethod to link dotMemory Unit with xUnit ITestOutputHelper or suppress this exception by applying JetBrains.dotMemoryUnit.SuppressXUnitOutputExceptionAttribute to the assembly.
danwalmsley
@danwalmsley
Nov 13 2016 14:18
test passes locally on my machine, but throwing exception in appveyor, anyone seen this before?
Nihal Talur
@0xFireball
Nov 13 2016 19:25

The NuGet package for Avalonia on the MonoAndroid framework does not include Avalonia.DotNetFrameworkRuntime in the package.
This library is where AppBuilder is defined. As a result, I can't use AppBuilder in my code from the NuGet package without building Avalonia from source 🙁

I also noticed that the sample Android projects both reference the .csproj for DotNetFrameworkRuntime directly.

Thanks!

Steven Kirk
@grokys
Nov 13 2016 20:45
@0xFireball yeah sorry, iOS and Android are broken at the moment
danwalmsley
@danwalmsley
Nov 13 2016 20:57
@grokys did you get chsnce to review pr?
Steven Kirk
@grokys
Nov 13 2016 21:03
not yet
i've not been at home
danwalmsley
@danwalmsley
Nov 13 2016 21:03
no worries,
unit test is failing but seems to be a problem with dot memory running on appveyor
test passes on my machine locally, might just need another build triggering
Steven Kirk
@grokys
Nov 13 2016 22:18
looks like it's passing now
danwalmsley
@danwalmsley
Nov 13 2016 22:18
nice
Steven Kirk
@grokys
Nov 13 2016 22:18
got a cold and feeling like crap, will try to review it tomorrow assuming i feel better
danwalmsley
@danwalmsley
Nov 13 2016 22:18
ok hope you feel better soon
Steven Kirk
@grokys
Nov 13 2016 22:19
thanks, me too! :_
danwalmsley
@danwalmsley
Nov 13 2016 22:19
I'm going to submit a PR to implement HideTaskBarWhenMaximized which is in Mahapps
means you can set window decorations to false
and not cover the taskbar
when maximized
Steven Kirk
@grokys
Nov 13 2016 22:20
ok great!
danwalmsley
@danwalmsley
Nov 13 2016 22:21
I have something working already, but probably could be start of monitor api ;)
danwalmsley
@danwalmsley
Nov 13 2016 23:35
#805 for when your feeling better ;)