These are chat archives for AvaloniaUI/Avalonia

14th
Nov 2016
Eric Winnington
@ewinnington
Nov 14 2016 12:49
Hey! With Visual Studio for Mac out in preview, how close is avalonia to shipping a "play around" project with a basic window running on .net core on the Mac? Or is it still on Mono?
Jeremy Koritzinsky
@jkoritzinsky
Nov 14 2016 14:40
Its still on Mono. I'm working on a Xamarin.Mac backend right now.
danwalmsley
@danwalmsley
Nov 14 2016 17:12
@grokys did you recover or are you struck down with the cold?
Steven Kirk
@grokys
Nov 14 2016 19:15
feeling a bit better thanks - got some stuff to do but will try to review your PR asap
Andrew
@zezba9000
Nov 14 2016 19:19
Switching to nightly builds isn't working: "https://www.myget.org/F/avalonia-ci/api/v2". I don't see any newer version in the drop down.
Wiesław Šoltés
@wieslawsoltes
Nov 14 2016 19:20
you need to toggle include prerelease
Steven Kirk
@grokys
Nov 14 2016 19:20
beat me to it :)
Andrew
@zezba9000
Nov 14 2016 19:23
Still same this
blob
Steven Kirk
@grokys
Nov 14 2016 19:23
you need to select the "package source" on the right
Andrew
@zezba9000
Nov 14 2016 19:23
O dur lol
Andrew
@zezba9000
Nov 14 2016 19:40
So Skia doesn't support AnyCPU?
danwalmsley
@danwalmsley
Nov 14 2016 19:50
@zezba9000 supposedly it can now
but I didn't manage to get it to work yet!
didn't have chance to investigate why yet
but maybe I misunderstood that
Andrew
@zezba9000
Nov 14 2016 19:53
@danwalmsley The lib is .NET so only requires AnyCPU but the native libs it depends on require your app to choose a bit
Thats what I get from their wording.
danwalmsley
@danwalmsley
Nov 14 2016 19:54
ah I see
I wish they had done, in anycpu use x86 version
Andrew
@zezba9000
Nov 14 2016 19:54
You can get AnyCPU to work if you manually copy the native stuff you need... very impractical. So just making a x64 and x86 builds make sense
danwalmsley
@danwalmsley
Nov 14 2016 19:54
and if you specifically build x86 or x64 use that
yeah much easier
I wonder if there is much advantage using 64bit version of libskia, would it be faster for example?
Andrew
@zezba9000
Nov 14 2016 19:55
If your app needs to be 64bit then yes you would need that
if you make a 3D modeling app that needs 64bit for example
danwalmsley
@danwalmsley
Nov 14 2016 19:56
ah right
Andrew
@zezba9000
Nov 14 2016 19:57
performance on AMDs goes faster if you use the bit of the CPU while Intel doesn't get as effected
from what Iv'e tested
Steven Kirk
@grokys
Nov 14 2016 22:06
@danwalmsley reviewing now. in your comment you say:
I'm wondering if because of this we should remove this line...
VitalElement/AvalonStudio@7b75d5a
is that the right link?
danwalmsley
@danwalmsley
Nov 14 2016 22:18
oh definitely not
damn clipboard!
i'll find the thing I was reffering to 2 secs
danwalmsley
@danwalmsley
Nov 14 2016 22:32
@grokys updated comment with (what I think is) the correct link
danwalmsley
@danwalmsley
Nov 14 2016 22:43
@grokys did you see my last comment on #799?
if you happy with that one (about adding to the list as we go along instead of addrange) then merge away ;)
Steven Kirk
@grokys
Nov 14 2016 22:44
yeah, i replied: "Yeah, I think the current behavior is correct."
oh... maybe i didn't see it
danwalmsley
@danwalmsley
Nov 14 2016 22:45
I think its right at the bottom (but hidden because its on an outdated commit)
Steven Kirk
@grokys
Nov 14 2016 22:45
no, i don't see anything about AddRange
ah yeah i see it
danwalmsley
@danwalmsley
Nov 14 2016 22:45
;)
am I supposed to do something to make the review go green?
Steven Kirk
@grokys
Nov 14 2016 22:46
no, AddRange just calls Add internally so you'd just be allocating a list for no reason
i've approved the review
danwalmsley
@danwalmsley
Nov 14 2016 22:46
ok cool, so perhaps that suggest make the same change in dematerialized?
Steven Kirk
@grokys
Nov 14 2016 22:49
oh yeah... hmm didn't notice that it created a list before
maybe there was a reason?
might be best to change it to use a list then
danwalmsley
@danwalmsley
Nov 14 2016 22:49
at some point in the development, it was
because it meant the control would be detached before you did some other operation...
but I think the logic of it is now ok...
This message was deleted
I will see if unit tests pass
@grokys did you have change to glance at #805? I was interested in your thoughts on if it should be unit tested, (it only affects the win32 backend) not sure how to unit test that.
Steven Kirk
@grokys
Nov 14 2016 23:01
yeah, we can't really test that sort of thing
danwalmsley
@danwalmsley
Nov 14 2016 23:02
ok thought so, shame it makes the code cov go down like 0.06%
:(
interested if you thought the property IgnoreTaskBarOnMaximize was fine? I made it same as what mahapps have done.
damn leak test failed again, is it just a case of triggering build again?
Steven Kirk
@grokys
Nov 14 2016 23:06
yeah i think so
not sure why it's started happening
danwalmsley
@danwalmsley
Nov 14 2016 23:06
I don't think I have access to trigger it?
Steven Kirk
@grokys
Nov 14 2016 23:06
oh really? you should
danwalmsley
@danwalmsley
Nov 14 2016 23:07
maybe I'm not looking in the right place though
perhaps license for dotmemory ran out?
no I don't have access
Steven Kirk
@grokys
Nov 14 2016 23:13
restarted the build
danwalmsley
@danwalmsley
Nov 14 2016 23:13
thanks
have to go, but thanks for helping me get that PR finished! :)
speak soon
Steven Kirk
@grokys
Nov 14 2016 23:16
later!
have to go too
danwalmsley
@danwalmsley
Nov 14 2016 23:16
ok
if it passes, in the morning am I ok to press the green merge button?
Steven Kirk
@grokys
Nov 14 2016 23:20
sure!