These are chat archives for AvaloniaUI/Avalonia

15th
Apr 2017
Steven Kirk
@grokys
Apr 15 2017 09:00
@danwalmsley @aelij the changes to FormattedText in #948 are probably going to affect you
danwalmsley
@danwalmsley
Apr 15 2017 10:52
@grokys will the formattedtext be gc'ed when renderer is done with it?
Or will that come later?
If I don't manually dispose of formatted text in my current code i end up with pretty huge memory leak
Steven Kirk
@grokys
Apr 15 2017 11:59
yeah it will be GC'd
danwalmsley
@danwalmsley
Apr 15 2017 12:06
we ready to merge?
or do we need more :eyes: on it?
Steven Kirk
@grokys
Apr 15 2017 12:36
i just pushed another small commit, can merge after CI runs if you're happy with it
Steven Kirk
@grokys
Apr 15 2017 13:54
ok, merged it
danwalmsley
@danwalmsley
Apr 15 2017 15:02
@grokys looks good seems to work without modification on Avalon studio
iv noticed popups have broken,
you just get black window on the first render pass
Steven Kirk
@grokys
Apr 15 2017 15:03
oh, nice
danwalmsley
@danwalmsley
Apr 15 2017 15:03
then if you trigger a change
it renders
Steven Kirk
@grokys
Apr 15 2017 15:03
ok, 'll take a look at popups
danwalmsley
@danwalmsley
Apr 15 2017 15:03
how much of the new rendering system is merged now?
well 1 of my popups is affected
menus seem to be ok, but perhaps somehow they trigger double render pass when they open
Steven Kirk
@grokys
Apr 15 2017 15:05
there's still a fair bit to merge
i've been moving house which together with VS2017 being so slow has put a halt to things a bit. good news is that the house-moving is now finished.
danwalmsley
@danwalmsley
Apr 15 2017 15:06
awesome!
still in Italy I take it?
Steven Kirk
@grokys
Apr 15 2017 15:08
yeah, bought a house, but had builders renovating it for 3 months, which took up a lot of my spare time!
danwalmsley
@danwalmsley
Apr 15 2017 15:08
sounds pretty good!
are houses a lot cheaper over there?
Steven Kirk
@grokys
Apr 15 2017 15:09
ha well depends where you live in th UK. a lot cheaper than london for sure ;)
Steven Kirk
@grokys
Apr 15 2017 15:45
@danwalmsley not able to reproduce dialogs not rendering on master
danwalmsley
@danwalmsley
Apr 15 2017 15:46
hmmm, its on avalon studios intellisense popup
i wonder if it could be to do with re-using same popup
anyway i'll have a look further into it later
Steven Kirk
@grokys
Apr 15 2017 15:49
ok, i don't think anything in the recently merged PRs would have changed popup rendering
might be worth going back a version and seeing if it still occurs
Steven Kirk
@grokys
Apr 15 2017 18:41
actually - thinking about it, appveyor is broken. our nightly nugets won't be getting uploaded i don't think