These are chat archives for AvaloniaUI/Avalonia

22nd
Apr 2017
Eli Arbel
@aelij
Apr 22 2017 12:43
@danwalmsley Didn't have a chance to work on it this week. Hopefully will have more time next week. I'll push the code to a new repository today.
WDYT, should I call it AvaloniaEdit or Avalonia.AvalonEdit?
BTW, I added support for routed commands, since AvalonEdit relied on them quite a bit. Was there a reason for not including them in Avalonia?
Darnell Williams
@Seeker1437
Apr 22 2017 12:48
If you go with the later reverse the name
AvalonEdit.Avalonia maybe?
Or just Avalonia.Edit
Eli Arbel
@aelij
Apr 22 2017 12:50
I'm leaning towards AvaloniaEdit
Darnell Williams
@Seeker1437
Apr 22 2017 12:50
I like it personally
I have working on Mabiavalon.DockNC for docking but I want rename it as well, once more of it works
Steven Kirk
@grokys
Apr 22 2017 13:41
AvaloniaEdit sounds good to me
danwalmsley
@danwalmsley
Apr 22 2017 16:15
@aelij nice one, il take a look, perhaps if I get time, can send you some PRs 😀
What's the difference between reactive command and routed command btw?
Jeremy Koritzinsky
@jkoritzinsky
Apr 22 2017 16:59
Routed Commands traverse the Logical Tree like events to find handlers. They're on our roadmap but they haven't been implemented yet.
danwalmsley
@danwalmsley
Apr 22 2017 17:08
What's the advantage of using them?
Eli Arbel
@aelij
Apr 22 2017 17:24
The command object itself is an identifier, for example, ApplicationCommands.Copy. When you click the button that fires a routed command, a routed event is bubbled from the currently focused element until it finds an element with a matching command binding. So essentially, you get context-aware command routing.
The same button with the same command can invoke Copy for any TextBox (or any control that wires up to that command).
danwalmsley
@danwalmsley
Apr 22 2017 17:49
@aelij first PR is there ;)
Eli Arbel
@aelij
Apr 22 2017 17:52
Cool :) Do you have an idea why the diff is weird? It looks like the entire file has been changed.
danwalmsley
@danwalmsley
Apr 22 2017 17:53
I think line endings, are you on mac or Linux?
i think we need a gitattributes file to stop it
i'll see if I can fix
btw where are key presses handled
I'm trying to fix delete key
backspace works but not delete key
@aelij can I set up codefactor and an appveyor / build script too?
so we can auto publish nugets
danwalmsley
@danwalmsley
Apr 22 2017 18:09
0
danwalmsley
@danwalmsley
Apr 22 2017 18:17
@aelij i found my previous failed attempt...
(Avalonia used to be called Perspex)
danwalmsley
@danwalmsley
Apr 22 2017 19:30
@/all any one seen this exception
image.png
all I did was take a brand new wpf app
and migrate to avalonia
Jeremy Koritzinsky
@jkoritzinsky
Apr 22 2017 19:32
Do you have the System.ValueTuple package installed?
danwalmsley
@danwalmsley
Apr 22 2017 19:34
maybe not
il try install it
is that now a dependency for avalonia
perhaps our nugets should be installing it for us
Jeremy Koritzinsky
@jkoritzinsky
Apr 22 2017 19:40
I don't think it is but I could be wrong
danwalmsley
@danwalmsley
Apr 22 2017 20:04
@aelij sent you another pr!