These are chat archives for AvaloniaUI/Avalonia

27th
Jun 2017
Mark Junker
@fubar-coder
Jun 27 2017 00:35
@grokys xunit supports async Task test functions.
Steven Kirk
@grokys
Jun 27 2017 07:07
yeah i've changed them to be async Task
danwalmsley
@danwalmsley
Jun 27 2017 12:12
@grokys what happened to MouseDevice.Instance?
@kekekeks perhaps you know
Steven Kirk
@grokys
Jun 27 2017 12:15
@danwalmsley it was moved to Window.MouseDevice: AvaloniaUI/Avalonia#1012
danwalmsley
@danwalmsley
Jun 27 2017 12:16
thanks
whats the correct way to get hold of it from inside a control?
before I could just do MouseDevice.Instance
var mouseDevice = (VisualRoot as IInputRoot)?.MouseDevice;
?
Steven Kirk
@grokys
Jun 27 2017 12:43
yeah that should do it
we might want a more elegant way of expressing that though
danwalmsley
@danwalmsley
Jun 27 2017 14:21
InputManager.MouseDevice.Instance?
InputManager.Keyboard.Instance?
Steven Kirk
@grokys
Jun 27 2017 14:29
how would they know what the input root is?
Nikita Tsukanov
@kekekeks
Jun 27 2017 14:33

we might want a more elegant way of expressing that though

Extension methods are widely used for such purposes

danwalmsley
@danwalmsley
Jun 27 2017 14:42

how would they know what the input root is?

how did MouseDevice.Instance know before?

there is only ever 1 mouse in a system I assume?
Matthijs ter Woord
@mterwoord
Jun 27 2017 14:42
in windows, you can attach multiple, but they all control the same cursor..
danwalmsley
@danwalmsley
Jun 27 2017 14:43
@kekekeks I opened #1039 regarding open folder dialog
would like to get that fixed once and for all
I don't understand why it was removed, I know the code wasn't elegant, but it was better than throw not implemented exception?
Steven Kirk
@grokys
Jun 27 2017 15:04
@danwalmsley there was previously only 1 mouse device, now there may be more
AvaloniaUI/Avalonia#1013 explains the reasoning:
different TopLevel controls in the same app can be backed by completely different internal implementation (e. g. control root embedded to WPF/GTK/Cocoa, remote visual, etc) with completely different needs and limitations
though i think tbh it'd be pretty unlikely that you'd be mixing those in the same app
Steven Kirk
@grokys
Jun 27 2017 16:12
@danwalmsley i think there was a problem with the open folder dialog in .NET core. it's still available if you use the .NET framework i think
danwalmsley
@danwalmsley
Jun 27 2017 16:39
i'll try and see if that can be fixed :)
Nikita Tsukanov
@kekekeks
Jun 27 2017 16:46

though i think tbh it'd be pretty unlikely that you'd be mixing those in the same app

A widget integrated in WPF wants to show a Popup

Now we have two toplevels with "completely different internal implementation"
Steven Kirk
@grokys
Jun 27 2017 16:59
yep, good point
Nikita Tsukanov
@kekekeks
Jun 27 2017 17:04
BTW, what are we doing with #1014 ?
Steven Kirk
@grokys
Jun 27 2017 17:19
it's still marked as WIP
so i was waiting for you to finish it off
once it's no longer WIP i can review
btw have you had chance to look at scenegraph?
Steven Kirk
@grokys
Jun 27 2017 19:29
wow vs2017.3 preview 3 is so much faster! no more hangs!
danwalmsley
@danwalmsley
Jun 27 2017 22:14
@grokys #1031 can I merge this?
I get that exception occasionally,
Steven Kirk
@grokys
Jun 27 2017 22:20
yep, just about to merge that myself ;)
there you go!
danwalmsley
@danwalmsley
Jun 27 2017 22:26
nice :)
i'll give scenegraph a spin first thing in the morning