These are chat archives for AvaloniaUI/Avalonia

5th
Aug 2017
Matthijs ter Woord
@mterwoord
Aug 05 2017 08:13
@grokys @danwalmsley was mening to use it for mvvm switching views, but doing that ina different way now. couldn't get the classes.add way working..
Steven Kirk
@grokys
Aug 05 2017 08:25
aaaaannnd - SCENEGRAPH IS MERGED!
@/all you may want to check what's broken on windows now that deferred rendering is enabled!
(it's currently only enabled for win32 - gtk still uses the immediate renderer for the moment)
Jeremy Koritzinsky
@jkoritzinsky
Aug 05 2017 08:31
Awesome!!
Wiesław Šoltés
@wieslawsoltes
Aug 05 2017 08:41
Nice!
Steven Kirk
@grokys
Aug 05 2017 08:47
except CI has failed...
danwalmsley
@danwalmsley
Aug 05 2017 09:06
@grokys how do we enable for gtk?
That was about 8months that pr
Steven Kirk
@grokys
Aug 05 2017 09:07
write more code!
it was more than 8 months i think
danwalmsley
@danwalmsley
Aug 05 2017 09:07
I thought it already did work on gtk?
Gtk3 with suis at least
Skia*
Steven Kirk
@grokys
Aug 05 2017 09:08
it was 9 months
Matthijs ter Woord
@mterwoord
Aug 05 2017 09:14
curious: what is the end effect of the deferred rendering? more perf?
Steven Kirk
@grokys
Aug 05 2017 09:14
arrgh why isn't CI working!?
Command executed with exception: The process cannot access the file 'C:\projects\Avalonia\tests\Avalonia.LeakTests\bin\Release\report.xml' because it is being used by another process.
@mterwoord yeah performance and the features listed in the PR: AvaloniaUI/Avalonia#827
Matthijs ter Woord
@mterwoord
Aug 05 2017 09:16
cool, great work!
Steven Kirk
@grokys
Aug 05 2017 09:16
(also i forgot to disable the debug overlay in controlcatalog like i said i would in the PR, d'oh)
Steven Kirk
@grokys
Aug 05 2017 09:35
@kekekeks any idea about the failure here: https://ci.appveyor.com/project/AvaloniaUI/Avalonia ? I notice you added some timeouts for dotMemoryUnit in AvaloniaUI/Avalonia@c4aae60. maybe those timeouts aren't working?
Nikita Tsukanov
@kekekeks
Aug 05 2017 09:44
dotmemoryunit is working in a really weird way
It won't stop until parent process is stopped
The problem itself is probably with report.xml being inaccessible
May be we need to add Thread.Sleep() there https://github.com/AvaloniaUI/Avalonia/blob/master/build.cake#L391
Matthijs ter Woord
@mterwoord
Aug 05 2017 09:47
dotmemory uses a profiler agent, so that kind of makes sense..
Nikita Tsukanov
@kekekeks
Aug 05 2017 09:49
Yep, but if you run it from cmd.exe
it never stops
Matthijs ter Woord
@mterwoord
Aug 05 2017 09:49
ouch
Nikita Tsukanov
@kekekeks
Aug 05 2017 09:49
You can either kill cmd.exe or dotmemoryunit
I have no idea why that's happening
But previous version was just crashing with 0xc0000005
Matthijs ter Woord
@mterwoord
Aug 05 2017 09:49
you reached out to etbrains?
Steven Kirk
@grokys
Aug 05 2017 09:51
did this start happening with latest version? could we go back to the previous version?
Nikita Tsukanov
@kekekeks
Aug 05 2017 09:51
But previous version was just crashing with 0xc0000005
Access Violation is even harder to work around, you know
BTW, their nuget package seems to be broken
They are shipping outdated version of Castle.Core
inside their package
which obviously conflicts with one referenced by Moq
Steven Kirk
@grokys
Aug 05 2017 09:56
but haven't we been running the leak tests for a long time without problems?
Nikita Tsukanov
@kekekeks
Aug 05 2017 09:56
It started crashing after some changes
crash issue was resolved by updating dotmemoryunit
But dotmemoryunit started to freeze after running tests
Steven Kirk
@grokys
Aug 05 2017 09:57
grr
Nikita Tsukanov
@kekekeks
Aug 05 2017 09:57
So the solution was to save report to a file
and kill dotmemoryunit when file becomes available
Steven Kirk
@grokys
Aug 05 2017 09:57
might be best to just disable leak tests for the moment and report a bug to JB
Johan Larsson
@JohanLarsson
Aug 05 2017 10:01
Assembly redirect should handle it I think.
Nikita Tsukanov
@kekekeks
Aug 05 2017 10:02
I've solved that by a separate dummy project
That has dotmemoryunit as a dependency
so it properly gets copied to it's bin
Steven Kirk
@grokys
Aug 05 2017 10:28
what do you think we should do for the moment? i'd really like to get a build out there with the deferred renderer
Nikita Tsukanov
@kekekeks
Aug 05 2017 10:49
I'm currently not nearby my pc and probably won't be today
So either try to add thread.sleep or just disable leak tests
Steven Kirk
@grokys
Aug 05 2017 10:57
ok, will do, thanks!
Steven Kirk
@grokys
Aug 05 2017 11:19
@wieslawsoltes @danwalmsley i think this might be useful to you guys if you want to review: AvaloniaUI/Avalonia#1085
Wiesław Šoltés
@wieslawsoltes
Aug 05 2017 12:21
@grokys Tested latest master with scengraph merged
There are rendering artifacts when using render transform scaling
translation works but scale produces visible artifacts
Steven Kirk
@grokys
Aug 05 2017 12:23
ah yes i see, hmm
Wiesław Šoltés
@wieslawsoltes
Aug 05 2017 12:23
oh and and previous issue with not visible text during zoom is gone
Steven Kirk
@grokys
Aug 05 2017 12:23
i think i might have an idea of what that is actually
that's good!
if you do .UseWin32(deferredRendering: false) does the previous issue come back?
Wiesław Šoltés
@wieslawsoltes
Aug 05 2017 12:25
yes still there :worried:
Steven Kirk
@grokys
Aug 05 2017 12:25
ok
Wiesław Šoltés
@wieslawsoltes
Aug 05 2017 12:36
@grokys tested also with Core2D
Steven Kirk
@grokys
Aug 05 2017 12:56
oh, ok :) psychedelic
i'll take a look into those problems later
Wiesław Šoltés
@wieslawsoltes
Aug 05 2017 13:23
Yeah
Other than this I did not notice any other issues
Steven Kirk
@grokys
Aug 05 2017 13:33
well that's a good start! i'd not tested scale transforms - only rotation!
Nelson Carrillo
@nc4rrillo
Aug 05 2017 18:23
GRATS on merging scenegraph 🎉🎊