These are chat archives for AvaloniaUI/Avalonia

21st
Aug 2017
Wiesław Šoltés
@wieslawsoltes
Aug 21 2017 05:10
:+1:
Matthijs ter Woord
@mterwoord
Aug 21 2017 06:12
@grokys All merged into #1111 now, including a short explanation
let me know if i'm missing something.,
Matthijs ter Woord
@mterwoord
Aug 21 2017 11:44
better now?
@grokys but that would mean that i couldput my styles in Resources as well?
Steven Kirk
@grokys
Aug 21 2017 11:45
yes, better now, thanks! :)
Matthijs ter Woord
@mterwoord
Aug 21 2017 11:46
explanation makes sense now
?
Steven Kirk
@grokys
Aug 21 2017 11:46
i don't think styles in resources would work so well as styles depend on the order, and ResourceDictionarys are unordered
yes explanation makes sense ;) i mean it was pretty obvious, but it's always best to give a description
Matthijs ter Woord
@mterwoord
Aug 21 2017 11:47
ok, i thought "give the project the sharedassemblyinfo" means it doesn't currently. makes sense though
is current master fully on the new xaml loader?
Steven Kirk
@grokys
Aug 21 2017 11:47
portable.xaml? yes
Matthijs ter Woord
@mterwoord
Aug 21 2017 11:48
i thought i saw onixaml in stack traces
Matthijs ter Woord
@mterwoord
Aug 21 2017 11:57
might also ahve been my hacking. will investigate further
already saw that error handlign improved a lot., which is aways good :)
danwalmsley
@danwalmsley
Aug 21 2017 12:35
@grokys @kekekeks @wieslawsoltes iv found issue #1121 and provided a fix, #1122 would be grateful if someone could have a quick review and merge if happy?
Nikita Tsukanov
@kekekeks
Aug 21 2017 14:47
@danwalmsley Add a test or something
danwalmsley
@danwalmsley
Aug 21 2017 15:09
ok sure
are there any existing tests just for the parser?
I saw some for paths and stuff
wasn't sure exactly where this fits in
is this a Markup test? or Media test?
are you sure that AvaloniaUI/Avalonia@42115b6 didn't fix the same thing?
danwalmsley
@danwalmsley
Aug 21 2017 15:22
@grokys cheers, no this is a different fix
for Bezier curve command
Steven Kirk
@grokys
Aug 21 2017 15:24
ah ok
danwalmsley
@danwalmsley
Aug 21 2017 15:24
just adding some tests
Steven Kirk
@grokys
Aug 21 2017 15:24
if you could commit the failing test first and then the fix that would be great
danwalmsley
@danwalmsley
Aug 21 2017 15:24
ok
so I'll revert the fix
then add the failing test
Steven Kirk
@grokys
Aug 21 2017 15:24
easier to test that way - though i know it will require some git acrobatics ;)
danwalmsley
@danwalmsley
Aug 21 2017 15:24
then add the fix again
no problem
Steven Kirk
@grokys
Aug 21 2017 15:25
haha yeah
danwalmsley
@danwalmsley
Aug 21 2017 15:25
is it worth me adding a test for the fix you referenced for arc?
Steven Kirk
@grokys
Aug 21 2017 15:26
there's already a test in that commit - isn't that testing the right thing?
danwalmsley
@danwalmsley
Aug 21 2017 15:26
I thought it might be nice to have an explicit test like
 public void Parses_Arc()
Steven Kirk
@grokys
Aug 21 2017 15:27
yeah sure!
danwalmsley
@danwalmsley
Aug 21 2017 15:28
mainly because a lot of the inline data is a bit cryptic!
danwalmsley
@danwalmsley
Aug 21 2017 15:35
ok that was proving to be a pain!
I just get "No tests found" when I try to debug the tests!
you had that before?
danwalmsley
@danwalmsley
Aug 21 2017 15:44
ok done
shows failing test
will show it passing (hopefully)
Matthijs ter Woord
@mterwoord
Aug 21 2017 16:24
@grokys What was the general idea regarding error messages? More descriptive?
Right now, I have a situation where the rendering system isn't recognized (that's a bug in my project files somewhere), but i got an error on a .First() call. I'm preparing a changeset with better errors for such situations. is that acceptable?
danwalmsley
@danwalmsley
Aug 21 2017 18:20
@kekekeks pr now has a teat and os ready for merge
danwalmsley
@danwalmsley
Aug 21 2017 20:01
haha test, should have been test!
Steven Kirk
@grokys
Aug 21 2017 21:38
don't give the PR a teat! you'll give us all nightmares
@mterwoord yeah sure that's acceptable, we can talk about how it works/the wording in the PR if you like