These are chat archives for AvaloniaUI/Avalonia

23rd
Oct 2017
Steven Kirk
@grokys
Oct 23 2017 08:57
because OnX() event method usually have EventArgs. you've found a bug there though in that e should be passed to the event
danwalmsley
@danwalmsley
Oct 23 2017 08:57
ah ok
danwalmsley
@danwalmsley
Oct 23 2017 09:19
btw @grokys @kekekeks latest code wont load Avalon studio, it crashes in portable.xaml
when it tries to load first data template
because property Type on XamlReader is null
image.png
Nikita Tsukanov
@kekekeks
Oct 23 2017 09:26
Check if every assembly is loaded beforehand
There were changes in initialization code
That's one of the reasons why we need #1242
danwalmsley
@danwalmsley
Oct 23 2017 09:28
do you have time to come on teamviewer and have a look?
it seems to be loading stuff from main assembly
danwalmsley
@danwalmsley
Oct 23 2017 09:37
I cant see any commits that change the initialization since last working version
I'm talking about this change
danwalmsley
@danwalmsley
Oct 23 2017 09:42
ok just testing exact build
danwalmsley
@danwalmsley
Oct 23 2017 09:47
seems to have worked since then
Nikita Tsukanov
@kekekeks
Oct 23 2017 09:55
Mkay, could you find a revision that breaks things?
danwalmsley
@danwalmsley
Oct 23 2017 09:55
just doing a binary search now
Nikita Tsukanov
@kekekeks
Oct 23 2017 09:55
I wish there was git bisect for nuget
danwalmsley
@danwalmsley
Oct 23 2017 09:56
up to build 4124 all working fine
Nikita Tsukanov
@kekekeks
Oct 23 2017 09:58
AvaloniaUI/Avalonia@ebb83a4
Might be that change
You need to use x:Static and x:Type now
danwalmsley
@danwalmsley
Oct 23 2017 09:59
ok 4131 worked
next build was 4135 and that doesn't work
yep
that was it
cheers
only 1 place I was using it
Steven Kirk
@grokys
Oct 23 2017 11:31
it's weird that you're not getting errors saying what's wrong
you mentioned they were being swallowed before, any idea what is doing that?
danwalmsley
@danwalmsley
Oct 23 2017 12:24
x:Statuc and x:Type was completely crashing
but didn't have any error message saying what line it was on or which file it was parsing
it was literally a null reference exception in portable.xaml
might have to send them an issue
no idea what was handling the exceptions
but its fairly easy to test, just miss spell any property
or type
Nikita Tsukanov
@kekekeks
Oct 23 2017 13:40
@grokys what are we using System.Reactive for?
Bindings?
It's quite a huge library
1MB+
Nikita Tsukanov
@kekekeks
Oct 23 2017 13:46
Our own dll combined are less than 1.5MB
Steven Kirk
@grokys
Oct 23 2017 13:47
we use it for pretty much everything
Nikita Tsukanov
@kekekeks
Oct 23 2017 13:48
ah, ok
Steven Kirk
@grokys
Oct 23 2017 13:48
but yeah our bind system is pretty much based on rx
Nikita Tsukanov
@kekekeks
Oct 23 2017 13:48
Well, let's allow the linker to do its job then
Mkay, can we remove Splat and Sprache from dependency list?
I don't think we are using them anymore
Jeremy Koritzinsky
@jkoritzinsky
Oct 23 2017 13:59
I think Splat is only used by HtmlRenderer. I think we’re still using Sprache though.
Nikita Tsukanov
@kekekeks
Oct 23 2017 14:00
Why are we doing that? It's terribly inefficient
I think it was the main reason why OmniXAML was so slow
Steven Kirk
@grokys
Oct 23 2017 14:01
i don't think omnixaml was slow because of sprache
Nikita Tsukanov
@kekekeks
Oct 23 2017 14:03
So, selectors are the only thing that we are using it for, right?
Steven Kirk
@grokys
Oct 23 2017 14:05
yeah, looks like it
i think splat is only now used in LogManager which is actually no longer used or needed
in fact i can't even remember what that class was for
Steven Kirk
@grokys
Oct 23 2017 14:10
it can be deleted
Nikita Tsukanov
@kekekeks
Oct 23 2017 14:14
Can we have serilog support in a separate package?
I think it's in a separate dll already
Steven Kirk
@grokys
Oct 23 2017 14:15
yeah we can
rconde01
@rconde01
Oct 23 2017 14:53
checking out from github master, i'm getting a number a build errors...any guidance?
Nikita Tsukanov
@kekekeks
Oct 23 2017 14:53
install latest everything
VS, .NET Core SDK
rconde01
@rconde01
Oct 23 2017 14:53
using vs2017
ok - i'll get the core sdk
Jeremy Koritzinsky
@jkoritzinsky
Oct 23 2017 14:55
Make sure you run git submodule update --init in the repo
rconde01
@rconde01
Oct 23 2017 14:56
on another topic...i'm curious about the non-technical motivations for avalonia...it's free/OS, so long term are you working on it as something you think is cool, or do you have a strategy for sustained development and support
Nikita Tsukanov
@kekekeks
Oct 23 2017 15:00
For now it's a bunch of people working on the project in their free time
At some point we might want to offer some kind of commercial support, I guess, but no actual plans that I know of yet
@grokys
Steven Kirk
@grokys
Oct 23 2017 15:03
yeah, for me it was just something i started because i thought it might be fun
ofc if at some point people wanted to pay me for it, that might be an option!
but at the moment i have a job that i'm not really looking to move on from!
so i just work on it on my free time (which I have slightly less of than i used to, but other people like @kekekeks and @jkoritzinsky have more than taken up the slack!)
rconde01
@rconde01
Oct 23 2017 15:05
asking from a risk perspective of using avalonia for commercial projects...Its maybe harder to justify using a solution like avalonia if you're worried that developers would just get bored of it...not a judgement or anything, just an observation...I think avalonia could be a great solution for what I need, but support is a consideration i need to make
Steven Kirk
@grokys
Oct 23 2017 15:06
yeah of course, i understand that completely
also it's still very early days
there was this issue which may interest you: AvaloniaUI/Avalonia#1151
rconde01
@rconde01
Oct 23 2017 15:32
yeah - i had read that...i'm a little more conservative on the hyperbole that you could be "sitting on a gold mine", but i think if you could manage to do something "more official" either yourselves or through a partnership, then you lower the barrier to choosing avalonia
of course similar arguments could be made for any library, but I feel like the stakes are a bit higher for a ui framework
anyhow - thanks for responses
Nikita Tsukanov
@kekekeks
Oct 23 2017 15:44
The problem is that we can't exactly offer commercial support for the library in its current state
May be in a year or two...
rconde01
@rconde01
Oct 23 2017 15:46
sure
sdoroff
@sdoroff
Oct 23 2017 15:56
This may be a stupid question
Within a unit test, how do I ensure that AvaloniaLocator.Current.GetService<IPlatformRenderInterface>() (called with the PolylineGeometry constructor) returns a valid instance?
I'm attempting to add unit tests for Shape measurement, which requires the internal geometry to calculate its bounds, to AvaloniaUI/Avalonia#1230
Nikita Tsukanov
@kekekeks
Oct 23 2017 15:58
You need to either mock it or move your test to RenderTests
rconde01
@rconde01
Oct 23 2017 15:58
fyi - updating to the lastest vs2017 update fixed the build
sdoroff
@sdoroff
Oct 23 2017 16:09
Thank you. I'll move the tests into RenderTests
Nikita Tsukanov
@kekekeks
Oct 23 2017 17:04
Meanwhile 5K commits
Jeremy Koritzinsky
@jkoritzinsky
Oct 23 2017 17:05
@grokys @kekekeks Do we have anyone currently supporting the HtmlRenderer assembly? Are we even sure it still works?
Nikita Tsukanov
@kekekeks
Oct 23 2017 17:07
We should move it to a separate repo, I think
It was added back in the Fall of 2015
And nobody have touched it ever since
its control catalog page was also removed
Jeremy Koritzinsky
@jkoritzinsky
Oct 23 2017 17:22
Yeah we should separate it out to its own repo at this point.
sdoroff
@sdoroff
Oct 23 2017 18:59
alt
Sorry, trying to figure out how to post an image from dropbox
sdoroff
@sdoroff
Oct 23 2017 19:10
CalendarSample-Small.png
The calendar control stuff is coming along nicely
Nikita Tsukanov
@kekekeks
Oct 23 2017 19:21
:+1:
Nikita Tsukanov
@kekekeks
Oct 23 2017 21:16
@grokys @jkoritzinsky AppVeyor's VMs have 2 virtual CPUs
We could speed up our build by running things in parallel
Code analysis, for example