These are chat archives for AvaloniaUI/Avalonia

4th
Dec 2017
Matthijs ter Woord
@mterwoord
Dec 04 2017 08:22
Why is avalonia wrapping gtk itself? and not using (for example) the gtksharp ones?
Nikita Tsukanov
@kekekeks
Dec 04 2017 08:26
I haven't found any proper bindings for GTK3 that work with .NET Core and don't need a ton of additional native binaries
Matthijs ter Woord
@mterwoord
Dec 04 2017 08:29
ok.
Jeremy Koritzinsky
@jkoritzinsky
Dec 04 2017 18:26
@grokys can you review #856 when you have a chance?
Steven Kirk
@grokys
Dec 04 2017 18:27
ah yes, sorry! because it's marked as being from @donandren i keep missing it!
i was actually looking for the PR the other day to finish reviewing but i was looking for your name as the author
Jeremy Koritzinsky
@jkoritzinsky
Dec 04 2017 18:29
Yeah I kinda just took over his PR since the unit tests were in there. Sorry about that!
Steven Kirk
@grokys
Dec 04 2017 18:32
no problem sorry for not reviewing, will do it this evening if possible (I think I should have time)
Jeremy Koritzinsky
@jkoritzinsky
Dec 04 2017 18:35
:+1:
MonkAlex
@MonkAlex
Dec 04 2017 19:24
https://pastebin.com/sS9FnATx - any idea, what that?
Nikita Tsukanov
@kekekeks
Dec 04 2017 19:25
Seems to be a malformed style
In the global scope
в Avalonia.Markup.Xaml.Styling.StyleInclude.get_Loaded()
MonkAlex
@MonkAlex
Dec 04 2017 19:26
https://pastebin.com/b3nV0GF0 - single local style
ahopper
@ahopper
Dec 04 2017 19:26
Just wondered if anyone had looked at my vs extension PR AvaloniaUI/AvaloniaVS#53 ,without it my project crashes vs
MonkAlex
@MonkAlex
Dec 04 2017 19:34
@kekekeks style work on 0.5.2-build4115-alpha, not work on current 0.5.2-build4305-alpha
Nikita Tsukanov
@kekekeks
Dec 04 2017 19:34
I think we've updated Portable.Xaml since then
MonkAlex
@MonkAlex
Dec 04 2017 19:37
Hm, StyleResource removed from current master branch
Copy-paste style from master help me
ahopper
@ahopper
Dec 04 2017 19:38
@kekekeks cheers
Nikita Tsukanov
@kekekeks
Dec 04 2017 19:40
@MonkAlex Oh, we've switched to StaticResource and DynamicResource
MonkAlex
@MonkAlex
Dec 04 2017 20:00
So, have exception on simple datatemplate:
<ListBox.ItemTemplate>
<DataTemplate>
<Grid RowDefinitions="*,Auto" Margin="10" Width="150" Height="300">
<Image Grid.Row="0" Source="{Binding Cover, Converter={Static av:BitmapTypeConverter.Instance}}"/>
<TextBlock Grid.Row="1" Text="{Binding Name}" TextWrapping="Wrap" ToolTip.Tip="{Binding Name}" HorizontalAlignment="Center"/>
</Grid>
</DataTemplate>
</ListBox.ItemTemplate>
Nikita Tsukanov
@kekekeks
Dec 04 2017 20:04
It's x:Static now, I think
MonkAlex
@MonkAlex
Dec 04 2017 20:07
Its work, thanks
Steven Kirk
@grokys
Dec 04 2017 22:49
@jkoritzinsky taking a look at #856 now. I'm a bit worried about the perf implications of this, especially the number of allocations that i think it will cause. going to add some benchmarks to check.
Jeremy Koritzinsky
@jkoritzinsky
Dec 04 2017 23:36
Yeah I didn’t do perf benchmarks with it. There’s a few perf optimizations I can do if needed.
Steven Kirk
@grokys
Dec 04 2017 23:53
doesn't look that bad tbh. well, it does look pretty bad allocations-wise but it also does on master ;)
i'm going to add a comment with my findings and some suggestions
i've pushed a couple of benchmarks i used to the branch