These are chat archives for AvaloniaUI/Avalonia

29th
May 2018
Wiesław Šoltés
@wieslawsoltes
May 29 2018 01:52
Latest NuGet from myget is broken
Przechwytywanie.PNG
Jumar Macato
@jmacato
May 29 2018 02:12
Jumar Macato
@jmacato
May 29 2018 02:33
@wieslawsoltes wow 🎉🎉
Jeremy Koritzinsky
@jkoritzinsky
May 29 2018 03:13
Sorry that's on me. I misremembered exactly how Zip worked.
I'll put out a PR in 5 minutes to fix that.
Jeremy Koritzinsky
@jkoritzinsky
May 29 2018 03:18
@wieslawsoltes can you take a look at #1626 when it's done building and approve it if the package in the CI artifacts has all the files?
I'd like to get it merged in to fix package generation as soon as possible.
Jumar Macato
@jmacato
May 29 2018 03:38
@jkoritzinsky looks good on my end
Jeremy Koritzinsky
@jkoritzinsky
May 29 2018 03:39
:+1:
Jumar Macato
@jmacato
May 29 2018 03:39
It's just awesome that i can use Setters on animations now
Rayyan Tahir
@RayyanTahir
May 29 2018 08:43
I'm having trouble showing a checkmark in my custom styled CheckBox when it is in :checked state. Repro is below:
danwalmsley
@danwalmsley
May 29 2018 09:37
@Gillibald did you mention there was a fix for skia fonts on Linux?
Benedikt Schroeder
@Gillibald
May 29 2018 09:42
Yes. We need a new native package for skia to fix the problem. v 1.58 or above is needed. Current version should be 1.60
We currently use v 1.57.1
this brings in the new skiasharp
which Im testing now if its fixed
we really need AvaloniaUI/Avalonia#1586 merging though to use it
Benedikt Schroeder
@Gillibald
May 29 2018 09:50
We could update skia in a separate PR without merging the gpu stuff.
danwalmsley
@danwalmsley
May 29 2018 09:52
yeah there are a few fixes in there that are required
I know of 2 at least
not sure about the rest
let me just confirm updating actually resolves it
danwalmsley
@danwalmsley
May 29 2018 10:00
yeah it fixes it
i'll do a pr
Benedikt Schroeder
@Gillibald
May 29 2018 10:01
That's good news
danwalmsley
@danwalmsley
May 29 2018 10:20
@Gillibald could you take a quick look here:
AvaloniaUI/Avalonia#1627
its obviously intended to be superceeded by the skia upgrade from #1586 but this gets us around the issues required to upgrade before then
@grokys would be ok merging the fixes here that allow update of skia, its minor changes, and just a stop gap until #1586 is finalized
Benedikt Schroeder
@Gillibald
May 29 2018 10:24
What are the changes that are not related to the package upgrade? Are they fixing anything that isn't working properly?
danwalmsley
@danwalmsley
May 29 2018 10:24
well the api of skia has changed
so the formatted text impl, fixes the text breaking at the wrong place
the other is because there isnt a LockPixels method anymore
you have to remove that or it wont compile
Benedikt Schroeder
@Gillibald
May 29 2018 10:25
I see
danwalmsley
@danwalmsley
May 29 2018 10:26
the commented copypixels I didnt know what to do there
maybe @MarchingCube will know?
it would have meant bringing a lot more of the PR over
Steven Kirk
@grokys
May 29 2018 10:26
@danwalmsley i'm really not qualified to review that PR i'm afraid
danwalmsley
@danwalmsley
May 29 2018 10:27
@grokys no problem
Steven Kirk
@grokys
May 29 2018 10:27
CI is failing anyway
danwalmsley
@danwalmsley
May 29 2018 10:27
yeah just realised that
probably better to get #1586 finished off first
I can just use custom builds for now
BK201
@circler3
May 29 2018 14:59
Hi, I found the website quickstart link returns a 404 error, http://avaloniaui.net/guides/quickstart.html.
Wiesław Šoltés
@wieslawsoltes
May 29 2018 16:14
More progress with docking control today https://youtu.be/yXU13RFX31g
Jeremy Koritzinsky
@jkoritzinsky
May 29 2018 16:23
That looks awesome!
Nelson Carrillo
@nc4rrillo
May 29 2018 19:19
Can we split the EGL stuff in #1586 out from the Skia changes?
Steven Kirk
@grokys
May 29 2018 20:30
Yes i think we should
Steven Kirk
@grokys
May 29 2018 20:37
Any reason that stuff shouldn't be in the skis lib?
Skia
Autocorrect
Jeremy Koritzinsky
@jkoritzinsky
May 29 2018 20:42
I think the issue is that it would cause the Win32, Gtk3 and other windowing backends to have a hard dependency on Skia
Also OpenGL could be used by multiple rendering backends, so having it as a separate assembly/package might be a good idea
Nelson Carrillo
@nc4rrillo
May 29 2018 20:53
I have a modified fork of that PR which creates an Avalonia.OpenGL package
each Windowing backends implements it
so Windows will implement it twice, once for EGL and once for WGL
EGL being when it runs using ANGLE and WGL when it runs using full Desktop GL
then rendering backends reference Avalonia.OpenGL and use the locator to get an IGlContextBuilder which they use to create an IGlContext
I separated the GL Context itself from the setup step of finding a suitable configuration and allowed the caller to customize the request they make
so they can request a specific GL version, and also request Desktop GL and fallback to GLES if not found
this moves the EGL calls themselves into Win32, though that can probably be a shared project between the windowing systems (Since EGL is common) where WGL/GLX are platform specific I suppose
there's an additional bool on UseWin32 which specifies whether or not to use ANGLE (defaults to true)
Steven Kirk
@grokys
May 29 2018 21:05
ah ok, it has to be implemented by the windowing backend, got it. yeah it makes sense to be in a separate library then
@nc4rrillo could you submit a PR targeting the original PR so that @MarchingCube can review and merge it into his branch?
Nelson Carrillo
@nc4rrillo
May 29 2018 21:07
yes