These are chat archives for AvaloniaUI/Avalonia

18th
Jun 2018
Sergey
@PurpleGray
Jun 18 2018 10:59
Why does avalonia still using Splat package while System.Drawing is available in .net core 2.0?
But im using 0.6.1 ver, maybe in latest pre-releases it is not true
It causes reference error when you trying to use Color type, for example
Jumar Macato
@jmacato
Jun 18 2018 11:23
@Stratocast3r it's on ReactiveUI's end, not Avalonias's :)
sdoroff
@sdoroff
Jun 18 2018 17:32
@rconde01 - An alpha of a DataGrid will hopefully be coming around the end of this month
rconde01
@rconde01
Jun 18 2018 17:45
@sdoroff cool...as I said I both want to use a grid, but i was also looking to learn about how a more complex control works in a lookless model...still haven't figured that out but I need to spend some time looking at the port you're (I think?) working on
Steven Kirk
@grokys
Jun 18 2018 20:17
@nc4rrillo there doesn't seem to be any movement on the skia PRs. would you be interested in being in charge of getting them all merged?
i need to add some features to the skia backend for the TextBlock.Inlines feature I'm working on but don't want to change anything there while there is this large PR in waiting
Nelson Carrillo
@nc4rrillo
Jun 18 2018 21:27
@grokys Yes. I'd be happy to.
Steven Kirk
@grokys
Jun 18 2018 21:28
cool! how should we go about it?
Nelson Carrillo
@nc4rrillo
Jun 18 2018 21:29
I think the Skia fixes are a strict improvement over what we have now, more tests, etc. So they should go in as-is and we can bikeshed on the OpenGL stuff some more
so I think I need to cherry pick those changes
I'm going to try that now
Steven Kirk
@grokys
Jun 18 2018 21:29
ok, cool
the only thing is i didn't want the platform-specific stuff in AvaloniaUI/Avalonia#1586 to go in
Nelson Carrillo
@nc4rrillo
Jun 18 2018 21:30
Yeah, I think we can exclude the OpenGL stuff completely, the cleanups in the Skia backend are nice
Steven Kirk
@grokys
Jun 18 2018 21:30
ok great
if you could submit a PR with just those changes, lets get them merged
Nelson Carrillo
@nc4rrillo
Jun 18 2018 21:30
Okay cool let me work that out now
Nelson Carrillo
@nc4rrillo
Jun 18 2018 22:13
@grokys #1679 with just the Skia changes, hopefully it makes for an easier review
vaseer45
@vaseer45
Jun 18 2018 22:23
@here can anyone have a look at https://drive.google.com/file/d/1hvVJ864EPClUshw47DDA5LeF_e0YzNVl/view?usp=sharing and confirm if the problem is in my code for getting "this control already has a visual parent" when re-adding a control after previously removing? This only repros in the context of events triggered by a ListBox - right now, not sure if bad code, or avalonia bug
danwalmsley
@danwalmsley
Jun 18 2018 22:26
Im not at a PC so can't check but I think you have to detach it from. Visual tree before Re adding, by setting parent to null?
I'm just thinking from memory so that may not be entirely accurate 😀
vaseer45
@vaseer45
Jun 18 2018 23:39
@danwalmsley thanks! Will give it a shot and will confirm