These are chat archives for AvaloniaUI/Avalonia

19th
Jun 2018
Vsevolod Pilipenko
@Karnah
Jun 19 2018 06:35
Hello all. I have a small question. If I'll try review other PR before maintainers and left some comments - it will be OK? Or it is better not to intervene at least before some maintainer review it?
Rayyan Tahir
@RayyanTahir
Jun 19 2018 06:39
@Splitwirez I tried to give a go at Window transparency, but got nowhere with it. Perhaps someone more experienced can take up on this?
Steven Kirk
@grokys
Jun 19 2018 06:49
@Karnah please do review PRs! even if you don't feel like you can review the code, you can test it and make sure it's working correctly
Steven Kirk
@grokys
Jun 19 2018 06:59
@vaseer45 i'm looking at your project but i can't work out what i'm supposed to be doing
Vsevolod Pilipenko
@Karnah
Jun 19 2018 16:21
Thank you, @grokys ! But in this moment most of my comments are about code style or something else. I'm scared that they are useless and waste your time. If this is the case then, please, tell me!
Steven Kirk
@grokys
Jun 19 2018 16:21
no, your comments are very good!
please continue ;) i really appreciate the help
Vsevolod Pilipenko
@Karnah
Jun 19 2018 16:25
That nice to hear. This project is wonderful!
Nelson Carrillo
@nc4rrillo
Jun 19 2018 17:05
Yes please continue I appreciate it!
Benedikt Schroeder
@Gillibald
Jun 19 2018 18:23
Any idea how to make this work:
using (UnitTestApplication.Start(TestServices.StyledWindow))
{
    var mainWindow = new Window();
    Application.Current.Run(mainWindow);
    Assert.True(mainWindow.IsVisible);
}
My problem is that the UnitTestApplication has no real main loop so it gets terminated asap and OnExit is called too early.
Steven Kirk
@grokys
Jun 19 2018 18:45
@nc4rrillo i've taken a look at the PR, and it looks good to my uneducated eyes
i don't really want to approve it as i've not been involved with the skia backend and i don't really know it
but as soon as I see an approval, or after an arbitrary length of time given no approvals, i'm fine with merging
there are a number of other skia PRs - are they still relevant?
Nelson Carrillo
@nc4rrillo
Jun 19 2018 19:02
I have to look. I know one was recently merged. There may be a few more
Jeremy Koritzinsky
@jkoritzinsky
Jun 19 2018 21:22
I merged in most of the other Skia PRs.
Steven Kirk
@grokys
Jun 19 2018 21:24
ah! yes, so you did - sorry i didn't notice that
Jeremy Koritzinsky
@jkoritzinsky
Jun 19 2018 21:25
Haha don’t worry about it!
Steven Kirk
@grokys
Jun 19 2018 21:29
@jkoritzinsky how does #1679 look to you? @jmacato said it fixed one of his problem so gets his :+1:
Jeremy Koritzinsky
@jkoritzinsky
Jun 19 2018 21:30
Give me 10 minutes to review. If I think it's good I'll approve it. πŸ‘
Jeremy Koritzinsky
@jkoritzinsky
Jun 19 2018 21:43
@grokys @nc4rrillo Only thing missing in #1679 is an update to build.cake to run the Skia.UnitTests tests that is added in the PR.
Steven Kirk
@grokys
Jun 19 2018 21:43
ah yeah
Jeremy Koritzinsky
@jkoritzinsky
Jun 19 2018 21:43
Once that's done it has my approval
Nelson Carrillo
@nc4rrillo
Jun 19 2018 21:46
Will do as soon as I get home. πŸ™‚
Jeremy Koritzinsky
@jkoritzinsky
Jun 19 2018 21:46
:+1:
Also I think we should merge #1661 before we Span-ify it. We're blocked until the next VS minor release on a bug in the Xamarin.Android reference assembly for System.Memory
Steven Kirk
@grokys
Jun 19 2018 21:49
yeah, i'm waiting for CI to finish and will merge
Steven Kirk
@grokys
Jun 19 2018 21:59
merged!
Benedikt Schroeder
@Gillibald
Jun 19 2018 22:01
πŸ‘
Just tried again without the invoke call and it just works. Magic...
Jeremy Koritzinsky
@jkoritzinsky
Jun 19 2018 22:08
@Gillibald I think I know why. The mock threading interface doesn't actually run the main loop. So the callback wasn't being executed.
Benedikt Schroeder
@Gillibald
Jun 19 2018 22:11
I have removed the test. Just too much effort making it testable.
Has anyone notices that licence.md is spelled wrong?
ReSpeller is such a good tool :smile:
Jeremy Koritzinsky
@jkoritzinsky
Jun 19 2018 22:21
Haha never noticed!
A license (American English) or licence (British English)
I'm English ;)
i do try to use american spelling in software just because it's kinda the standard there, but sometimes i mess up ;)
i used to have a colleague who refused to use american spellings so you'd have stuff like Color Colour { get; } which was really irritating!
Nelson Carrillo
@nc4rrillo
Jun 19 2018 23:38
@jkoritzinsky updated build.cake, rebased, and squashed
I think it is good to go now
just waiting on CI