These are chat archives for AvaloniaUI/Avalonia

20th
Jun 2018
Nelson Carrillo
@nc4rrillo
Jun 20 2018 03:59
Getting "No Path Command Declared" while trying to run the RenderTest application. Seems related to the new PathMarkupParser @Gillibald
Benedikt Schroeder
@Gillibald
Jun 20 2018 04:49
I don't see a failing test.
Jumar Macato
@jmacato
Jun 20 2018 04:54
@Gillibald RenderTest has failed here too, i'll send the full debug log
Jumar Macato
@jmacato
Jun 20 2018 05:07
seems like whitespace isn't being handled correctly by PathMarkupParser
image.png
Benedikt Schroeder
@Gillibald
Jun 20 2018 06:09
I don't see why this can happen. All render tests passed on my machine. Skia and Direct2D1 worked just fine.
Even unit tests for just the parsing passed. And there are a lot paths tested. Will check it later this day.
Jumar Macato
@jmacato
Jun 20 2018 06:15
check RenderTest's Pages/AnimationPage.xaml
Benedikt Schroeder
@Gillibald
Jun 20 2018 06:24
Is there a way to force run all unit tests? I just use ReSharper to run all unit tests of the solution. Still don't understand why AppVeyor passed.
Nelson Carrillo
@nc4rrillo
Jun 20 2018 10:25
RenderTest is a project not a test, despite the name
Jumar Macato
@jmacato
Jun 20 2018 10:27
Yeah, that got a bit confusing. Perhaps we can rename those projects into something more intuitive..
Steven Kirk
@grokys
Jun 20 2018 10:45
yeah, that would be a good idea i think
Benedikt Schroeder
@Gillibald
Jun 20 2018 13:19
Have fixed the issue. Thanks for letting me know. Haven't checked for extra whitespaces.
These extreme path definitions helped identifying the issue :smile:
Now the PathMarkupParser needs Span<T> even more. Hope the fix doesn't impact the performance too much.
Jumar Macato
@jmacato
Jun 20 2018 13:25
@Gillibald awesome! :smile:
Nelson Carrillo
@nc4rrillo
Jun 20 2018 13:31
Can we add a test for the issue too
That’s great news though :)
Benedikt Schroeder
@Gillibald
Jun 20 2018 13:31
Already done
Nelson Carrillo
@nc4rrillo
Jun 20 2018 13:31
👏🏼
Benedikt Schroeder
@Gillibald
Jun 20 2018 13:32
@jmacato Do you mean the new line?
Jumar Macato
@jmacato
Jun 20 2018 13:32
Wait, i'll double check. It's quite hard to review PR's on Linux :/
@Gillibald okay, done double-checking; indeed that newline
Benedikt Schroeder
@Gillibald
Jun 20 2018 13:36
But how is a new line between the statements against the code style?
Should variable definitions be together without new lines between them?
Nelson Carrillo
@nc4rrillo
Jun 20 2018 13:38
I think it’s a judgement call, I don’t see a problem with the new line
Jumar Macato
@jmacato
Jun 20 2018 13:38
Yeah, it's just a aesthetic nit because i noticed some of your variable definitions are grouped
some are not :)
other than that, PR looks good! :)
Benedikt Schroeder
@Gillibald
Jun 20 2018 13:39
Will group them :smile:
Jumar Macato
@jmacato
Jun 20 2018 13:39
Awesome :smile:
@nc4rrillo AppVeyor catched some error on on #1681, forgot to rename them on the sln file
Jumar Macato
@jmacato
Jun 20 2018 14:18
@Gillibald #1682 merged! :smile:
Benedikt Schroeder
@Gillibald
Jun 20 2018 14:28
:+1:
Nelson Carrillo
@nc4rrillo
Jun 20 2018 15:21
What’s with the intermittent failures in CI. With appveyor
Seems related to leak test
Jumar Macato
@jmacato
Jun 20 2018 15:22
@nc4rrillo sometimes TravisCI just gives up randomly, quite weird..
Jeremy Koritzinsky
@jkoritzinsky
Jun 20 2018 15:25
Yeah I'm not sure why that failure happens. I just restarted the build. I'm very sure it's a bug in dotMemoryUnit
Steven Kirk
@grokys
Jun 20 2018 16:43
i just implemented StringFormat for bindings
was pretty simple, except portable.xaml doesn't handle the syntax :(
ahopper
@ahopper
Jun 20 2018 16:49
cool, is that wpf style stringformat or something more cunning
Steven Kirk
@grokys
Jun 20 2018 16:50
just wpf-style at the moment. the only difference is that i made it work for object properties as well as string properties
ahopper
@ahopper
Jun 20 2018 17:17
replacing stringformat with a converter was one of the more boring tasks in converting wpf code
Steven Kirk
@grokys
Jun 20 2018 20:41
yeah i can imagine
Steven Kirk
@grokys
Jun 20 2018 21:47
i don't suppose anyone wants to fix cwensley/Portable.Xaml#106 ?
;)
i'm having difficulty working out how to fix this
the XAML spec doesn't even seem to mention this case
Nelson Carrillo
@nc4rrillo
Jun 20 2018 21:53
The camp code is so mysterious to me
Xaml *
Steven Kirk
@grokys
Jun 20 2018 21:55
yeah....
it's not much fun to work with
ahopper
@ahopper
Jun 20 2018 22:02
don't know it it is connected but in using a converter I ended up with odd escaping on the converterParamerter
Text="{Binding Temp, Converter={x:Static p:StringConverters.StringFormat },ConverterParameter=\{0:#\,#.0\}C}"/>
Steven Kirk
@grokys
Jun 20 2018 22:07
yeah, that's an alternative i guess
would be nice to get portable.xaml fixed though
ahopper
@ahopper
Jun 20 2018 22:11
yep, I guess it probably explains why I had to do that, I didn't understand at the time but stopped looking once something worked
Nelson Carrillo
@nc4rrillo
Jun 20 2018 22:53
@grokys @jkoritzinsky rebased #1679 again and addressed nits