These are chat archives for AvaloniaUI/Avalonia

23rd
Jun 2018
Nelson Carrillo
@nc4rrillo
Jun 23 2018 00:52
taking a look now
gosh portable xaml being a submodule is such a foot gun
Jeremy Koritzinsky
@jkoritzinsky
Jun 23 2018 01:35
Yeah I can't wait until we can pick it up via a NuGet package.
Nelson Carrillo
@nc4rrillo
Jun 23 2018 01:52
I'm working on the Skia portion of #1689 , the way SkPaint objects are managed needs to change I think, and also text measurement will need to be updated to not assume there's a uniform font size when measuring
Skia has such an awkward immediate mode API
Jumar Macato
@jmacato
Jun 23 2018 02:06
@danwalmsley alright, keeping it as it is for now :)
Nelson Carrillo
@nc4rrillo
Jun 23 2018 03:31
image.png
WIP Skia text elements
looks pretty close to d2d backend, just need to fix everything I broke and ensure it still passes render tests
Nelson Carrillo
@nc4rrillo
Jun 23 2018 03:37
currently failing 3 tests :(
Steven Kirk
@grokys
Jun 23 2018 13:34
ok, i think AvaloniaUI/Avalonia#1690 is ready for review
almost 50% reduction in memory on ControlCatalog
i've got a pretty good idea of how we can reduce it even more
Wiesław Šoltés
@wieslawsoltes
Jun 23 2018 13:48
@grokys This is great memory reduction!
Steven Kirk
@grokys
Jun 23 2018 13:48
does it break anything?
Wiesław Šoltés
@wieslawsoltes
Jun 23 2018 13:49
did not try
Steven Kirk
@grokys
Jun 23 2018 13:49
it probably will ;)
Wiesław Šoltés
@wieslawsoltes
Jun 23 2018 13:49
no worries will fix my code
Steven Kirk
@grokys
Jun 23 2018 13:49
oh well if it breaks stuff, it's the PR that's bad
it shouldn't change any behavior
it needs testing with core2d and avalonstudio before we merge though
Wiesław Šoltés
@wieslawsoltes
Jun 23 2018 13:50
will try to test
with Core2D
need to finish some stuff with Core2D and will give the PR a go
Steven Kirk
@grokys
Jun 23 2018 13:52
sure!
Wiesław Šoltés
@wieslawsoltes
Jun 23 2018 13:53
I am working on WPF version of Core2D, it is currently broken :worried: will try to compare memory usage between Avalonia and WPF after startup :fire:
Wiesław Šoltés
@wieslawsoltes
Jun 23 2018 15:21
@grokys Seems like most of the stuff works when using AvaloniaUI/Avalonia#1690
with Core2D
seems like not only memory usage is affected by this PR
the data templates are loaded much faster
Steven Kirk
@grokys
Jun 23 2018 15:23
yeah, i noticed that things seemed to be faster - that was a total side-effect!
you said "most". what's not working?
Wiesław Šoltés
@wieslawsoltes
Jun 23 2018 15:24
I was just cautious
still testing
I did not find anything broken so far
Steven Kirk
@grokys
Jun 23 2018 15:28
oh cool!
Steven Kirk
@grokys
Jun 23 2018 15:48
i've got another change coming up that takes another 3mb off, but going to put that in a separate PR as it's slightly different
Wiesław Šoltés
@wieslawsoltes
Jun 23 2018 15:57
@grokys I have did quick videos comparing before and after
You can see how Shape tab has long delay before displaying view
with AvaloniaUI/Avalonia#1690 this delay is very small
Nelson Carrillo
@nc4rrillo
Jun 23 2018 16:00
amazing stuff #1690
Wiesław Šoltés
@wieslawsoltes
Jun 23 2018 16:01
@danwalmsley Take a look at AvaloniaUI/Avalonia#1690 this is big perf improvement, should also be nicer perf improvement for Dock
@grokys I did my tests using .NET Core 2.1
Steven Kirk
@grokys
Jun 23 2018 16:04
oh wow! yeah that's really noticeable. i didn't expect that to happen!
Wiesław Šoltés
@wieslawsoltes
Jun 23 2018 16:04
this was one of the main perf issues with Avalonia when using Core2D
imagine what performance we will get once the xaml code generated :fire:
Vsevolod Pilipenko
@Karnah
Jun 23 2018 17:02
Can I'll try find bug in #1625 issue? Or it's already found?
Jumar Macato
@jmacato
Jun 23 2018 17:04
@Karnah if you meant reproducing the bug then please do, if you can't find it then perhaps we can close that one up :)
Vsevolod Pilipenko
@Karnah
Jun 23 2018 17:06
I already reproduced :C Bug is still not fixed
Jumar Macato
@jmacato
Jun 23 2018 17:06
Oh.. hmm, can you post that repro project?
Vsevolod Pilipenko
@Karnah
Jun 23 2018 17:09
@Feroks created it and publish link in issue - https://github.com/Feroks/Avalonia.Repaint. I just transferred to my master branch and recheck
Robert Hencke
@rhencke
Jun 23 2018 20:02
Has anyone encountered an issue where Avalonia beeps every time a character is typed into a TextBox?
Steven Kirk
@grokys
Jun 23 2018 21:07
@rhencke no?!? how strange
i don't think avalonia has any audio code at all so i don't think it's us!
Robert Hencke
@rhencke
Jun 23 2018 22:35
@grokys I'll see if I can narrow it down more, try a different environment. I have a feeling it's something to do with the fact I'm running it on macOS. Thanks. :)
Robert Hencke
@rhencke
Jun 23 2018 23:25
@grokys I figured it part of it. Everything still beeps, but backspace works now. I'll submit a PR :smile: