These are chat archives for AvaloniaUI/Avalonia

29th
Jun 2018
Jumar Macato
@jmacato
Jun 29 2018 05:27 UTC
@ahopper please recheck latest master build :) Thanks @Gillibald !
ahopper
@ahopper
Jun 29 2018 06:02 UTC
@jmacato will do once the myget appears, there appears to be a test failing at the moment
ahopper
@ahopper
Jun 29 2018 06:41 UTC
getting closer :smile:
Could not convert object 'M482.2 372.1C476.5 365.2 250 75 242.3 65.5c-13.7-17.2 0-16.8 19.2-16.9 9.7-.1 106.3-.6 116.5-.6 24.1-.1 28.7.6 38.4 12.8 2.1 2.7 205.1 245.8 207.2 248.3 5.5 6.7 15.2 19.1 7.2 23.4-2.4 1.3-114.6 47.7-117.8 48.9-10.1 4-17.5 6.8-30.8-9.3m114.7-5.6s-115 50.4-117.5 51.6c-16 7.3-26.9-3.2-36.7-14.6l-57.1-74c-5.4-.9-60.4-9.6-65.3-9.3-3.1.2-9.6.8-14.4 2.9-4.9 2.1-145.2 52.8-150.2 54.7-5.1 2-11.4 3.6-11.1 7.6.2 2.5 2 2.6 4.6 3.5 2.7.8 300.9 67.6 308 69.1 15.6 3.3 38.5 10.5 53.6 1.7 2.1-1.2 123.8-76.4 125.8-77.8 5.4-4 4.3-6.8-1.7-8.2-2.3-.3-24.6-4.7-38-7.2m-326-181.3s-12 1.6-25 15.1c-9 9.3-242.1 239.1-243.4 240.9-7 10 1.6 6.8 15.7 1.7.8 0 114.5-36.6 114.5-36.6.5-.6-.1-.1.6-.6-.4-5.1-.8-26.2-1-27.7-.6-5.2 2.2-6.9 7-8.9l92.6-33.8c.6-.8 88.5-81.7 90.2-83.3v-1l-51.2-65.8' (of type System.String) to {clr-namespace:Avalonia.Media;assembly=Avalonia.Visuals}Geometry: Unexpected path command '.'.
in fontAwesome
Benedikt Stebner
@Gillibald
Jun 29 2018 06:48 UTC
Is that an public repo? Just let me test against it and fix everything.
Rayyan Tahir
@RayyanTahir
Jun 29 2018 06:49 UTC
Thank you so much for looking into AvaloniaUI/Avalonia#1709 and fixing it @grokys & @danwalmsley :). But the repro I provided is still failing with the latest pre-release build 5567.
gives you a few thousand paths to test
Benedikt Stebner
@Gillibald
Jun 29 2018 06:51 UTC
Will test against that and fix everything that blows up.
ahopper
@ahopper
Jun 29 2018 06:52 UTC
great thanks
Jumar Macato
@jmacato
Jun 29 2018 06:52 UTC
Tried debug-pausing for roughly 2hrs a looped animation exaple app via unify-timers branch and SO exceptions doesn't happen anymore :smile:
also tried to run a 300+ looped animation example for 3hrs and still works A-OK
@danwalmsley i hope you can confirm on your side when you test the branch later :smile:
ahopper
@ahopper
Jun 29 2018 07:14 UTC
@Gillibald in case it is not clear, just running the app will try and load all icons
Steven Kirk
@grokys
Jun 29 2018 07:15 UTC
@RayyanTahir i only merged it 30 minutes ago - CI hadn't finished running for that build ;) you want build 5568
Rayyan Tahir
@RayyanTahir
Jun 29 2018 07:15 UTC
@grokys there is a follow up issue too :P
I'm going to write the steps to repro here:
  1. Add an item
  2. Remove that item
  3. Add the same item
  4. Add the same item again
  5. Crash with exception: System.ArgumentException: 'An item with the same key has already been added. Key: 1'

StackTrace:

   at System.ThrowHelper.ThrowAddingDuplicateWithKeyArgumentException(Object key)
   at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
   at System.Collections.Generic.Dictionary`2.Add(TKey key, TValue value)
   at Avalonia.Controls.Generators.ItemContainerGenerator.Materialize(Int32 index, Object item, IMemberSelector selector)
   at Avalonia.Controls.Presenters.ItemVirtualizerSimple.CreateAndRemoveContainers()
   at Avalonia.Controls.Presenters.ItemVirtualizerSimple.ItemsChanged(IEnumerable items, NotifyCollectionChangedEventArgs e)
   at Avalonia.Controls.Presenters.ItemsPresenter.ItemsChanged(NotifyCollectionChangedEventArgs e)
   at Avalonia.Controls.Presenters.ItemsPresenterBase.ItemsCollectionChanged(Object sender, NotifyCollectionChangedEventArgs e)

I tried this by taking pull of your fix AvaloniaUI/Avalonia#1711 from master in my repro project. ;)

danwalmsley
@danwalmsley
Jun 29 2018 08:00 UTC
@grokys ill try and get you a repro for mine, its basically similar but caused when you bind selected items and you do something. Similar
Rayyan Tahir
@RayyanTahir
Jun 29 2018 09:02 UTC
@danwalmsley were you by any chance getting: System.Collections.Generic.KeyNotFoundException: 'The given key was not present in the dictionary.' ?
ahopper
@ahopper
Jun 29 2018 09:26 UTC
this binding now gives a parse error
IsVisible="{Binding !$parent.DataContext.rxProcessor.ptt}"
with the latest build, removing the ! makes it work
ahopper
@ahopper
Jun 29 2018 09:39 UTC
it seems to be the combination of ! and $parent
Steven Kirk
@grokys
Jun 29 2018 09:56 UTC
@ahopper could you try $parent.!DataContext.rxProcessor.ptt? just out of interest
ahopper
@ahopper
Jun 29 2018 09:58 UTC
that works
Steven Kirk
@grokys
Jun 29 2018 10:11 UTC
hmm, i wonder how the previous worked before...
Benedikt Stebner
@Gillibald
Jun 29 2018 10:11 UTC
@ahopper I have found the bug that caused the remaining issue but couldn't run your project. Will create a PR with a fix. Lets hope it is the last one needed :smile:
Steven Kirk
@grokys
Jun 29 2018 10:11 UTC
our handling of $parent, $self etc is rather hacky at the moment
ahopper
@ahopper
Jun 29 2018 10:15 UTC
@grokys it worked until quite recently, is your version the preferred syntax?
Steven Kirk
@grokys
Jun 29 2018 10:15 UTC
my preferred syntax is what you had before
need to try to work out how that even worked before! last time i tried it, it didn't
ahopper
@ahopper
Jun 29 2018 10:18 UTC
well it certainly didn't throw an error in the past, and I'm 90% sure it did what it should :smile:
Steven Kirk
@grokys
Jun 29 2018 10:22 UTC
yeah, i totally believe you! just not sure how :D
ahopper
@ahopper
Jun 29 2018 10:27 UTC
@Gillibald thanks, what was the issue with my project?
Benedikt Stebner
@Gillibald
Jun 29 2018 10:29 UTC
The parser ignored the fact that a double value can start with a dot (.5) when an implicit command is present.
ahopper
@ahopper
Jun 29 2018 10:33 UTC
sorry I meant what was the problem with running the iconpacks app?
Benedikt Stebner
@Gillibald
Jun 29 2018 10:35 UTC
I had to remove the nuget packages and reference the projects directly to debug it properly. That didn't work out.
ahopper
@ahopper
Jun 29 2018 10:35 UTC
yep, I've been wondering if there is an easy way to do that
Steven Kirk
@grokys
Jun 29 2018 10:42 UTC
we need to alter our cake script so that it can quickly build nuget packages locally
ahopper
@ahopper
Jun 29 2018 11:45 UTC
@Gillibald all the paths in iconpacks now parse, thanks very much.
danwalmsley
@danwalmsley
Jun 29 2018 12:45 UTC
@RayyanTahir I was getting Duplicate key exception
I worked around it by disabling scroll to selected item
Rayyan Tahir
@RayyanTahir
Jun 29 2018 12:45 UTC
@danwalmsley where key = 1 right?
key = 3 in my case, because it says
newKey= containers.count
but it has already removed the first container
so it should have done
newkey = cointainers.Last().Key + 1
@grokys does that make sense?
Rayyan Tahir
@RayyanTahir
Jun 29 2018 12:54 UTC
@danwalmsley @grokys the issues I am facing get fixed If I add a line as displayed in the following image:
image.png
danwalmsley
@danwalmsley
Jun 29 2018 12:57 UTC
anyone removed the Window.OpenWindows api?
Rayyan Tahir
@RayyanTahir
Jun 29 2018 13:03 UTC
@danwalmsley can you provide your binding problem repro so I can test a fix that I have in mind?
danwalmsley
@danwalmsley
Jun 29 2018 13:04 UTC
@RayyanTahir sorry I wont get time to do it right now
i'll try and send it this weekend
Rayyan Tahir
@RayyanTahir
Jun 29 2018 13:04 UTC
Sure, that's fine
danwalmsley
@danwalmsley
Jun 29 2018 13:04 UTC
I can describe quickly how to implement it though
Rayyan Tahir
@RayyanTahir
Jun 29 2018 13:04 UTC
That would be good for now
danwalmsley
@danwalmsley
Jun 29 2018 13:04 UTC
I had 2 listboxes
and 2 buttons
I add items to the 1st listbox (using reactive list)
then the 1st button used to transfer selected items to the 2nd listbox
and the other listbox back
after I send the first item to the second listbox
then back again
and select another item
the bug is triggered
usually had to be an item with an index lower than the first
Rayyan Tahir
@RayyanTahir
Jun 29 2018 13:06 UTC
Got it, I'll repro this at my end. Thanks
danwalmsley
@danwalmsley
Jun 29 2018 13:15 UTC
@RayyanTahir oh important info
the SelectedItems must also be bound to an observablecollection
too
Rayyan Tahir
@RayyanTahir
Jun 29 2018 13:16 UTC
for more than one selected?
Wiesław Šoltés
@wieslawsoltes
Jun 29 2018 13:18 UTC

we need to alter our cake script so that it can quickly build nuget packages locally

@grokys I will submit PR with some proposal how to solve this issue :smile:

Steven Kirk
@grokys
Jun 29 2018 13:26 UTC
that would be wonderful!
Wiesław Šoltés
@wieslawsoltes
Jun 29 2018 13:27 UTC
its bit hacky
the dependency task tree is problematic with Cake
if you want run single tasks
@grokys AvaloniaUI/Avalonia#1716
Steven Kirk
@grokys
Jun 29 2018 13:34 UTC
thanks a lot @wieslawsoltes! not going to have time to take a look at it right now but @Gillibald might be interested!
Wiesław Šoltés
@wieslawsoltes
Jun 29 2018 13:35 UTC
I can not test fully on my machine as I don't have Xamarin :smile:
@jmacato Please take a look at AvaloniaUI/Avalonia#1716
Jumar Macato
@jmacato
Jun 29 2018 13:37 UTC
@wieslawsoltes sure!
Wiesław Šoltés
@wieslawsoltes
Jun 29 2018 13:37 UTC
I forgot about Xamarin
we need to make it possible to build without Xamarin installed
Jumar Macato
@jmacato
Jun 29 2018 13:37 UTC
Yeah i agree!
Wiesław Šoltés
@wieslawsoltes
Jun 29 2018 13:38 UTC
but this should be separate PR
Jumar Macato
@jmacato
Jun 29 2018 13:38 UTC
specially for those with limited bandwidth who can only download .net core + vscode
or uses linux
Steven Kirk
@grokys
Jun 29 2018 13:55 UTC
@danwalmsley this PR moved Window.OpenWindows to Application
AvaloniaUI/Avalonia#1662
danwalmsley
@danwalmsley
Jun 29 2018 13:56 UTC
@grokys thanks
Benedikt Stebner
@Gillibald
Jun 29 2018 14:04 UTC
@grokys Did that change break anything?
Steven Kirk
@grokys
Jun 29 2018 14:08 UTC
no, i don't think so. dan was just asking where it had moved
i'm sure he's used to subtle API changes by now ;)
Rayyan Tahir
@RayyanTahir
Jun 29 2018 14:09 UTC
@grokys I think I was able to fix the binding issue that persisted after #1711 , just wanted to run the suggestion by you to make sure nothing else will break, it's just a one line fix
Steven Kirk
@grokys
Jun 29 2018 14:10 UTC
sure
Rayyan Tahir
@RayyanTahir
Jun 29 2018 14:10 UTC
Please see image below (red arrow points to one line solution):
With the above solution I was able to add/remove as many items as I liked in a ListBox
Steven Kirk
@grokys
Jun 29 2018 14:11 UTC
hmm yeah i can see that would fix it, but i think it's just masking the problem
Rayyan Tahir
@RayyanTahir
Jun 29 2018 14:12 UTC
That's true
Steven Kirk
@grokys
Jun 29 2018 14:12 UTC
that method shouldn't get called for items that already exist
Rayyan Tahir
@RayyanTahir
Jun 29 2018 14:13 UTC
Right, I can go from there ^ and see for another fix to this problem
Steven Kirk
@grokys
Jun 29 2018 14:14 UTC
that would be great! good luck!
that code is kinda complex
Rayyan Tahir
@RayyanTahir
Jun 29 2018 14:14 UTC
Thanks, I'll try my best, if I can't I'll let you know
Steven Kirk
@grokys
Jun 29 2018 14:14 UTC
best thing is to try to write a unit test that triggers it
that way even if you can't fix it, i know where to look
Rayyan Tahir
@RayyanTahir
Jun 29 2018 14:15 UTC
Good suggestion, haven't ever written unit tests before but I'll give that a go too
Wiesław Šoltés
@wieslawsoltes
Jun 29 2018 14:46 UTC
making progress with Cake :fire:
Jumar Macato
@jmacato
Jun 29 2018 14:48 UTC
@danwalmsley please try #1715 again, i fixed Transitions albeit temporarily.
Jumar Macato
@jmacato
Jun 29 2018 15:04 UTC
nice progress on #1716 @wieslawsoltes :smile:
Wiesław Šoltés
@wieslawsoltes
Jun 29 2018 15:05 UTC
you can try now: ./build.ps1 -Target "Create-NuGet-Packages-Impl" -Platform "NetCoreOnly" -Configuration "Release"
or using bash script
under Linux
Jumar Macato
@jmacato
Jun 29 2018 15:06 UTC
Alright, pulling PR now
Wiesław Šoltés
@wieslawsoltes
Jun 29 2018 15:06 UTC
having -Impl tasks is a bit ugly, but makes life so much easier
also added zip file to artifacts with all .nupkg :smile:
Jumar Macato
@jmacato
Jun 29 2018 15:09 UTC
Nice! currently executing build.sh
Wiesław Šoltés
@wieslawsoltes
Jun 29 2018 15:46 UTC
Task                          Duration
--------------------------------------------------
Setup                         00:00:00.5115886
Clean-Impl                    00:00:00.8747087
Clean                         00:00:00.0005189
Restore-NuGet-Packages-Impl   Skipped
Restore-NuGet-Packages        00:00:00.0005365
Build-Impl                    00:00:18.6095108
Build                         00:00:00.0005980
Run-Unit-Tests-Impl           00:00:38.3635532
Run-Unit-Tests                00:00:00.0004989
Run-Render-Tests-Impl         Skipped
Run-Render-Tests              00:00:00.0004935
Run-Designer-Tests-Impl       00:00:04.8546679
Run-Designer-Tests            00:00:00.0005009
Run-Leak-Tests-Impl           Skipped
Run-Leak-Tests                00:00:00.0004871
Run-Tests                     00:00:00.0004935
Copy-Files-Impl               00:00:00.0898618
Copy-Files                    00:00:00.0005171
Inspect-Impl                  Skipped
Inspect                       00:00:00.0005181
Create-NuGet-Packages-Impl    00:00:04.5824331
Create-NuGet-Packages         00:00:00.0004933
Zip-Files-Impl                00:00:00.6270320
Zip-Files                     00:00:00.0004858
Teardown                      00:00:00.0009674
--------------------------------------------------
Total:                        00:01:08.5204651
PS C:\DOWNLOADS\GitHub-Forks\Avalonia> ./build.ps1 -Target "Zip-Files" -Platform "NetCoreOnly" -Configuration "Release"
:smile:
AvaloniaUI/Avalonia#1716 is ready for review
ahopper
@ahopper
Jun 29 2018 16:19 UTC
this looks great, an idiots guide to using it in your own project would be very useful