These are chat archives for Azurasky1/DragonArena

16th
Jun 2016
Andrea Sonny
@andreasonny83
Jun 16 2016 06:58 UTC
I think 9 frames for an animation like that should be more than ideal. I think 4 or 5 frames should be a standard sprite animation.
The problem is the relation between fps, time and the x,y pan. All of them should be set to a correct value that depends on the graphic of the animation.
However, our sprite is something temporary so I wouldn't spend too much effort on that until we have a final ui
Billy B.
@Azurasky1
Jun 16 2016 11:27 UTC
i fixed it
also added health bars
gonna commit my changes in a little bit :D
Billy B.
@Azurasky1
Jun 16 2016 12:36 UTC
submitted pull request
Andrea Sonny
@andreasonny83
Jun 16 2016 13:41 UTC
hello
Billy B.
@Azurasky1
Jun 16 2016 13:41 UTC
hey
Andrea Sonny
@andreasonny83
Jun 16 2016 13:41 UTC
you closed the CodeStyleguide but I cannot see any implementation for that in the code
Billy B.
@Azurasky1
Jun 16 2016 13:42 UTC
no it's there
i installed the plugin in atom
then just made the changes and committed them
Andrea Sonny
@andreasonny83
Jun 16 2016 13:42 UTC
ok, but there is no .jscs configuration file
Billy B.
@Azurasky1
Jun 16 2016 13:42 UTC
i wouldn't really know about that
Andrea Sonny
@andreasonny83
Jun 16 2016 13:43 UTC
right, so I’m going to reopen the card and make the real code implementation
Billy B.
@Azurasky1
Jun 16 2016 13:43 UTC
ok
Andrea Sonny
@andreasonny83
Jun 16 2016 13:47 UTC
what is the Thumbs.db file in app/images/?
Billy B.
@Azurasky1
Jun 16 2016 13:48 UTC
uhhhh
i have no idea
it's not even showing up in my directory
Andrea Sonny
@andreasonny83
Jun 16 2016 13:49 UTC
it’s in the pull request
add Thumbs.db in your .gitignore file and commit again so the will disappear
make sure you’re checking out the movement branch
Billy B.
@Azurasky1
Jun 16 2016 13:51 UTC
where is gitignore
is that just the blank one
found it
done
Andrea Sonny
@andreasonny83
Jun 16 2016 14:13 UTC
did you push?
I can still see that file in the pull request
I’m also writing some comments on your PR
Billy B.
@Azurasky1
Jun 16 2016 14:18 UTC
Yeah im seeing those now. Good catches
i was pretty tired when i pushed that so im not surprised some unused variables slipped through the cracks
Pushed
Andrea Sonny
@andreasonny83
Jun 16 2016 14:24 UTC
have a look at the comments
in github
Billy B.
@Azurasky1
Jun 16 2016 14:26 UTC
I saw them all, good eye
so what happens in that case, when the pull request has errors, is there a way to just edit them and merge
or will it take abother pull request
Andrea Sonny
@andreasonny83
Jun 16 2016 14:52 UTC
yes, you just make the merge in your branch and push again
and the pull request get updated in real time as it’s pointing to the same branch