These are chat archives for BSData/warhammer-age-of-sigmar

23rd
Feb 2017
msinosic
@msinosic
Feb 23 2017 10:00 UTC

omg. I didn't realise you could copy paste in adobe reader with the select tool. I typed up all the seraphon stuff by hand... anyway!...

I am going to add the other lizardmen special characters and unis missing from the seraphon book in the coming day or two.

Jon Kissinger
@alphalas
Feb 23 2017 11:00 UTC
Hey @msinosic we might want to make those compendium units from lizardmen reflect that they are lizardmen, not seraphon, per the AoS app.
msinosic
@msinosic
Feb 23 2017 11:02 UTC
Was thinking about it, All but Jungle Swarms have SERAPHON in their keywords.
I just added them for now under Seraphon, easy to change if people want to debate it.
Jon Kissinger
@alphalas
Feb 23 2017 11:08 UTC
lol actually, in the app, the only one that doesn't have seraphon keyword is the swarms
So you were more right then I am lol
~ David Jobling
@david_jobling_twitter
Feb 23 2017 15:29 UTC
Hello, I would like to help with some of the profiles for destruction, but I am not sure how I submit my changes to you?
ResidentSteve
@ResidentSteve
Feb 23 2017 16:04 UTC
Hello @david_jobling_twitter, you can put through merge requests like @msinosic does or request access by raising an issue
~ David Jobling
@david_jobling_twitter
Feb 23 2017 18:17 UTC
Ive worked on the Beastclaw Raiders Profiles (first time doing this so hope its OK)
~ David Jobling
@david_jobling_twitter
Feb 23 2017 22:10 UTC
Do profiles require rules summaries?
Earl Bishop
@DrTobogganMD
Feb 23 2017 22:11 UTC
It certainly helps users
~ David Jobling
@david_jobling_twitter
Feb 23 2017 22:13 UTC
OK, will add those before I submit it. I've added the allegiance rules also but didnt know if there was a way to make that only appear if it was the main allegiance
Earl Bishop
@DrTobogganMD
Feb 23 2017 22:14 UTC
Hide if not
Is the general idea
I haven't looked at the aos gst in months though. So I'm not sure what would work
~ David Jobling
@david_jobling_twitter
Feb 23 2017 22:15 UTC
OK cheers, will update tomorrow. Only file I have is the one I have on my machine here how do I submit it? New to Github
Earl Bishop
@DrTobogganMD
Feb 23 2017 22:16 UTC
If you're a member you can commit directly
If not you can do a pull request from your branch
You'd need to fork first of course to actually get one
~ David Jobling
@david_jobling_twitter
Feb 23 2017 22:18 UTC
I just used the data editor on the file I had downloaded. Will I still be able to submit that (once I create a fork etc)?
Earl Bishop
@DrTobogganMD
Feb 23 2017 22:22 UTC
Unless someone else committed since you did work.
Otherwise should be fine
~ David Jobling
@david_jobling_twitter
Feb 23 2017 22:23 UTC
Thanks Kohato
Earl Bishop
@DrTobogganMD
Feb 23 2017 22:23 UTC
Basically 2 people shouldn't submit changed files at once :) No
Np*
~ David Jobling
@david_jobling_twitter
Feb 23 2017 22:23 UTC
Still struggling with forking, any simple advice?
Earl Bishop
@DrTobogganMD
Feb 23 2017 22:24 UTC
Click fork
Name fork
Upload your file to forked repo
Create pull request (button on your fork)
If you can't get it (I'm on mobile. Can't really walk through it atm). Drag and drop the cat file here in the Gitter window
One of us can commit it
~ David Jobling
@david_jobling_twitter
Feb 23 2017 22:26 UTC
Ok great thanks again, I will just add the hidden parts and double check my work
Earl Bishop
@DrTobogganMD
Feb 23 2017 22:26 UTC
Cool. Np
msinosic
@msinosic
Feb 23 2017 22:39 UTC
I will be around for a few hours if you need a hand send me a pm @david_jobling_twitter
~ David Jobling
@david_jobling_twitter
Feb 23 2017 22:39 UTC
Thanks guys
Just adding the "rules" for summary on each of the untis
easy to get lost in this!
~ David Jobling
@david_jobling_twitter
Feb 23 2017 23:05 UTC
Updated Beastclaw Raiders - my first attempt at updating the data so would appreciate any feedback you have