These are chat archives for BSData/warhammer-age-of-sigmar

10th
May 2018
Rick Weyrauch
@rweyrauch
May 10 2018 01:35
@OftKilted Where should the battle traits show up? Under the general? The battle traits for other factions show up under the allegiance (Tzeentch for example).
OftKilted
@OftKilted
May 10 2018 02:07
So ... I'm actually working on the same file as you. LOL
Battle Traits should be showing up under Allegiance, because they aren't something that comes from the General, they come from the Allegiance.
So, Command Traits (for Tzeentch) were under the General.
Rick Weyrauch
@rweyrauch
May 10 2018 02:08
@OftKilted I get out of Khorne. I guess I do not understand the problem then.
OftKilted
@OftKilted
May 10 2018 02:08
I've moved them to root of the Unit ... because that seems easier to find.
Okay, open up the Khorne file.
to create a roster
Rick Weyrauch
@rweyrauch
May 10 2018 02:09
Done
OftKilted
@OftKilted
May 10 2018 02:09
Ensure that you have 'Allegiance Khorne' selected
and view the roster.
Rick Weyrauch
@rweyrauch
May 10 2018 02:10
Done and done.
OftKilted
@OftKilted
May 10 2018 02:10
If you notice, the Battle Trait is there under allegiance
Along with the table
Okay, change the allegiance to 'CHAOS'
Rick Weyrauch
@rweyrauch
May 10 2018 02:10
Yep. Where should they be.
OftKilted
@OftKilted
May 10 2018 02:10
Poof. gone
Unless you fixed #326 yesterday
That issue doesn't appear to be one?
For #348 add an ally list, of Khorne
Rick Weyrauch
@rweyrauch
May 10 2018 02:12
If I select Chaos allegiance, the BftBG! battle trait should not be available.
OftKilted
@OftKilted
May 10 2018 02:13
Correct, it's a KHORNE army Battle trait
a CHAOS army isn't a KHORNE army.
Rick Weyrauch
@rweyrauch
May 10 2018 02:14
So whats the bug? The battle trait is removed when you select the Chaos allegiance.
Is the problem when you ally in the Khorne?
OftKilted
@OftKilted
May 10 2018 02:14
No idea for #326
For #348 add an allied force of KHORNE
Add an Aspiring Deathbringer as an Allied leader
You can select the Aspiring Deathbringer Leader as a General.
Allies can't be generals.
(Unless they're one of the Malign Portent Harbingers)
Rick Weyrauch
@rweyrauch
May 10 2018 02:15
Ok. I'll take a look at when Khorne are allied in. The Khorne General is broken. It is not checking for Allies.
OftKilted
@OftKilted
May 10 2018 02:16
I've actually got a proposed solution for the KHORNE catalog.
And you can jump into something else if you'd like.
Rick Weyrauch
@rweyrauch
May 10 2018 02:17
If you have a fix for Khorne, I'll go find another bug to fix.
OftKilted
@OftKilted
May 10 2018 02:17
:+1:
tekton
@tekton
May 10 2018 02:17
I thought we weren't doing battalions yet?
OftKilted
@OftKilted
May 10 2018 02:17
Did you add in the BftBG table?
In regards to?
Which issue?
tekton
@tekton
May 10 2018 02:18
just as in general question, i see a bunch of e-mails about it with destruction is all; still on myphone just taking a break at work
Rick Weyrauch
@rweyrauch
May 10 2018 02:18
The BftBG table was added to fix #326.
OftKilted
@OftKilted
May 10 2018 02:18
Ahh. The issue with the battalions was that there was no profile
And/or no descriptor of what the battalion requirements are.
tekton
@tekton
May 10 2018 02:19
are we requiring them for release or just an issue to track it for later?
OftKilted
@OftKilted
May 10 2018 02:19
If you want, we can do the validation. (it's actually relatively easy)
Nope, not requiring battalion validation.
tekton
@tekton
May 10 2018 02:20
kk
OftKilted
@OftKilted
May 10 2018 02:20
We should have the profiles
and what the battalion requires
If you want to do the battalion validation, you can use Skaven as an example.
Tzeentch and Legions of Nagash are also valid. but somewhat more complicated in execution.
tekton
@tekton
May 10 2018 02:21
i started it in one, just had to stop due to work- will have more time this weekend after doctors visits the next couple days
OftKilted
@OftKilted
May 10 2018 02:21
No worries.
We're in the QA phase, and going through all the catalogs to avoid basic issues.
Ive got a list of 'things to check' in the Projects
QA Items to check for:
  • Are weapons configured with SEs?
  • Are the KEYWORDS on the unit?
  • Are Command Traits hiding when the unit isn't a General?
  • Are Allegiance specific Battle Traits (such as Command Traits and Artefacts) hiding when the Grand Alliance is selected?
  • Ensure a HERO unit can take only one Artefact?
  • Are Battleline and Battlefield Roles correct?
  • Are the Points Correct?
  • Are the profiles filled out?
  • Are Battalions with Point Values missing?
OftKilted
@OftKilted
May 10 2018 02:31
@tekton So to clarify, Battalion Abilities and a list of units required for the battalion IS required.
validating that the necessary units are in the battalion after the user selects the battalion in the roster are NOT required
So, while Battalion validation isn't required ... having it isn't a bad thing.
@rweyrauch I'd done a 'work-around' for that issue in the Tzeentch catalog.
tekton
@tekton
May 10 2018 02:36
ok
OftKilted
@OftKilted
May 10 2018 02:37
Root Battalion cost was set to 0. I'd created an SE (blank) Min1/Max1 with the name of the battalion in it and put the cost of the battalion there, and then added the units required into the appropriate SSEG that was labeled for the unit name.
(The units are a copy of the RSE with the Leader/Battleine/other listing.)
For units that can be battle line, the SSEG basically has both the Battleline and the Other version both in there .. and no 'default entry'
If there is only one option (i.e. leader, or other) then the SSEG has the unit selected as the default choice.
Adding in the 'default selections' or min1/max1 with only one default unit choice and the default selected is what causes points to 'look odd'
OftKilted
@OftKilted
May 10 2018 02:42
On that note, I'll catch everyone on the flip side :)
tekton
@tekton
May 10 2018 03:30
As silly as I feel about those few that got through, I guess it's not THAT bad considering how many units there are
ork-k, PR opened for those few
OftKilted
@OftKilted
May 10 2018 16:36
@rweyrauch As a “heads-up” I’m not opposed to having the command traits outside of the “General” SE.
It makes implementation of battleline-if X General, and the requirement to ‘hide if General is Named character’ easier.
The Pro for doing it separately is that it is ‘easier’ to see on mobile.
@/all Thoughts on putting the “Command Traits” under the SE for ‘General’ vs Adding a Command Trait as a separate linked SSEG? (Before we get too far down one road or another.)
Iain Launchbury
@Mad-Spy
May 10 2018 17:00
I'm for separate. As you say, it makes for better UX.
OftKilted
@OftKilted
May 10 2018 17:08
@FreylisUK @rweyrauch What are your thoughts on where to put the Command Traits? (Before we go down a road of completely redoing stuff.)
(I also don't relish 'busy-work')
@alphalas What are your thoughts on linking command traits? (Inside the SE for the General? Or at the root of the Leader unit?)
tekton
@tekton
May 10 2018 17:28
separate seems a bit easier overall
OftKilted
@OftKilted
May 10 2018 17:38
@tekton Thanks for the feedback.
tekton
@tekton
May 10 2018 17:51
keep in mind, i'm biased :P
mdtm1g14
@mdtm1g14
May 10 2018 17:52
If I remember rightly they are separate in idoneth
Iain Launchbury
@Mad-Spy
May 10 2018 18:07
Take a look at a 40k catalog. That is the implementation I would have written up if I'd got around to it. A main SSEG which contains per faction/subfaction SSEGs as needed which are hidden based on Allegiance.
And the main SSEG is hidden if the model isn't a General.
Jon Kissinger
@alphalas
May 10 2018 18:09
^this
Simon Barlow
@FreylisUK
May 10 2018 18:25
I'm for separate too.
tekton
@tekton
May 10 2018 18:36
That's what I ended up doing for destruction stuff for some reason @Mad-Spy ...
mdtm1g14
@mdtm1g14
May 10 2018 18:40
@Mad-Spy that's what I did as well
Iain Launchbury
@Mad-Spy
May 10 2018 18:48
Who didn't do it that way then, @OftKilted?
OftKilted
@OftKilted
May 10 2018 19:43
My initial implementation of command traits was to put them under the General. (Tzeentch/Skaven/Death all did it that way) #354 is an attempt to make the order catalog in line with guidelines
After working with how I did it, I’m not sold it was he right decision.
@Mad-Spy Before @rweyrauch moved too far forward on aligning the order catalogs in #354 with my (potentially not optimal and done in a vacuum) solution I wanted to make sure we were all in alignment of a solution. (Of which, after playing with my solution don’t think that it is the best from a UX perspective.)
OftKilted
@OftKilted
May 10 2018 19:48
IE just because my solution is technically acceptable, doesn’t mean that we should use it if a more community focused solution is better.
Right now, it’s the challenge that the guidelines/recommendations of how to do stuff are behind what our current practices are.
@Mad-Spy I did the SSEG with all of the options and then hid them based on what the Allegiance is.
But, for the Command Traits, instead of linking them at the Unit root level. I linked it at the SE for the General. (And then did a Hide on the Command Trait If the Unit was a Named character)
OftKilted
@OftKilted
May 10 2018 19:54
So, in mobile, and on desktop you select “general” and then have to select the now bolded “General” item to get to the available command traits.
Iain Launchbury
@Mad-Spy
May 10 2018 19:54
Yeah, it's not the greatest for mobile. I have similar problems with some options in the 40k Chaos cats.
OftKilted
@OftKilted
May 10 2018 19:55
Right. #354 is proposing to move to that (ie my implementation)
Iain Launchbury
@Mad-Spy
May 10 2018 19:56
until @rweyrauch turns up, we won't know how exactly how far he's got with doing it that way.
OftKilted
@OftKilted
May 10 2018 19:57
Before we go too far, make sure that we have a solid consensus from our community catalog implementers. Especially as in working with my testing it hasn’t proven to be optimal.
It works. It just doesn’t seem to be good on mobile.
Iain Launchbury
@Mad-Spy
May 10 2018 19:58
I think by the sound of it we should do it separately. I'll try and knock something up into the guidelines tonight.
OftKilted
@OftKilted
May 10 2018 20:08

Here’s some stuff that we want to add into the QA piece:
I’ve got a list of 'things to check' in the Projects
https://github.com/BSData/warhammer-age-of-sigmar/projects/1

QA Items to check for:

  • Are weapons configured with SEs?
  • Are the KEYWORDS on the unit?
  • Are Command Traits hiding when the unit isn't a General?
  • Are Allegiance specific Battle Traits (such as Command Traits and Artefacts) hiding when the Grand Alliance is selected?
  • Ensure a HERO unit can take only one Artefact?
  • Are Battleline and Battlefield Roles correct?
  • Are the Points Correct?
  • Are the profiles filled out?
  • Are Battalions with Point Values missing?
Iain Launchbury
@Mad-Spy
May 10 2018 20:13
Did you say that Skaven has the hiding of Allegiance Trait SSEGs implemented?
Don't worry, found it
Iain Launchbury
@Mad-Spy
May 10 2018 20:22
OftKilted
@OftKilted
May 10 2018 21:05
Hiding Allegiance traits basically involves adding a Hide if “Anything not in the Allegiance is selected (including both command traits and Artefacts)”
Is selected
It has to be done for all
Battle Traits. So it’s line intensive. :(
@Mad-Spy The last Hide section with the ancestor linking isn’t required if we’re not putting it into the General SSE. And we probably want to identify that the Chaos Allegiance traits have the same functionality for Hide needed
It is the same for the Artefacts listing as well
(Though, I may be over-engineering my Hide if Allies for those)
OftKilted
@OftKilted
May 10 2018 21:10
(Basically the Artefact SSEG needs the same treatment as the Command Traits)
SSEG
Rick Weyrauch
@rweyrauch
May 10 2018 22:20
@/all I've turned up. Travelling this week. I started making the Command Trait/General changes a week or so ago. At one point this item came up in this gitter feed. So I started changing the way I had been doing Command Trait/General.
I can revert/repair the changes if that is needed. The changes are pretty small and not too difficult to restore the previous implementation.
OftKilted
@OftKilted
May 10 2018 22:24
@oftkilted waves to @rweyrauch
Rick Weyrauch
@rweyrauch
May 10 2018 22:25
@/all Have a bit of time now. Missed my flight.
OftKilted
@OftKilted
May 10 2018 22:26
Uffffff .... well. At least you get an opportunity to spend more time attempting to find reasonably priced adult beverages of choice before entering the flying aluminum cans with wings.
Rick Weyrauch
@rweyrauch
May 10 2018 22:26
I see the guidelines have been updated. I'll read the updated guidelines and repair the damage.
@OftKilted I am not sure a reasonable price exists an airport any longer (if ever).
OftKilted
@OftKilted
May 10 2018 22:29
As a 'heads up' Artefact SSEGs should be done the same way as the Command Trait SSEGs to make it work properly.
Rick Weyrauch
@rweyrauch
May 10 2018 22:29
My original implementation used the 'correct' way. Somewhere along the line I got derailed. :)
OftKilted
@OftKilted
May 10 2018 22:31
Artefacts-SSEG.png
That's an example of my Artifact SSEG from Tzeentch
CommandTrait-SSEG.png
That's my example for Command Trait SSEG from Tzeentch
OftKilted
@OftKilted
May 10 2018 23:34
@Mad-Spy I’m in the process updating the implementation guidelines for RSEs