These are chat archives for BSData/wh40k

6th
May 2016
that's what I got. You have to paste ids of some characteristics, I haven't had time to proof it works, will try in the evening.
OftKilted
@OftKilted
May 06 2016 12:03
Nice!
Troy Graber
@tag8833
May 06 2016 15:01
I committed my 1st changes to the Ork datafile. I can see it over there on the right. Is there anything else I need to do? I assume it will be batched with a number of other updates for a release, right?
penguin20000
@penguin20000
May 06 2016 15:02
Yep :)
OftKilted
@OftKilted
May 06 2016 15:03
So, recommended best practice is to do a pull request after doing a branch from the master
We also recommend that any work done have a ticket to track
Troy Graber
@tag8833
May 06 2016 15:04
By Ticket you mean an entry on the issue list?
OftKilted
@OftKilted
May 06 2016 15:05
Yes, and by working on a branch, not the master it makes it easier and potentially less impact.
Troy Graber
@tag8833
May 06 2016 15:07
I'm new to this github thing. I was thinking that branching would just make it harder to recombine.
OftKilted
@OftKilted
May 06 2016 15:09
Nope, you create your branch, work your branch and then do a pull request to merge
I'd recommend going over the github tutorial that demonstrates it. :)
Troy Graber
@tag8833
May 06 2016 15:10
Yeah I went through the tutorial.
I was basing my workflow off the developer guide which doesn't mention branching: https://github.com/BSData/bsdata/wiki/Developer-Guide My mistake.
OftKilted
@OftKilted
May 06 2016 15:11
So, you do your branch, and label your branch (typically) with what you're fixing
Troy Graber
@tag8833
May 06 2016 15:12
If I tag branch with an issue # does it update the issue at all?
OftKilted
@OftKilted
May 06 2016 15:12
Nominally that works, the github tutorial talks about using branches and pulling back into the repositiry.
Yep!
Troy Graber
@tag8833
May 06 2016 15:13
I know how to do a pull request, and that it is supposed to merge a branch with the master, but how does it resolve potential conflicts? One file at a time, or does it itemize specific changes?
OftKilted
@OftKilted
May 06 2016 15:13
#1866 is an example of one
In a best case scenario, the only potential conflicts are the changes you've made because you created your branch, and you're the only person working on your catalog
Troy Graber
@tag8833
May 06 2016 15:15
Is this the update that gets added when a branch is created: Update to Add Questoris Knight Porphyrion
OftKilted
@OftKilted
May 06 2016 15:15
It's part of the process.
Troy Graber
@tag8833
May 06 2016 15:16
Sure.
OftKilted
@OftKilted
May 06 2016 15:16
So #1866 was my pull request
merged 1 commit into master from Imperial-Knight-Porphyrion
The branch I made was 'Imperial-Knight-Porphyrion'
Troy Graber
@tag8833
May 06 2016 15:17
OK.
OftKilted
@OftKilted
May 06 2016 15:18
When I completed the work, I submitted it as a pull request (following the github tutorial in the github app) as there were no conflicts it merged just fine.
So, you submit the pull request, and the pull request lets you know if there any conflicts with the master
Troy Graber
@tag8833
May 06 2016 15:18
So, since I didn't follow correct procedure this time is there anything I need to do to clean it up. Should I create a ticket for the work I did? I did the work based off this ticket: #2133
OftKilted
@OftKilted
May 06 2016 15:18
If there are no conflicts between that and the master, then you can merge the pull.
No ... you're fine
cartag
@cartag
May 06 2016 15:19
@tag8833 you're good
OftKilted
@OftKilted
May 06 2016 15:19
This isn't a 'you did something wrong' this is just a discussion on best practices :)
Troy Graber
@tag8833
May 06 2016 15:19
Definitely. I get it.
OftKilted
@OftKilted
May 06 2016 15:19
Cartag for example runs fast and loose and basically does the same thing you did.
Troy Graber
@tag8833
May 06 2016 15:20
Branching doesn't threaten me at all, I'll do it in the future.
cartag
@cartag
May 06 2016 15:21
My stance being I know what I'm doing, I'm the only one working on my data files, and I keep meticulous details on what I change.
not that you don't know what you're doing
OftKilted
@OftKilted
May 06 2016 15:22
it has the potential to help, especially if we have multiple people who happen to end up (for whatever reason) to be working on the same data file.
Troy Graber
@tag8833
May 06 2016 15:23
So in the join request (#2133), afraeve gave me a little list of todo items for the Ork file. Should I create tickets for those items now, or not until I start work on them?
OftKilted
@OftKilted
May 06 2016 15:23
The only caveat is that you have to remember to remove your branch when you're done. Or @amis92 puts poignant reminders in your tickets.
if there aren't tickets for those issues, it is never a bad idea to have one created.
cartag
@cartag
May 06 2016 15:24
Personally I'd just reference back to #2133 with the fix, but I'm irresponsible :)
OftKilted
@OftKilted
May 06 2016 15:24
that way we can reference the fixes later if needed
cartag
@cartag
May 06 2016 15:24
Can reference fixes also by going to #2133 :P
OftKilted
@OftKilted
May 06 2016 15:24
this is true @cartag
None of us are paid, this is all volunteer. We're a bunch of 'free spirits' for the most part. Not quite like dealing with a herd of cats ... but we're all cats with the same idea in mind. Improve what the community of users (as a whole) has available to use.
We just often have different ideas on how to solve a particular issue.
And occasionally there are in-depth discussions on what a particular rule means. So ... we do some interpretation of the codexes when we get to ... potential conflicts.
Troy Graber
@tag8833
May 06 2016 15:29
I'm onboard with all that. No problems on my end.
OftKilted
@OftKilted
May 06 2016 15:30
We do 'official faqs' only (not tournament)
And 'emails from GW' aren't faqs.
Neither are 'emails from Forgeworld'
Ivan Milanov
@SuperPranx
May 06 2016 15:32
Things should all be clear when they finish up the huge FAQ they're cleaning up atm
Troy Graber
@tag8833
May 06 2016 15:32
LOL
OftKilted
@OftKilted
May 06 2016 15:32
@SuperPranx LOL cough
I'll believe that when I see it.
'Things should be all complicated when they finish up the huge FAW they're cleaning up atm' Fixed that for you
Ivan Milanov
@SuperPranx
May 06 2016 15:33
Well, 'all' might have been an exaggeration on my part :D
OftKilted
@OftKilted
May 06 2016 15:33
Or at least no less complicated than usual.
Ivan Milanov
@SuperPranx
May 06 2016 15:33
Hahahah, thanks :D
Troy Graber
@tag8833
May 06 2016 15:34
I'm really exited about the FAQ, and it will no-doubt resolve some issues, but there will always be more where they came from.
OftKilted
@OftKilted
May 06 2016 15:36
I'm interested to see where AoS goes. Adding back points for the 'WH Fantasy' folks and people 'wanting a points balanced' game will be interesting to see. And I'm a big fan of the fantasy models.
As a side note ... anyone have any idea on how one might go about the variable damage/movement tables that exist in AoS in Battlescribe?
(completely off topic)
cartag
@cartag
May 06 2016 15:48
Shit I just realized I better start on Khorne bloodbound for aos done it's getting points
cartag
@cartag
May 06 2016 16:03
That'll be after work. Oh yeah, I got a job!
OftKilted
@OftKilted
May 06 2016 16:08
Nice! That's awesome!
The one you told us about that you applied to?
cartag
@cartag
May 06 2016 16:09
No, nothing that awesome. This is a shitty call center job I am WAY over qualified for
OftKilted
@OftKilted
May 06 2016 16:11
It's a job :+1:
penguin20000
@penguin20000
May 06 2016 16:11
+1
OftKilted
@OftKilted
May 06 2016 16:11
And that is awesome in and of itself :) ++good
cartag
@cartag
May 06 2016 16:14
I just hope I don't have another bread flown in six months
Breakdown
Decrementis
@Decrementis
May 06 2016 19:12
Hello Guys - anyone able to help an utter Github noob havgin a headache?
OftKilted
@OftKilted
May 06 2016 19:13
What is the question?
Decrementis
@Decrementis
May 06 2016 19:13
I have been trying to get the 40k datafiles
I have downloaded github as instructed
got the datafile repos to that
but still can't get it into battlescribe
appear to be going in circles
OftKilted
@OftKilted
May 06 2016 19:15
So, are you trying to edit files? Or just use them?
Decrementis
@Decrementis
May 06 2016 19:15
use them
formatted pc, reinstalled battlescribe and the process has changed
OftKilted
@OftKilted
May 06 2016 19:16
Ahh. You don't need github to just use the data files.
Decrementis
@Decrementis
May 06 2016 19:16
used to just copy a url
OftKilted
@OftKilted
May 06 2016 19:16
You still do just copy a url
Unless you're trying to be a catalog editor :-)
Decrementis
@Decrementis
May 06 2016 19:16
https://github.com/BSData/wh40k doesn't appear to do anything when I click update data
nope just want the data
OftKilted
@OftKilted
May 06 2016 19:17
What you want is the link here: http://battlescribedata.appspot.com/#/repo/wh40k
the URL (for the full 40K BSI file is here) http://battlescribedata.appspot.com/repos/wh40k/index.bsi
Decrementis
@Decrementis
May 06 2016 19:18
Ty
OftKilted
@OftKilted
May 06 2016 19:18
Glad to help!
Decrementis
@Decrementis
May 06 2016 19:18
that appears to be working, appreciate the guidance :)
that's taken me 2 days! - ffs haha
thanks again, working now
OftKilted
@OftKilted
May 06 2016 19:18
No worries, please remember to report any issues, and we'll work on getting them fixed :)
Decrementis
@Decrementis
May 06 2016 19:19
cool - ty
Amadeusz Sadowski
@amis92
May 06 2016 19:38
um... @cartag @OftKilted do we have an issue already for the flyer upgrade? I can't seem to find one. And @cartag, what was that you were doing on your branch?
Or was that @capitaladot ? Sorry guys
OftKilted
@OftKilted
May 06 2016 19:41
I'
I'm not entirely sure that we have an open issue.
More that @cartag has been working on moving stuff forward.
Amadeusz Sadowski
@amis92
May 06 2016 19:41
Ahh and what was that with his branch?
OftKilted
@OftKilted
May 06 2016 19:41
the branch we have is prep work for Battlescribe 2.0 files
Amadeusz Sadowski
@amis92
May 06 2016 19:42
That!
OftKilted
@OftKilted
May 06 2016 19:42
Not sure there's an actual ticket for that either.
Amadeusz Sadowski
@amis92
May 06 2016 19:42
Well I'm not convinced we should by now, it's a long time still, I guess.
OftKilted
@OftKilted
May 06 2016 19:42
bs2prep == battlescribe 2.0 prep
initial work began at the point that jon indicated that it was 'really soon now' prior to the most recent rash of issues
Amadeusz Sadowski
@amis92
May 06 2016 19:44
You know how it is with software dev, it's always "soon" ;D
Well, I know for sure at least, myself being one.
OftKilted
@OftKilted
May 06 2016 19:44
Unless you're talking to an end user who spoke with the dev, who says 'Not expected any time soon'
Then it's just confusing
Amadeusz Sadowski
@amis92
May 06 2016 19:45
:D
OftKilted
@OftKilted
May 06 2016 19:45
So, I'm staring at AoS ... (Yes, I know it's not 40K) and pondering how to do the 'variable move/damage' tables in Battlescribe.
Any thoughts?
(Are you familiar with them?)
e.g. Attacks/Move/Hit for the weapons vary, depending on the number of wounds taken by the model.
It also isn't for every model like that
Amadeusz Sadowski
@amis92
May 06 2016 21:24
Ok so I've opened #2140 for this flyer thing, will keep it updated with progress and I invite any critique - better before I commit the change :D