These are chat archives for BSData/wh40k

19th
Jul 2017
Jon Kissinger
@alphalas
Jul 19 2017 03:55
holy crap.
DO NOT RELEASE, por favor.
Wait, nevermind
i havn't pushed AM to master yet.
:shipit:
Amadeusz Sadowski
@amis92
Jul 19 2017 09:00
Okay so we're moving the Catalogue Owners into CODEOWNERS file, see https://github.com/blog/2392-introducing-code-owners - it'll request reviews from owners automatically! :sparkles:
CloverFox
@CloverFox
Jul 19 2017 09:04
oo that looks nice
Iain Launchbury
@Mad-Spy
Jul 19 2017 09:07
shiny!
Simon Porter
@FarseerVeraenthis
Jul 19 2017 09:11
Very flashy!!
penguin20000
@penguin20000
Jul 19 2017 09:19
fancy
Amadeusz Sadowski
@amis92
Jul 19 2017 09:32

There it is! https://github.com/BSData/wh40k/blob/master/.github/CODEOWNERS

I've gone a little lazy for Imperium, sorry - I hope it's not a big problem for you "Generic Imperium" guys

Will Pattison
@GenWilhelm
Jul 19 2017 09:33
why are some of them in quotes, but others arent?
CloverFox
@CloverFox
Jul 19 2017 09:34
spaces in names means you need quotes
Will Pattison
@GenWilhelm
Jul 19 2017 09:35
ah, that makes sense
Iain Launchbury
@Mad-Spy
Jul 19 2017 09:52
ooh, I feel all official now.
Amadeusz Sadowski
@amis92
Jul 19 2017 09:52
I've invited active maintainers who were not already members of Data Authors for 40k, which is @tekton @ilaunchbury and @USSX-Hares
Iain Launchbury
@Mad-Spy
Jul 19 2017 09:54
tyvm
Amadeusz Sadowski
@amis92
Jul 19 2017 09:56

I'm not sure as to if @CrusherJoe maintains DKOK, I think I'll just give it more time, and that'll be all I think for now.

If anyone feels like updating that CODEOWNERS to be exactly as granular for Imperium as wiki, feel free :)

Will Pattison
@GenWilhelm
Jul 19 2017 09:56
:D
something like that? :P
Amadeusz Sadowski
@amis92
Jul 19 2017 10:01

Yeah, that's why I like our community :D

Also alphalas should be all lowercase, I've got no idea if it's case sensitive so'd rather play safe

Will Pattison
@GenWilhelm
Jul 19 2017 10:03
oh yeah, i ripped it off the wiki, didnt think to check alpha
Amadeusz Sadowski
@amis92
Jul 19 2017 10:04
thought so :D
Will Pattison
@GenWilhelm
Jul 19 2017 10:05
should we put someone as the default, for repo changes?
or just deal with them as and when
Amadeusz Sadowski
@amis92
Jul 19 2017 10:05
The whole team is, first pattern
Will Pattison
@GenWilhelm
Jul 19 2017 10:06
im a fucking idiot, carry on
Amadeusz Sadowski
@amis92
Jul 19 2017 10:06
It's cool, easy to miss when every line starts with # or * :D
Iain Launchbury
@Mad-Spy
Jul 19 2017 10:16
lol @ the commit name :)
Amadeusz Sadowski
@amis92
Jul 19 2017 10:21
:cookie:
Peter Zaitcev / [USSX] Hares
@USSX-Hares
Jul 19 2017 11:12
@amis92 Thank you
Will Pattison
@GenWilhelm
Jul 19 2017 11:17
can i get a second opinion on #872?
Iain Launchbury
@Mad-Spy
Jul 19 2017 11:19
looking now
looks fine to me. Sergeant equipment is max 1 as it should be.
Are they complaining because you can select a boltgun from the list?
it's not really clear from what they've said
Will Pattison
@GenWilhelm
Jul 19 2017 11:22
currently it allows the dev sergeant to take one item from each half, in addition to his pistol.
Iain Launchbury
@Mad-Spy
Jul 19 2017 11:23
ah, I see now. I hadn't tried that. In that case it's wrong.
Will Pattison
@GenWilhelm
Jul 19 2017 11:23
which is essentially what all other sergeants are able to do, but the dev serg is worded slightly differently
Iain Launchbury
@Mad-Spy
Jul 19 2017 11:24
the dev sarge doesn't get to switch his pistol out RAW.
which every other sarge can do.
Will Pattison
@GenWilhelm
Jul 19 2017 11:25
yeah, but it still says he can take items from the list
Iain Launchbury
@Mad-Spy
Jul 19 2017 11:25
yes, but only in place of one weapon.
he can never swap out his pistol.
Will Pattison
@GenWilhelm
Jul 19 2017 11:26
but the sergeant equipment doesnt require you to exchange a weapon
Iain Launchbury
@Mad-Spy
Jul 19 2017 11:26
"The Space Marine Sergeant may replace his boltgun with items from the Sergeant Equipment list."
Will Pattison
@GenWilhelm
Jul 19 2017 11:27
yeah, so he loses the boltgun and then may take whatever he wants from the equipment list
within the restrictions of the equipment list
Iain Launchbury
@Mad-Spy
Jul 19 2017 11:28
I see what you're saying now.
Yes, the equipment list would appear to imply that he can swap his boltgun for two items, not just a single one.
I would contend that he can actually only get 1 item (as he only has 2 hands :) ) and must always keep his bolt pistol.
Will Pattison
@GenWilhelm
Jul 19 2017 11:31
TIL space marines dont have holsters :P
Iain Launchbury
@Mad-Spy
Jul 19 2017 11:31
that's right, no holsters for Dev marines.
Will Pattison
@GenWilhelm
Jul 19 2017 11:32
un-holsters grav-cannon
Iain Launchbury
@Mad-Spy
Jul 19 2017 11:32
I would also say that the implementation is currently wrong for the normal marines as they don't have their default boltgun as an option.
Will Pattison
@GenWilhelm
Jul 19 2017 11:32
you mean they dont have it selected by default?
Iain Launchbury
@Mad-Spy
Jul 19 2017 11:32
no, they don't even have the option.
Will Pattison
@GenWilhelm
Jul 19 2017 11:33
is it not in the "may pick one" section?
Iain Launchbury
@Mad-Spy
Jul 19 2017 11:33
nope
It's done weirdly if you ask me. All the Marines should be the same, with a default checkbox of "boltgun" and the option to pick a Heavy weapon.
Currently the default is a HW marine with no weapon, and optional additional boltgun marines as a separate option.
maybe I can change it and we can see if the new data owner functionality works :)
Will Pattison
@GenWilhelm
Jul 19 2017 11:37
oh i see, i thought you were talking about tactical sergeants when you said "normal marines"
Iain Launchbury
@Mad-Spy
Jul 19 2017 11:38
sorry, still taking about devastators
Will Pattison
@GenWilhelm
Jul 19 2017 11:38
yeah, i get what you mean now
i agree the devestators could be done better
Simon Porter
@FarseerVeraenthis
Jul 19 2017 11:39
also, I know we've got the flashy code owners files now, but could we still have the "easy to access" list on the Wiki still please :question:
Will Pattison
@GenWilhelm
Jul 19 2017 11:39
RIP wiki table, we hardly knew ye
Simon Porter
@FarseerVeraenthis
Jul 19 2017 11:43
:worried:
Will Pattison
@GenWilhelm
Jul 19 2017 11:44
i agree though, the wiki was much more readable
Simon Porter
@FarseerVeraenthis
Jul 19 2017 11:46
so walking dead style resurrection might be possible??
Will Pattison
@GenWilhelm
Jul 19 2017 11:46
well the whole point of version control is you can easily revert changes :P
would be easy to put it back, unless @amis92 has a reason not to
Simon Porter
@FarseerVeraenthis
Jul 19 2017 11:59
that's what I was hoping for :wink:
Iain Launchbury
@Mad-Spy
Jul 19 2017 12:11
@GenWilhelm , looking at the dev sarge in the cat. I think it's supposed to work like I expected (he can only take 1 weapon in exchange for his boltgun), but it's incrementing the max selections back up when he takes a boltgun/combi for some reason.
Will Pattison
@GenWilhelm
Jul 19 2017 12:13
to make sure you cant take 2 extra weapons from the first half
Iain Launchbury
@Mad-Spy
Jul 19 2017 12:13
I don't think your reply on #872 is right, as that's not how any of the other sergeants are implemented. They can take 2 max, but not two of the boltgun replacements.
No sergeant can take 3 weapons.
Will Pattison
@GenWilhelm
Jul 19 2017 12:14
well the devastator serg was the only one that was reported, so is the only one that was fixed
Joe Beddoe
@CrusherJoe
Jul 19 2017 12:33
Woohoo I'm official now
M4uler
@M4uler
Jul 19 2017 12:33
Grats :D
Amadeusz Sadowski
@amis92
Jul 19 2017 12:40

@FarseerVeraenthis

also, I know we've got the flashy code owners files now, but could we still have the "easy to access" list on the Wiki still please :question:

Well it's possible, but it also means we'd have two semantically same resources and rest assured it will desynchronize quickly.

Soo I need a better argument than "it looked better" :) (or a plausible solution)

Iain Launchbury
@Mad-Spy
Jul 19 2017 12:42
Perhaps we could make some teams and then link to https://github.com/orgs/BSData/teams/data-authors-wh40k/teams?
needs a maintainer to create them though
Will Pattison
@GenWilhelm
Jul 19 2017 12:47
i think what simon wanted was an easy way to reference who works on which files, so we can assign issues?
Iain Launchbury
@Mad-Spy
Jul 19 2017 12:48
yes. If we create a team for each cat, then and assign the relevant people, you can see it from that page.
Amadeusz Sadowski
@amis92
Jul 19 2017 12:55

:point_up: 16 lipca 2017 02:18
@flakpanda

Idk who does Tau, but the named ethereal is missing special rules.

I know that was very long time ago, but what did you mean by "missing"? All rules are there as far as I see.

Amadeusz Sadowski
@amis92
Jul 19 2017 13:00
Ah that. Assigning to issues. Yeah, we need to automate that - there are some bots that automatically assign issues as per OWNERS file, I'll research that topic.
Iain Launchbury
@Mad-Spy
Jul 19 2017 13:05
@GenWilhelm , you mean @farseerveraenthis can't remember who looks after which cat? :P
Amadeusz Sadowski
@amis92
Jul 19 2017 13:06

Perhaps we could make some teams and then link to https://github.com/orgs/BSData/teams/data-authors-wh40k/teams?

That's an idea. But I also don't think it's a practical one. Creating 40+ teams for one repo... I just don't feel it's good.

Will Pattison
@GenWilhelm
Jul 19 2017 13:06
okay then, without looking who does Legion of the Damned?
Iain Launchbury
@Mad-Spy
Jul 19 2017 13:06
I didn't say I could remember :)
Will Pattison
@GenWilhelm
Jul 19 2017 13:06
so we need an easy way to look it up then :P
i like the idea of auto-assigning issues, if it's easy to configure
Iain Launchbury
@Mad-Spy
Jul 19 2017 13:08
@amis92, does it need 40 teams? I only count ~25 in the data owners file.
Amadeusz Sadowski
@amis92
Jul 19 2017 13:08
And that is why it's less readable, because it doesn't list every single cat separately.
Iain Launchbury
@Mad-Spy
Jul 19 2017 13:09
I'm happy to have a go at implementing something if you give me maintainer temporarily. If we don't like it, we can try something else.
Amadeusz Sadowski
@amis92
Jul 19 2017 13:11
Let's wait for @FarseerVeraenthis to specify what exactly is needed in his opinion. Because a team per cat (whereas mostly a team will be a single user) is just... You know. One man is not a team :)
Simon Porter
@FarseerVeraenthis
Jul 19 2017 13:13
A quick reference to make assigning issues easier, since I don't manage to remember who does all the different cats... Auto assign based on the OWNERS file would be awesome :smile:
Basically, I had to "un-follow" the repo because my emails were exploding, but the risk is missing issues I should be working on...
That might not be the case for everyone, but I think it's good practice to assign people to issues, and this makes it easier to follow the issues without email whiteout
Amadeusz Sadowski
@amis92
Jul 19 2017 13:23
Oh you can just remove the mail notifications for not-participating issues and still have them in web view.
Zrzut ekranu 2017-07-19 o 15.22.07.png
Jon Kissinger
@alphalas
Jul 19 2017 13:38
@amis92 code owners thing looks bueno
If autoasign could be a thing that's even more Bueno
Iain Launchbury
@Mad-Spy
Jul 19 2017 13:41
do you want me to try doing the teams thing?
@amis92 , one man can be a team. I'm a one-man team right now :)
Will Pattison
@GenWilhelm
Jul 19 2017 13:43
how does that saying go... there's no "one man" in team. yeah i think thats it
Iain Launchbury
@Mad-Spy
Jul 19 2017 13:53
There may be no "I" in team, but there's "me" if you look hard :)
Price Van-Saint
@sk_Father_Price_twitter
Jul 19 2017 13:55
if you go by my old Sergeant Majors view ... "There's No 'F' in Team, either!!!"
now get up that hill
drop n gimme 50 ...
etc.
Will Pattison
@GenWilhelm
Jul 19 2017 14:00
"the only i in TEAM is the a-hole" is another good one
M4uler
@M4uler
Jul 19 2017 14:30
Hahaha
Simon Porter
@FarseerVeraenthis
Jul 19 2017 14:45
@amis92 that's cool, but unless you have all new notifications on, and then go in to switch them off individually when each issue is listed you have no idea what's going on unless someone mentions (or assigns) you... hence the idea behind "auto assign" then you only get targeted notifications for CAT's you maintain
Iain Launchbury
@Mad-Spy
Jul 19 2017 15:00
That is awesome!
flakpanda
@flakpanda
Jul 19 2017 15:06
@GenWilhelm did you change the dev sgt because of #872?
Will Pattison
@GenWilhelm
Jul 19 2017 15:09
nope, it was a while ago when somebody asked why they couldnt take a combi-weapon and power fist on the dev sarge, despite it being a legal choice
Iain Launchbury
@Mad-Spy
Jul 19 2017 15:11
I'm still not convinced that it is.
but I don't expect we'll ever get it FAQed
M4uler
@M4uler
Jul 19 2017 15:48
Ahhh I see what you mean
It's Two two from here or one from here
Will Pattison
@GenWilhelm
Jul 19 2017 15:56
there's no "or" involved though. it just says max 2 from these:... max 1 from theses:...
Jon Kissinger
@alphalas
Jul 19 2017 15:58
Ok to completely derail the conversation: tau list question.
In a list with 4 mech'd squads and 2 tetras - longstrike, railhead, heavy burst cannon head, 3 heavy gun drones and a piranha; or; longstrike, HBC head, and 2 railheads?
Will Pattison
@GenWilhelm
Jul 19 2017 16:06
probably the second railhead to get the most out of longstrike
that's gonna be a cramped deployment though
M4uler
@M4uler
Jul 19 2017 16:07
Tanks 4tw so Hammerheads here too
Amadeusz Sadowski
@amis92
Jul 19 2017 16:12
... derail ...
... railheads ...
Jon Kissinger
@alphalas
Jul 19 2017 16:20
It worth sacrificing pretty much all my seeker missiles for an ionhead instead of a second railhead?
Will Pattison
@GenWilhelm
Jul 19 2017 16:22
is ion any good?
seems like its only better against quite specific targets
Jon Kissinger
@alphalas
Jul 19 2017 16:27
It's slightly better then the submunitions of the railhead
Penallegion
@Penallegion
Jul 19 2017 17:49
Hi can i have someone test #831 i can't seem to replicate the described error
WindstormSCR
@WindstormSCR
Jul 19 2017 17:50
looks like collective flagging
Penallegion
@Penallegion
Jul 19 2017 17:50
yeah but i don't get the error
WindstormSCR
@WindstormSCR
Jul 19 2017 17:50
since if you put a collective entry under a unit but not a model, al UNITS must have the same selection and number of selections
Penallegion
@Penallegion
Jul 19 2017 17:50
soooo
ahhh
WindstormSCR
@WindstormSCR
Jul 19 2017 17:51
its why I don't use collective flagging hardly at all in the mobile set
unless its default weapons for models that will never change
eg. aspect warriors
Penallegion
@Penallegion
Jul 19 2017 17:51
there it was
Austin C.
@capitaladot
Jul 19 2017 19:27
Any of you guys diagnosed a problem with a catz file timing out opening/creating a force on Windows (with low memory) and iOS?
Will Pattison
@GenWilhelm
Jul 19 2017 19:28
that was an issue for SM/CSM/SW in the 7th edition files
took multiple passes of optimisation to get it mostly consistent again (at least for SW)
Austin C.
@capitaladot
Jul 19 2017 19:36
What sorts of optimization were effective?
Will Pattison
@GenWilhelm
Jul 19 2017 19:37
for SW the main problem was massive amounts of duplication
every formation had it own snowflake variant of a codex unit
Austin C.
@capitaladot
Jul 19 2017 19:46
We don't have much if any duplication... Just a raft of modifiers on every unit to confer special rules.
Will Pattison
@GenWilhelm
Jul 19 2017 20:59
is it possible to break it down into smaller factions, or is it literally a case of anyone from this faction can bring anything
Jon Kissinger
@alphalas
Jul 19 2017 21:03
^this
WindstormSCR
@WindstormSCR
Jul 19 2017 21:12
Since I play HH, I'd hazard a guess the bloat is because of rites of war changing unit type, and every unit having different special rules fore each of the 18 legions