Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Oct 16 04:33
    loic-sharma opened #699
  • Oct 16 04:23

    loic-sharma on refactor-package-service

    Work (compare)

  • Oct 15 04:09

    loic-sharma on refactor-package-service

    Start Convert (compare)

  • Oct 15 04:01
    loic-sharma synchronize #694
  • Oct 15 04:01

    loic-sharma on v2

    Start Push more logic to mirro… (compare)

  • Oct 15 03:57

    loic-sharma on search-builder

    (compare)

  • Oct 15 03:57

    loic-sharma on main

    Add search response builder abs… (compare)

  • Oct 15 03:57
    loic-sharma closed #698
  • Oct 15 03:49
    loic-sharma edited #698
  • Oct 15 03:47
    loic-sharma synchronize #698
  • Oct 15 03:47

    loic-sharma on search-builder

    Undo (compare)

  • Oct 15 03:43
    loic-sharma opened #698
  • Oct 15 03:41

    loic-sharma on search-builder

    Add search response builder abs… (compare)

  • Oct 15 03:26
    loic-sharma synchronize #694
  • Oct 15 03:26

    loic-sharma on v2

    Clean (compare)

  • Oct 05 18:18
    queil closed #484
  • Oct 04 20:51
    jrichardsz opened #697
  • Oct 03 19:18
    loic-sharma synchronize #694
  • Oct 03 19:18

    loic-sharma on v2

    Refactor Azure Table search (compare)

  • Oct 03 18:32
    loic-sharma synchronize #694
Loïc Sharma
@loic-sharma
I'm not familiar with psgallery. What do you need for that? The OData/v2 APIs? Is there more?
Serhii Kuzmychov
@ku3mich
Only time all I need, as I said it can be taken grom nuget.server sources, it will be a bunch of controllers that will be refined in way of use Baget Service layer instead of own
Loïc Sharma
@loic-sharma
Okay. By the way, Mizipor started working on adding V2 support here: https://github.com/loic-sharma/BaGet/pull/178/files
I haven't had a change to test their changes yet, but it looks like it's nearly ready
Serhii Kuzmychov
@ku3mich
Thanks, will keep in mind
Michael Bisbjerg
@LordMike
Poke @loic-sharma
Loïc Sharma
@loic-sharma
Hey @LordMike, how's it going?
I wanted to ask you how you envision the code search feature to work. Do you envision a new page that returns all results from all packages?
What would the results look like?
Michael Bisbjerg
@LordMike

I imagined two aspects, visually:

  • On a package version page, you can go to sources (like going to source project or company site)
  • A search where you could search for combinations of a text (type names, method names, property names, ..), latest version / all versions, whether to search in Types, Properties, Members, .. etc.

Notes:

  • I imagine only one version from each package should be searched at any time, 200 hits of "TimeHelper" is not useful.
Once on the "view source" part (not related to search results), you'd be able to pick a version of the package, and you'd see a kind of tree view of namespaces, types and members.
Michael Bisbjerg
@LordMike
Essentially, two seperate pages.
Search results would link to a specific type / member on the "view source" pages.
Loïc Sharma
@loic-sharma
Okay that makes sense
I’m really liking the Roslyn source browser. I think that indexing all of NuGet.org using that would be a huge win for the community
I want to make sure that whatever solution we go with works for both small and large feeds
Michael Bisbjerg
@LordMike
I would go for this then:
  • On upload, the package is indexed with all types / members, for search
    • It will contain stuff like: Name, Type Name (containing type), Type of member (Property, ..), Full Name, Documentation if possible
  • On first view of the source code (linked from a search result, or by the user visiting "show sources"), the Source pages are generated using the Roslyn thingamajig.
This way, we don't generate humongous unecessary source code dumps for packages that will never be viewed (I'm thinking of CI output here), while still maintaining a bare minimum for searching.
It should be that you can use the search page and find types or members, without every viewing the source pages, ie. it should be possible to get what you need from the search alone.. An "ah, that's the name I was looking for" result.. :)
Soier646
@Soier646
Hi. Is there are any way to use address like: http://localhost:5000/subfolder/ instead of http://localhost:5000
Loïc Sharma
@loic-sharma
Hey @Soier646, you can but it's not very easy. You should be able to set the PathBaseconfiguration to "subfolder"
I think the UI will be broken though...
Serhii Kuzmychov
@ku3mich

I think the UI will be broken though

no, if properly set up the "homepage": "." setting in package.json

thoscut
@thoscut
Hi, I was wondering what's the reason for MultipartBodyLengthLimit beeing set to int.MaxValue instead of int64.MaxValue as this seems to limit the max package size to about 2GB?
Loïc Sharma
@loic-sharma
Oh that’s a good question
I think that’s just because no one has tried to upload a package that was bigger than 2gigs yet :g
:) *
Do you need to increase the max value?
thoscut
@thoscut
That would be great, I have a 10gb file
There has been already an issue on this topic (loic-sharma/BaGet#191)
thoscut
@thoscut
I validated that an change to 20gb is working. The file was put fine.
Ashkan Rahmani
@ashkanRmk
Hi every body!
Is there any news about when does private feed branch release?
Ashkan Rahmani
@ashkanRmk
Is there anybody to answer me?!!
Loïc Sharma
@loic-sharma
Hey, I haven’t had a chance to work on the private feed branch
It’s still something I’d like to do!
Ashkan Rahmani
@ashkanRmk
what's the best (free) solution to have a private feed? because it's very essential...
Loïc Sharma
@loic-sharma
There are none as far as I’m aware
Ashkan Rahmani
@ashkanRmk
:/
how about github package registry?
is that a good solution?
Loïc Sharma
@loic-sharma
Ah it looks like GitHub’s package registry lets you do private feeds for free actually. I haven’t tried it myself, so I don’t know if it’s any good
If you try it, I’d love to hear what you think of it
Ashkan Rahmani
@ashkanRmk
I will try it and tell you about it...
thanks a lot for your help
Loïc Sharma
@loic-sharma
Yup of course :smile:
Aurélien
@adhermy
Hi :)
I am trying to implement Baget at work, so far it works on our kubernetes cluster using PersistanVolumeClaim but for cost i would like to use GCS. I saw on your doc that it's possible, but i tried stuff and it doesn't work. First i don't see any use of the baget.env values in the container.
Is there something that catches the env values to write them up on appsettings.json? because nothing seems to moves even though the env values are correctly updated.
Loïc Sharma
@loic-sharma
Hey @adhermy, the default ASP.NET Core configuration system reads configs from command line arguments, environment variables, and the appsettings.json file. See this documentation: https://docs.microsoft.com/en-us/aspnet/core/fundamentals/configuration/?view=aspnetcore-2.2#default-configuration