These are chat archives for BinPy/BinPy

27th
May 2014
Salil Kapur
@salilkapur
May 27 2014 09:37
Regarding the pull requests,
We should try to break them into smaller patches. @rvraghav93 Just don't keep working on your local repo. Keep sending small PRs. It is easier that way.
And also we should explain the PRs properly. There is no explanation of what the PR does. One has really go through the code to understand. We can also include a small demo of how the PR will be used.
Let us try to follow this now onwards.
Sudhanshu Mishra
@debugger22
May 27 2014 11:13
:+1:
Salil Kapur
@salilkapur
May 27 2014 11:23
Can we use pep8 test as just a "warning" and not a "build fail"?
Sudhanshu Mishra
@debugger22
May 27 2014 11:23
What difference will it make?
Salil Kapur
@salilkapur
May 27 2014 11:24
Just an indication that the code works fine.
Sudhanshu Mishra
@debugger22
May 27 2014 11:24
If it's easy to do so, we can
otherwise it's not much difficult to open travis and see why the build failed
Salil Kapur
@salilkapur
May 27 2014 11:25
cool!
I tried looking it up, didn't find anything
Sudhanshu Mishra
@debugger22
May 27 2014 11:25
I don't know how to do that
Salil Kapur
@salilkapur
May 27 2014 11:26
btw your build failed
Sudhanshu Mishra
@debugger22
May 27 2014 11:26
yeah
fixing it piecewise
Salil Kapur
@salilkapur
May 27 2014 11:26
Cool!
Sudhanshu Mishra
@debugger22
May 27 2014 11:26
It's not showing all errors at once
It exits as soon as it gets any error
BTW, when are u going to MS?
Salil Kapur
@salilkapur
May 27 2014 11:59
at MS ;P
yeah, if we can handle that. I don't even know where to check travis or shell
Sudhanshu Mishra
@debugger22
May 27 2014 12:02
Nice! :smile:
click on details