Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Anthony G. Rivera Cosme
    @arivera12

    @jbomhold3 by default I think we should be able to validate on every keystroke.

    By default, I think the debounce timer should be 0.

    Debounce timer should be just an option to optimize performance for blazor server side application to prevent hit the server on every keystroke.

    For blazor WASM doesn't make any performance issue.

    John Bomhold
    @jbomhold3
    can expose the timer value. Don't think it should be the default behavior as just watching for the enter key was lagging the crap out of blazer. I don't want this to be peoples default experience but if the timer is exposed then your welcome to change it to zero to disable it
    once he gets it created we can do some test to see what the impact is before shipping
    Anthony G. Rivera Cosme
    @arivera12

    can expose the timer value. Don't think it should be the default behavior as just watching for the enter key was lagging the crap out of blazer. I don't want this to be peoples default experience but if the timer is exposed then your welcome to change it to zero to disable it

    Wasm/Server/Both?

    Anthony G. Rivera Cosme
    @arivera12
    I see @MasterSkriptor added a PR with this. @jbomhold3 u in for test?
    John Bomhold
    @jbomhold3
    pulling it now
    MasterSkriptor @MasterSkriptor looks around nervously...
    Harold Collins
    @MasterSkriptor
    What do you guys think of a snippet extension for visual studio?
    John Bomhold
    @jbomhold3
    OnChange needs InvokeAsync(StateHasChanged) it's cross-threading because of the debouncer then that should be fixed
    Trying to change it myself but the magic of the or feature in vs does not let me edit it
    wait there it gos testing make sure thats what it was crying about now
    not it looking for the issue stand by
    https://gyazo.com/4c4781cc30523abdeaaa83f007d2b16b always nice to have no call stack
    Harold Collins
    @MasterSkriptor
    The reason I called onchange from the oninput method was that validation wouldn't fire in the oninput method. It threw no errors though. I thought that may be thread related.
    John Bomhold
    @jbomhold3
      protected void OnInput(string e)
        {
            RateLimitingExceptionForObject.Debounce(e, DebounceInterval, (CurrentValueAsString) => {
                InvokeAsync(() => OnChange(e));
            });
        }
    fixes issue
    curious if I can post the fix into the pr never done this before editing someones else's pr
    MasterSkriptor @MasterSkriptor headdesks
    Harold Collins
    @MasterSkriptor
    If not I'll do it right quick
    John Bomhold
    @jbomhold3
    let's see what happens
    nope wont let me its just that on both basic and oninput
    John Bomhold
    @jbomhold3
    works great ya just as expected if you set the value to low it starts lagging the input. this is a blazer performance issue nothing we can do to solve that until they do their speed fixes in 5.0
    thanks, Harold great work.
    Harold Collins
    @MasterSkriptor
    Just posted hotfix
    I have code snippets up to the collapse component...
    John Bomhold
    @jbomhold3
    love that you made the rate-limiter reuseable
    nice
    Harold Collins
    @MasterSkriptor
    Type bs-collapse-button and you get the whole BSCollapseToggle. If you select text, right click and select surround with blazor strap -> BSToggleButton the text drops in the BSCard type Card.Text. Coming soon in the Blazor Strap Snippet Visual Studio Extension...
    John Bomhold
    @jbomhold3
    preview 3 is going up
    Anthony G. Rivera Cosme
    @arivera12

    Hi guys, I was thinking of a nice feature to all components.

    What about to make all components hide-able by razor and css internally?

    Looking at code its better to <mycomponent Hide=true /> (For razor Hide) or <mycomponent Hidden=true /> ( For css hide)

    Rather than @if(!hide) { <mycomponent /> } or <mycomponent class="@(hidden ? "d-none" : "")" /> }

    <mycomponent Hide=true /> or <mycomponent Hidden=true /> looks cleaner rather than applying if or conditional parameter everywhere for hiding components.

    Anthony G. Rivera Cosme
    @arivera12

    Why Hide and Hidden?

    Hide destroys the component state or won't render.

    Hidden renders the component but hides it via css so it doesn't loses or destroy the state.

    Anthony G. Rivera Cosme
    @arivera12
    I know @jbomhold3 and @chanan like this hahahaha
    Harold Collins
    @MasterSkriptor
    Let me chew on that for a bit...
    John Bomhold
    @jbomhold3
    I like what?
    Harold Collins
    @MasterSkriptor
    @arivera12 I'm not sure about that because of the ambiguity. How often will people have issues from using the wrong one. As it stands now people no what they have done.
    Forgive the major misspellings...
    pm64
    @pm64
    Hello friends
    I'm using BlazorStrap in my project, but referencing custom Bootstrap CSS that I create via SCSS.
    Does this mean the Bootstrap CSS is getting loaded twice? Once as a result of my call to services.AddBootstrapCss(), then again when I reference my custom CSS in _Host.cshtml?
    michaeldeongreen
    @michaeldeongreen
    Will continue to research but wanted to find out if there are examples of having a "Collapse/Expand All" link or button for the BlazorStrap Collapse?
    Harold Collins
    @MasterSkriptor
    @pm64 if I am not mistaken the bootstrap css is loaded in _host.cshtml by default. If you change it there you should be able to load your own.
    @michaeldeongreen if you can't get it working throw an issue up on GitHub and I will try to work it out for you.
    pm64
    @pm64
    Thanks @MasterSkriptor
    michaeldeongreen
    @michaeldeongreen
    @MasterSkriptor , will do. It is more a nice to have, so I chunked it in the TODO/Backlog for now but will definitely post on GitHub when I circle back to it.
    Anthony G. Rivera Cosme
    @arivera12
    @MasterSkriptor what u mean?
    @MasterSkriptor u need to left a comment on the property explaining the difference that's all we need. It won't make any ambiguity if property is documented properly.
    if people don't read it's their fault.
    Harold Collins
    @MasterSkriptor
    @arivera12, was just stating my opinion. @chanan and @jbomhold3 are who you need to convince. Feel free to make a pull request if you have it coded already.
    Anthony G. Rivera Cosme
    @arivera12
    Hi guys, How can I use the form feedback without highlight the entire input when has error or is valid?
    Anthony G. Rivera Cosme
    @arivera12
    I just wanna show the error message but not highlight the entire input in red
    John Bomhold
    @jbomhold3
    https://www.nuget.org/packages/BlazorStrap/1.3.3-Preview-04 needs some testing nullable bools on checkboxes and selection lists. use "" for null. and SelectTabById for tabs. Want to get a build out by Friday so I can focus on updating to 5.0