Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Ashar
@coder3101
Yes I know I have just created the branch and let amit know. Merging will be done afterwards I know
Cem Bassoy
@bassoy
Very good. @coder3101 and @amitsingh19975 : to my knowledge both of you have time until the 26th of August to submit your work.
Ashar
@coder3101
I am improving the wiki now. I have planned to add some more examples about ublas::apply. I will also add in my wiki the Future work that I will do apart from GSoC.
Cem Bassoy
@bassoy
Yes, very good.
Ashar
@coder3101
I thought to keep my own Future work section but i think Future work should be for amit and me too. Here @amitsingh19975 You can add anything you want to do in future. Follow the same guidelines as I have done.
Ashar
@coder3101
Hey @bassoy , Runtime optimizer with std::variant is working. You can check the diff here. I have pushed into a new branch variant-optimizer. No temporaries is created, No intermediate evaluation is done. Optimization is done at Runtime-time. This branch is not fully stable and there are some unhandled expressions. It is just for experiment purpose. Here is an example
Also @bassoy Check this Future work which you can expect after GSoC from Us over the next few months.
Cem Bassoy
@bassoy
Thanks Ashar for your effort.
Cem Bassoy
@bassoy
@coder3101 and @amitsingh19975 . I will start to review your code and documentation tomorrow.
Cem Bassoy
@bassoy
I correct myself: I will start to review your work from tomorrow on.
I will be finished reviewing on the 1st of September.
Cem Bassoy
@bassoy
@amitsingh19975 and @coder3101 the link you provided for google summer of code does NOT directly link to your project description. Please provide the direct link to your project within the gsoc19/tensor/wiki page . Otherwise it seems that you have worked together on one project which will lead to big confusion and failure.
can you change that?
Cem Bassoy
@bassoy
If you cannot change that in your final submission on the GSoC webpage, provide the direct link on the gsoc19/tensor/wiki home (first) page to each of your project aka: Amit/Ashar : Project X/Y <- link to the subdirectory in Wiki.
Cem Bassoy
@bassoy
There are few things I would like also to mention:
  1. @amitsingh19975 please only report the code coverage on tensor, see @coder3101
  2. @amitsingh19975 please verify that you minimize the number of warnings
  3. @amitsingh19975 and @coder3101 please put a more concrete description in the issues with examples in the future project.
Cem Bassoy
@bassoy
  1. @amitsingh19975 could you please update e.g. construction access with tensor with static extents and/or static rank. Can you update other examples with tensors with static extents and/or static rank?
Ashar
@coder3101
Okay I will do it as soon as possible.
Cem Bassoy
@bassoy
yes sure ashar.
I will start to review both of your code this or the next weekend so we have time to discuss.
@amitsingh19975 and @coder3101 if the examples are too big, then split the examples into several ones. the same with the tests.
Ashar
@coder3101
@bassoy added a table that has out name project and wiki link on the main wiki page of our repository
@amitsingh19975 Do as I did with my wiki and update it accordingly.
Ashar
@coder3101
@bassoy Updated and added small examples that showcase what is to be expected from future work. Examples are added in wiki not issues.
Cem Bassoy
@bassoy
@coder3101 thanks a lot. this is important for you guys because GSoC requires to distinguish between projects. Otherwise you could fail!
amitsingh19975
@amitsingh19975
@bassoy , I have updated the wiki and add the examples as you asked.
The warnings were due to the unused values as I have added the [[unused]] attribute, now I have suppressed those warning.
amitsingh19975
@amitsingh19975
Sorry '[[nodiscard]]'
Cem Bassoy
@bassoy
@amitsing19975 and @coder3101 congratulations to you both. You invested a lot of time and effort. I would like you to complete your work, so that we can merge both your work into the development branch of ublas. It would be a great win for ublas.
amitsingh19975
@amitsingh19975
@bassoy I have decomposed the tensor class here, can you check if it's your liking or you want some changes.
I haven't checked if test are running or not. I was designing the interface right now.
Cem Bassoy
@bassoy
Looks good! I would like to work on an feature branch in ublas. we can merge your improvement into one I created.
But let us first wait for David and Stefan.
Cem Bassoy
@bassoy
One thing. please do not use tabs to space between words.
amitsingh19975
@amitsingh19975
hey @bassoy, I have updated and added support for interoperability b/w the different types of tensor here
so know you can do this
    auto t1 = ub::static_tensor<float,ub::static_extents<1,2,3>>(10);
    auto t2 = ub::fixed_rank_tensor<float,3>(ub::dynamic_extents<3>{1,2,3},1);
    auto t = t1 + t2* 2;
    decltype(t1) s = t;

    ub::dynamic_tensor<float> d = t1;
amitsingh19975
@amitsingh19975
t will be the type of whichever on the left-hand side.
they will not type promotion and they will also check if extents are equal or not.
Cem Bassoy
@bassoy
Very cool. Let's switch to the boostorg/ublas channel.
I will start to comment on your code.
Two convenient issues here from your previous pull request:
  1. Could separate the *.hpp files with static_rank and `fixed_rank? Also for the unit tests?
  2. Could you use spaces instead of tabs between words? This makes the formatting much more convenient.
Cem Bassoy
@bassoy
I commented all your code. Please review it and if possible reply to my comments and create a pull request.
amitsingh19975
@amitsingh19975
I replied to some of your comments and the other ones I will once check it and then reply to you on github.
amitsingh19975
@amitsingh19975
and also updated the github
Cem Bassoy
@bassoy
Just one minor change of variable naming regarding tag.
Did you already divide the function.hpp it’s unit test and other header files for separating dynamic and static extents wherever possible?
amitsingh19975
@amitsingh19975
I will do it once we settle with the final version of the tensor API because it will easier to refactor the code with it.
what's your thought about trait-based tensor. I gave the example in the github reply.
Cem Bassoy
@bassoy
Can you post the traits idea inside boosting/ublas channel?
Let’s discuss it in there.
amitsingh19975
@amitsingh19975
ok