by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Brian Genisio
@BrianGenisio
instead of taking everything in site and creating a subtree and pushing it to the branch...
It would create a "dist" folder with everything
And push it to the branch
Miguel Castillo
@MiguelCastillo
yeah let's write a git issue with items...
Brian Genisio
@BrianGenisio
The we wouldn't need to check in the "processed" files
Miguel Castillo
@MiguelCastillo
i use dist to put all my build artifacts
Brian Genisio
@BrianGenisio
And we wouldn't need to check in the bower_components or node_moudles
Miguel Castillo
@MiguelCastillo
it would be easy to run a copy step
Brian Genisio
@BrianGenisio
At least on master
Miguel Castillo
@MiguelCastillo
yup, i understand
Brian Genisio
@BrianGenisio
It would clean up master quite a bit
Miguel Castillo
@MiguelCastillo
i can do that pretty quickly if you got other stuff to do
Brian Genisio
@BrianGenisio
When I started, I didn't have many assets that I needed to push to the branch, so it wasn't a big deal
But it got bigger
And now it has node_modules which brings in a pretty large tree
Miguel Castillo
@MiguelCastillo
i expect will continue to get bigger
Brian Genisio
@BrianGenisio
Yeah, it may
If you want to take a crack, feel free. I'm trying to get some stuff done on Robotnik
Miguel Castillo
@MiguelCastillo
here is the issue we can use for tracking it BrianGenisio/learnharmony#13
Brian Genisio
@BrianGenisio
Cool
Miguel Castillo
@MiguelCastillo
i left in the source map files for babel bit and bit imports... they are very big, so we should remove them to improve page load times
Brian Genisio
@BrianGenisio
OK. Though I thought that source maps only load when debug tools are open?
Miguel Castillo
@MiguelCastillo
that makes sense if it worked that way... let me read up on it
yeah they are download only when you have dev tools open. we should be ok then.
Brian Genisio
@BrianGenisio
Sweet.
Miguel Castillo
@MiguelCastillo
its hard for me to gauge, but does the site seem to be running slower?
Brian Genisio
@BrianGenisio
Page load seems slower
Miguel Castillo
@MiguelCastillo
is there a way to have a different branch published at the same time?
i am also wondering if it has to do with git pages taking a minute to cache that stuff...
Brian Genisio
@BrianGenisio
Well, you can always publish it to your gh-pages branch
In other words, yeah... just a fork
Miguel Castillo
@MiguelCastillo
yeah, good point. I will try that
Brian Genisio
@BrianGenisio
Every repo supports Github Pages
Miguel Castillo
@MiguelCastillo
yup
Miguel Castillo
@MiguelCastillo
here is the site before the merge. I am looking at what's happening. http://miguelcastillo.github.io/learnharmony/
Miguel Castillo
@MiguelCastillo
i am chasing down performance... this will keep me busy for a good bit :D
Brian Genisio
@BrianGenisio
Any ideas?
I'm going to bed soon. Inspection first thing in the morning.
Miguel Castillo
@MiguelCastillo
little I know is that it is in bit-imports... not sure the actual cause quite yet
Miguel Castillo
@MiguelCastillo
@BrianGenisio hey good news
i found the issue
it was in my ajax provider... somehow I had it set to use sync requests... now it is flipped to async and things are much faster
promjax is the name of the package... I have fixed it and pushed to NPM
Miguel Castillo
@MiguelCastillo
I send a PR with an update site/node_modules, but I have to run... I can do later tonight when I get back
but if feel free to update the node_modules yourself if you got some time before I get to this
hexicle
@hexicle
This message was deleted
Steve Coffman
@StevenACoffman
In the Learn Harmony site… I am confused how your Bootstrap CSS is winding up included in the page.
Steve Coffman
@StevenACoffman
I had to include the bootstrap css from cdn in the index.html, but I don’t see you including the CSS directly in any HTML or JS file. Did you use some webpack magic or did I miss where you’ve got that?
Steve Coffman
@StevenACoffman
Oop. Nope. You’ve got it right there in index.js:import 'bootstrap/dist/css/bootstrap.min.css'
Brian Genisio
@BrianGenisio
Yep ;). You found it!