Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Jan Karger ツ ☀
    @punker76
    the TextView is marked as internal
    we decided this, so the most apps are rectangles ;-)
    and then it's not necessary to use allow transparency
    James Willock
    @ButchersBoy
    :)
    that ruins my plans :)
    Jan Karger ツ ☀
    @punker76
    sorry about that
    but awesome lib !
    James Willock
    @ButchersBoy
    I will still build a little demo app with MahApps...the real issue with my stuff is the docking...youd kinda need the transparency do you can see the drop target. If you turn the dragging off, and pushing the tab control up into the window "border" abit, it is not so bad
    thanks
    ive been using MahApps for 2 years....unfortunately I work a bank and it is impossible to contribute...git is blocked. I wrote a tabbing library for them, but decided it needed to be released to git so have rewritten it from the ground up
    Chris Horn
    @GMZ
    Hi Great lib I'm liking it a lot I got a question cause I'm not sure if its a bug or something I'm doing wrong
    I drag a tab off and create a new window, works fine once last tab closes that new window closes work fine, Drag tab and re-doc to existing window (2 or more tab groups on one window) close last tab in either tab group and the window still closes. I've looked at the demo code and changed the "ClosingTabItemHandlerImpl" however it doesn't stop it from happening
    James Willock
    @ButchersBoy
    hi
    yep...just reproduced it...that's a bug,,,can't believe i never spotted that one before!
    ...i'll take a look
    James Willock
    @ButchersBoy
    Think I will have to change the API ever so slightly...TabEmptiedResponse.CloseWindow will be renamed TabEmptiedResponse.CloseWindowOrUnBranchLayout
    James Willock
    @ButchersBoy
    OK, fix pushed to GitHun and NuGet...unless you were manually using IInterTabClient you shouldnt notice the API changes. Thanks for the feedback.
    Jan Karger ツ ☀
    @punker76
    @ButchersBoy hi, gm, i noticed a strange behavior with maximized window
    James Willock
    @ButchersBoy
    Ok...I'll check it out
    Jan Karger ツ ☀
    @punker76
    :+1:
    James Willock
    @ButchersBoy
    @punker76 fix checked into GitHub. Build is having problems talking to nuget at the moment, but it will be fixed in build .95 when that gets published.
    Jan Karger ツ ☀
    @punker76
    :+1: i'll retest it
    James Willock
    @ButchersBoy
    It's made it to nuget now.
    Jan Karger ツ ☀
    @punker76
    @ButchersBoy works! :clap:
    James Willock
    @ButchersBoy
    Result! Have a good weekend!
    Jan Karger ツ ☀
    @punker76
    thx, dito
    Shel2
    @Shel2

    @ButhersBoy I'm looking at the CustomHeader example to see if I can add middle-clicking to close the tab... I added CustomCommands.cs:```
    public static class CustomCommands
    {
    public static readonly RoutedUICommand CloseTab = new RoutedUICommand
    ("Close Tab", "Close", typeof(CustomCommands), new InputGestureCollection{new MouseGesture(MouseAction.MiddleClick)});

    }```

    Then in the CustomHeader.xaml I modified the StackPanel to use the custom command:

    ```<UserControl.CommandBindings>
        <CommandBinding Command="dragablzDemo:CustomCommands.CloseTab" CanExecute="CloseTabCanExecute" Executed="CloseTabExecuted" />
    </UserControl.CommandBindings>
    <StackPanel Orientation="Horizontal">
        <Grid>                     
              <Grid.CommandBindings>
                  <CommandBinding Command="dragablzDemo:CustomCommands.CloseTab"/>
              </Grid.CommandBindings>```

    Now I can get into the two new methods whenever I middle-click the tab:
    ```private void CloseTabCanExecute(object sender, CanExecuteRoutedEventArgs e)
    {
    e.CanExecute = true;
    }

        private void CloseTabExecuted(object sender, ExecutedRoutedEventArgs e)
        {
        //    var rc = TabablzControl.CloseItemCommand;
        //    if (rc.CanExecute(sender, e.OriginalSource as TabablzControl))
        //        rc.Execute(sender, e.OriginalSource as TabablzControl);
        }```

    But I'm having trouble actually closing the tab because the sender is now the CustomerHeader object and I don't see a link to the TabablzControl... do you have a suggestion for how to perform the tab closing? I'm still just learning WPF, so I apologize if this is just simple XAML-related syntax... but thanks again for your help!

    James Willock
    @ButchersBoy
    Let me just put my kids to bed and I'll have a look!
    James Willock
    @ButchersBoy
    ..OK, where you are going wrong is creating your own RoutedUICommand...you should re-use the existing one provided by Dragablz. So I did this in CustomHeader:
    
    
    <UserControl.InputBindings>
        <MouseBinding Command="dragablz:TabablzControl.CloseItemCommand" MouseAction="MiddleClick" />        
    </UserControl.InputBindings>
    Shel2
    @Shel2
    lol - that's much simpler!
    James Willock
    @ButchersBoy
    ...you will still be able to intercept the pre/post close
    <UserControl.InputBindings>
        <MouseBinding Command="dragablz:TabablzControl.CloseItemCommand" MouseAction="MiddleClick" />        
    </UserControl.InputBindings>
    ...you will still be able to intercept the pre/post close
    :)
    dunno why that just posted twice
    ...yeah, you'll still be able to intercept the pre close, (see in BoundExampleModel: public ClosingTabItemCallback ClosingTabItemHandler)
    how you getting on with the other questions you asked on the blog?
    Shel2
    @Shel2
    The prefix/suffix is good...
    I was going to see if I could figure out how to get the same looking close button
    James Willock
    @ButchersBoy
    ...yeah...what style are you using? one of the basic ones or the MahApps or Material one?
    ...cos I still need to style the close buttons on MahApps/MaterialDesign a bit better
    Shel2
    @Shel2
    MahApps
    James Willock
    @ButchersBoy
    cool. but yeah, the close button style will change at some point, cos it's not using the theme properly
    Shel2
    @Shel2
    And the last 2 questions from the blog: the "plus" button gets hidden off the right side of the window and I haven't found where the margin or constraint is yet...
    And I'm not sure yet if I can block certain tabs from being dragged out... but I might do better to handle that with the prefix, if I can style them to look just like the normal tabs
    For the close button - I just wanted to match the other tabs close button, so I was thinking of reusing the existing style - even if that changes
    James Willock
    @ButchersBoy
    yeah...i thought the not dragging would be your biggest problem...the prefix is probably the best way to go