Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Geert van Horrik
    @GeertvanHorrik
    if you are using C# 6.0, it should do it. Can you create a repro?
    advapiIT
    @advapiIT
    Yes, using c# 6.0
    advapiIT
    @advapiIT
    hold a sec... I'm using 2.17.1
    not the latest one
    since I'm still on 4.5.4
    Geert van Horrik
    @GeertvanHorrik
    the latest should be compatible with both 4.x and 5.x
    we really recommend you to update to 5.x though (free performance improvements!)
    advapiIT
    @advapiIT
    Excuse me Geert, if someaday I'll use postsharp with my solution, there will be some issues with Catel.Fody?
    Geert van Horrik
    @GeertvanHorrik
    Not sure, I haven't used that combination myself
    GreenKn1ght
    @GreenKn1ght
    Catel.Fody 3.4.0 does not depend on Fody anymore?
    Geert van Horrik
    @GeertvanHorrik
    It does, but it shouldn't pull it in as a dependency, I think that has been changed
    you still need Fody + FodyWeavers
    GreenKn1ght
    @GreenKn1ght
    So how do I know which version it depends on?
    Geert van Horrik
    @GeertvanHorrik
    maybe @SimonCropp knows?
    Simon Cropp
    @SimonCropp
    @GeertvanHorrik something is missing. let me have a look
    Geert van Horrik
    @GeertvanHorrik
    could be because we are doing some tricky things with the packages (attributes vs actual weaver)
    Simon Cropp
    @SimonCropp
    the thing that adds the fody ref is
    <PackageReference Include="FodyPackaging" Version="3.1.4" PrivateAssets="All" />
    Geert van Horrik
    @GeertvanHorrik
    even with privateassets?
    Simon Cropp
    @SimonCropp
    sorry wrong line
    <PackageReference Include="Fody" Version="3.1.3" PrivateAssets="None" />
    https://github.com/Fody/Janitor/blob/master/Janitor/Janitor.csproj#L11
    Geert van Horrik
    @GeertvanHorrik
    testing now
    thanks @SimonCropp
    @GreenKn1ght please test Catel.Fody Build - 3.5.0-alpha.2 which should be available in about 10 minutes (depending on the NuGet indexing stuff)
    GreenKn1ght
    @GreenKn1ght
    Now everything is fine.
    Simon Cropp
    @SimonCropp
    @GeertvanHorrik i smoke tested it, and it looks all good
    Geert van Horrik
    @GeertvanHorrik
    thanks guys, will deploy new hotfix release now
    GreenKn1ght
    @GreenKn1ght
    I get an unhandled exception when I try to build an old branch that references Catel.Fody 3.3.0
    Failed to execute weaver C:\Users\is-selyakov.nuget\packages\catel.fody\3.5.0-alpha0002\netclassicweaver\Catel.Fody.dll
    I can not understand why a newer version is used.
    Can this happen because of "tricky things with the packages"?
    Geert van Horrik
    @GeertvanHorrik
    Shouldn't be. I think Fody uses the latest one by default, but all features used should be backwards compatible (at least in Catel.Fody)
    GreenKn1ght
    @GreenKn1ght
    But it is not backwards compatible
    Full exception info:
    Fody: An unhandled exception occurred:
    Exception:
    Failed to execute weaver C:\Users\Admin.nuget\packages\catel.fody\3.5.0-alpha0002\netclassicweaver\Catel.Fody.dll
    Type:
    System.Exception
    StackTrace:
    at InnerWeaver.ExecuteWeavers()
    at InnerWeaver.Execute()
    Source:
    FodyIsolated
    TargetSite:
    Void ExecuteWeavers()
    Method not found: 'Fody.TypeSystem Fody.BaseModuleWeaver.get_TypeSystem()'.
    Type:
    System.MissingMethodException
    StackTrace:
    at Catel.Fody.ModuleWeaver.Execute()
    at InnerWeaver.ExecuteWeavers()
    Source:
    Catel.Fody
    TargetSite:
    Void Execute()
    That is, Fody uses Catel.Fody, and not vice versa?
    Geert van Horrik
    @GeertvanHorrik
    Fody uses Catel.Fody. What version of Fody + what version of Catel.Fody?
    Simon Cropp
    @SimonCropp
    @GreenKn1ght i suggest u move the the new sdk style of csproj to work around that
    GreenKn1ght
    @GreenKn1ght
    @GeertvanHorrik exception comes from branch that reference Catel.Fody 3.3.0 and Fody 3.0.1.
    @SimonCropp I see it is known issue. Thanks for suggestion, but I'll have to keep old project style.
    Simon Cropp
    @SimonCropp
    @GreenKn1ght " but I'll have to keep old project style." out of curiosity, how come?

    as for the "use the newest version" issue. it comes from the legacy of when nuget didn use a shared cache, and hence this wasnt a problem.
    happy to accept a PR that fixes it, current status was this PR https://github.com/Fody/Fody/pull/461#issuecomment-415901374 which didnt really fix it in the correct way

    i am unlikely to get around to fixing it since i no longer have any projects using the old csproj format

    GreenKn1ght
    @GreenKn1ght
    @SimonCropp there is no support for WPF out of the box and hand-made solutions (like Sunburst.NET.Sdk.WPF) have several issues.
    Simon Cropp
    @SimonCropp
    yep fair enough
    Geert van Horrik
    @GeertvanHorrik
    I have converted all my wpf apps to the new modern sdk stuff
    (about 60 components + 15 private apps)
    GreenKn1ght
    @GreenKn1ght
    I can convert my projects too, but I can't get rid of IntelliSense error "An error occurred while finding the resource dictionary: Ambiguous reference" while using absolute URI to include resources from same assembly.
    Simon Cropp
    @SimonCropp
    @GeertvanHorrik catel dropping the fody package dependency seems to be a nuget bug NuGet/Home#7285
    Geert van Horrik
    @GeertvanHorrik
    @SimonCropp wow, interesting to hear, thanks for the update