Anyone have any insights on why objects present within an FastObservableCollection (that are based off ValidatableModelBase) are not getting garbage collected? The collections do not have events attached to them but if I null out the property it will GC the objects in the collection (sometimes).
And are you using .NET Core? It has a slightly different way of GC (we had to fix all the unit tests since we cannot rely on objects being collected by GC.Collect)
I have the feeling it may be the way I’m handling instantiation and population however.
Just checked the code for FOC, don't see any subscriptions there. Maybe it's the RAD grid subscribing to property changed of the objects inside collection?
weird, I would expect dotMemory to show some sort of relation, even if it's via an event subscription.
Just a few double checks
- Is the collection cleared (are items removed from the list)?
- Is the collection no longer part of a VM?
- Is the VM closed / no longer attached to a view?
Yeah so would I but it hasn't been rather forthcoming. But as an example:
- I have a ViewModel for the sake of this example called GridViewModel<TDomainModel>
- The ViewModel has a member property called Rows which is a FastObservableCollection<TDomainModel>
- Rows is an inline initialization -- public FastObservableCollection<TDomainModel> Rows { get; } = new FastObservableCollection<TDomainModel>
- Items are retrieved from an external source and added to Rows in InitializeAsync via AddItems
- The property Rows is cleared during OnClosingAsync()
- dotMemory shows that all the objects within Rows survived the closing and disposing of the ViewModel along with their ValidationContext
are you sure the external sourec is not holding it somehow?
So 4 would be a manager class that handles mediation between the VM and the DAL. It basically does the query to the DB and converts the entity model to a domain model. You may be right though I should probably have the ViewModel discard the property that holds the manager class on dispose
I'll try that out on Monday and see what happens
thanks for the input though
Can you try a different grid (just the default one)?
It's most likely a behavioral issue with Telerik. I'll dig more on Monday.
@GeertvanHorrik What are your thoughts on possibly creating an FastObservableItemCollection that inherits off FastObservableCollection but exposes an ItemChanged event? I'm pondering implementing one to throw out some rx.net extension methods that are being used
for the cases where the object within the collection is also observable
ChangeNotificationWrapper or something like that
I forgot about that
Hello! I have a question about MVVM patterns and ribbons in Catel+Orchestra+Fluent.
I want to have my ribbonView to have its own viewmodel, as does the mainview orchestra uses.
- I'm using ApplicationCommandContainers as much as possible for the ribbon, which works great. so far so good
- but there are instances where the RibbonViewModel should have access to the MainViewModel (contextual tabs e.g., commands targeting the mainViewModel e.g.)
- what is the intended pattern here? is it possible to resolve a MainViewModel reference with dependency injection? (I haven't found an example for that yet).
- the documentation here doesn't quite fit I think, since I'm not talking models really: https://catelproject.atlassian.net/wiki/spaces/CTL/pages/1409119/Introduction+to+the+nested+user+controls+problem
thank you in advance!
if you need commands to be existing on other vms, it's best to register a ComposeCommand. In the main vm, you can Add an action to that composite VM and unregister it when the vm gets closed. This way, the command is a long-living object (always available), but vms can subscribe to it. A great example is Refresh, where you have 1 Refresh command, and each VM that has refresh capabilities can add an action to this composite command.
hmm thank you! yes, the service approach is definitely better. (and thanks, I'll have a look at ComposeCommands as well! )
I just had a look at the CsvTextEditor where a lot of the action also happens in the IProjectManager and Command containers - this is probably worth looking into)
my questions comes from trying to implement Dirkster99.AvalonDock+Mlib theming in the Orc+Fluent app. not as easy as I had thought :D
they had a ThemeViewModel inside the MainViewModel. I should probably move the themeing into a Service tho...
anyways. thanks for the quick reply!