Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 19 10:21

    delete-merged-branch[bot] on nuget

    (compare)

  • Oct 19 10:21

    github-actions[bot] on develop

    Bump Fody from 6.5.3 to 6.5.4 … Merge pull request #1873 from C… (compare)

  • Oct 19 10:21
    github-actions[bot] closed #1873
  • Oct 19 10:20
    dependabot[bot] labeled #1873
  • Oct 19 10:20
    dependabot[bot] opened #1873
  • Oct 19 10:20

    dependabot[bot] on nuget

    Bump Fody from 6.5.3 to 6.5.4 … (compare)

  • Oct 18 10:27

    delete-merged-branch[bot] on nuget

    (compare)

  • Oct 18 10:27

    GeertvanHorrik on develop

    Bump Verify.NUnit from 13.2.1 t… Merge pull request #1872 from C… (compare)

  • Oct 18 10:27
    GeertvanHorrik closed #1872
  • Oct 18 10:22
    dependabot[bot] labeled #1872
  • Oct 18 10:22
    dependabot[bot] opened #1872
  • Oct 18 10:22

    dependabot[bot] on nuget

    Bump Verify.NUnit from 13.2.1 t… (compare)

  • Oct 15 11:33

    delete-merged-branch[bot] on nuget

    (compare)

  • Oct 15 11:33

    GeertvanHorrik on develop

    Bump Verify.NUnit from 13.1.0 t… Merge pull request #1871 from C… (compare)

  • Oct 15 11:33
    GeertvanHorrik closed #1871
  • Oct 15 10:35
    dependabot[bot] labeled #1871
  • Oct 15 10:35
    dependabot[bot] opened #1871
  • Oct 15 10:35

    dependabot[bot] on nuget

    Bump Verify.NUnit from 13.1.0 t… (compare)

  • Oct 14 11:42

    GeertvanHorrik on 5.12.19

    (compare)

  • Oct 14 11:42

    GeertvanHorrik on develop

    #1870 Support nested ServiceLoc… Pass in the type factory when c… Use correct factory and 4 more (compare)

rfuzzo
@rfuzzo

hmm thank you! yes, the service approach is definitely better. (and thanks, I'll have a look at ComposeCommands as well! )
I just had a look at the CsvTextEditor where a lot of the action also happens in the IProjectManager and Command containers - this is probably worth looking into)

my questions comes from trying to implement Dirkster99.AvalonDock+Mlib theming in the Orc+Fluent app. not as easy as I had thought :D
they had a ThemeViewModel inside the MainViewModel. I should probably move the themeing into a Service tho...

anyways. thanks for the quick reply!
Geert van Horrik
@GeertvanHorrik
You might want to look into Orc.Theming for tehming
rfuzzo
@rfuzzo
ohh thank you! that might be the better approach...
Ghost
@ghost~5da242acd73408ce4fcdaa63
@GeertvanHorrik I didn't want to piggy back this onto the issue comments but just as another curve ball it appears there is an ongoing effort to introduce an MVVM framework within the Windows Community Toolkit so I'm not sure what that will result in
Geert van Horrik
@GeertvanHorrik
Yes, I've seen. It looks like a MVVMLight clone, which works great for a lot of people.
We are not interested in doing a rewrite of our components at any stage. If we would do a rewrite, it would be non-windows (web / blazor). It seems Microsoft can't get their head straight around their XAML technology.
Ghost
@ghost~5da242acd73408ce4fcdaa63
I don't think they will, even Avalon seems a mess
Geert van Horrik
@GeertvanHorrik
I think Avalon is non-msft?
Ghost
@ghost~5da242acd73408ce4fcdaa63
Is it? I've only had minor exposure to it and wasn't keen on it and I also think that XAML Standard also went no where
Geert van Horrik
@GeertvanHorrik
I believe the codename for WPF was Avalon, and some non-msft did a great attempt to make wpf cross-platform (which is amazing what they have accomplished with which I believe is a small team compared to MSFT with nearly unlimited budgets)
Ghost
@ghost~5da242acd73408ce4fcdaa63
Ah it looks like it's just part of the .NET Foundation so yeah it's non-MSFT but has some recognition
Geert van Horrik
@GeertvanHorrik
btw we have enabled github discussions in Catel so we can keep everything on GitHub now
Ghost
@ghost~5da242acd73408ce4fcdaa63
I'll have to take a look, I don't utilize GitHub heavily these days since everything for us was migrated to Azure DevOps permanently.
Geert van Horrik
@GeertvanHorrik
I don't know how much Azure DevOps there will be now GitHub is at the same feature level. With the workflows / build agents, I think Azure DevOps has no more reason to exist (both owned by msft)
Ghost
@ghost~5da242acd73408ce4fcdaa63
Not sure, could be a concern as we leverage on-prem build agents for our release pipelines
as well as the artifact hosting so it might present some fun issues later
Geert van Horrik
@GeertvanHorrik
Yeah, they surely want you to use those cloud minutes for your builds so I don't think GH will support custom build agents. We use Continua CI so we have everything under control with fast local builds.
Ghost
@ghost~5da242acd73408ce4fcdaa63
Yeah that would be a deal breaker for us because our database release pipelines rely on dacpac deployments via nuget and windows auth so GitHub would be out in that regard
mcpherson-sa
@mcpherson-sa
I have VS installed in a non-default location and I noticed that the Cael source fails to build in this case. After some digging I found that in the relevant cake file. in which teh code looks in a number preset locations to try and find various editions of VS. Whilst it was easy enough to make the necessary change to the cake file to make the build work, it would be nice to build something into the scripts to handle this out of the box. Simplest thing would be to just provide a way to configure it without modifying the checked in cake files or try to find it automatically - maybe something like the approach here: https://stackoverflow.com/questions/30504/programmatically-retrieve-visual-studio-install-directory in the answer by lauxjpn. Other approaches on this page that try to read HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Microsoft\VisualStudio\<version>\InstallDir don't seem to work anymore as that key doesn't exist on my machine (I have 2019 pro).
Geert van Horrik
@GeertvanHorrik
Good points @mcpherson-sa . Could you please raise a GitHub issue instead so we can mark this>
2 replies
Offline
@Offline-R503B

@GeertvanHorrik Hello, we are using Catel in our project with fody.

We are getting this : https://media.discordapp.net/attachments/717720094196760760/810377190934970388/unknown.png

This shows after first time pressing build and we always have to press build a 2nd time.

I wasn't able to find good information on what can cause this.

So if you can help out here that would be lovely.

Geert van Horrik
@GeertvanHorrik
@Offline-R503B , please create a ticket in Catel.Fody repository with a repro and I can take a look
Offline
@Offline-R503B
Alright.
How would i go about posting a repro about an issue i can not locate?
since obviously as i stated before we cant find any documentation on what can cause this, nor does it give us any indication where it originates from.
Geert van Horrik
@GeertvanHorrik
@Offline-R503B , is the repro public? Then that's the repro ;-)
Offline
@Offline-R503B
Aweseome I am putting up the issue now
Offline
@Offline-R503B
@GeertvanHorrik Thanks again , A small after effect i just noticed :
image.png
Is this something we should worry about?
Ah nvm i see what i did
Obviously if you remove old packages. They cant be referenced :D
Geert van Horrik
@GeertvanHorrik
:)
So do I understand correctly the issue with Fody is fully addressed?
Offline
@Offline-R503B
Yea, so far so good :D
Really improves the workflow :)
Offline
@Offline-R503B
@GeertvanHorrik I think I found out when it happens. We still encounter it but only if changes are applied to the project
And not all changes ill post my findings in a bit
Offline
@Offline-R503B
Do you happen to have an use for a diagnostic output from Catel.Fody weaving?
image.png
Geert van Horrik
@GeertvanHorrik
Yes, definitely. Where is this chat room, is it public? Maybe we can discuss there?
Offline
@Offline-R503B
On discord, I could invite you :)
Geert van Horrik
@GeertvanHorrik
(see private chat)
Galgemaennle
@Galgemaennle
Hi. I'm using the great Catel Framework and especially the DataWindow to serve a GUI to modify a model. It's compiled as a dll to be loaded as a plugin into a 3rd party program. That Program loads the dll and searches its interface by Assembly.LoadFile(...).GetTypes(). Unfortunately, the DLL can't be loaded. I'm able to recreate the issue in an console app. I get System.Reflection.ReflectionTypeLoadException with Catel.MVVM, Version=5.12.16.0 can't be found or a dependency is missing. I've double checked that all dependencies are in the same location to be dynamically loaded. I've also used fody costura to statically merge them together. I also made sure, my dll is compiled with <= .net framework version as the calling app. Figgured out that, using a second dll wrapped around the gui dll and serving the interface works fine (When Catel.MVVM is not part of GetTypes() ). It's somehow hiding some stuff. I'm kinda lost. Any advice very much appreciated
Geert van Horrik
@GeertvanHorrik
Are you sure it's not a first-chance exception, for example for the resource assemblies?
Galgemaennle
@Galgemaennle
I have 7 assemblies from assembly.GetReferencedAssemblies(), event AppDomain.CurrentDomain.AssemblyResolve is fired 3 times. Catel.MVVM, Catel.Core, Catel.Core (all of them for the same version). So all other can be loaded without issues (all of them also merged along with fody). When I load missing catel.dlls manually in the resolve event, it's fine. But I can't append the 3rd party sw. Also don't know why this only fails with catel related dlls. Also tried to add those dlls to the LoadAssembliesOnStartup in the fody weavers. I'm kinda lost, also can't debugs for further details. Hoped, you might give some hints ;)
Geert van Horrik
@GeertvanHorrik
Could it be possible that your assembly is not being loaded and thus not yet kicking in? Maybe try to use:
  1. Costura (embed Catel.Core + Catel.MVVM)
  2. ModuleInit (allows you to execute code when the 3rd party loads your assembly)
rfuzzo
@rfuzzo

Hello, I have a question about the IUIVisualizerService.
I'm using it like so var result = await _UIVisualizerService.ShowAsync(viewModel)
and it constructs the view and everything correctly, the result is true when I click OK, so far everything works.

What I want is to use custom OK and Cancel buttons, I have implemented it with a Command binding to the DataWindow ViewModel, executing this.CloseViewModelAsync(true) inside the ViewModel.
private void ExecuteFinish() => this.CloseViewModelAsync(true);

It closes the View alright, but the result from the IUIVisualizerService is null (bool? is null). Why is that so, and can't I use CloseViewModelAsync to pass the dialogresult?

thanks!

rfuzzo
@rfuzzo
hmm I think I found it... this.CancelAndCloseViewModelAsync(); and this.SaveAndCloseViewModelAsync();