Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jul 20 21:52
    GeertvanHorrik commented #1839
  • Jul 19 20:05
    GeertvanHorrik labeled #1839
  • Jul 19 20:05
    GeertvanHorrik assigned #1839
  • Jul 19 20:05
    GeertvanHorrik opened #1839
  • Jul 13 07:18

    dependabot-preview[bot] on nuget

    (compare)

  • Jul 13 07:18
    dependabot-preview[bot] closed #1838
  • Jul 13 07:18

    dependabot-preview[bot] on develop

    Bump Verify.NUnit from 11.20.1 … Merge pull request #1838 from C… (compare)

  • Jul 13 07:14
    dependabot-preview[bot] labeled #1838
  • Jul 13 07:14
    dependabot-preview[bot] opened #1838
  • Jul 13 07:14

    dependabot-preview[bot] on nuget

    Bump Verify.NUnit from 11.20.1 … (compare)

  • Jul 08 09:45

    delete-merged-branch[bot] on 20210708-094513

    (compare)

  • Jul 08 09:45

    GeertvanHorrik on develop

    GitHubSync update Merge pull request #1837 from C… (compare)

  • Jul 08 09:45
    GeertvanHorrik closed #1837
  • Jul 08 09:45
    GeertvanHorrik opened #1837
  • Jul 08 09:45

    GeertvanHorrik on 20210708-094513

    GitHubSync update (compare)

  • Jul 05 07:15

    dependabot-preview[bot] on nuget

    (compare)

  • Jul 05 07:15

    dependabot-preview[bot] on develop

    Bump Fody from 6.5.1 to 6.5.2 … Merge pull request #1836 from C… (compare)

  • Jul 05 07:15
    dependabot-preview[bot] closed #1836
  • Jul 05 07:14
    dependabot-preview[bot] labeled #1836
  • Jul 05 07:14
    dependabot-preview[bot] opened #1836
Ghost
@ghost~5da242acd73408ce4fcdaa63
Not sure, could be a concern as we leverage on-prem build agents for our release pipelines
as well as the artifact hosting so it might present some fun issues later
Geert van Horrik
@GeertvanHorrik
Yeah, they surely want you to use those cloud minutes for your builds so I don't think GH will support custom build agents. We use Continua CI so we have everything under control with fast local builds.
Ghost
@ghost~5da242acd73408ce4fcdaa63
Yeah that would be a deal breaker for us because our database release pipelines rely on dacpac deployments via nuget and windows auth so GitHub would be out in that regard
mcpherson-sa
@mcpherson-sa
I have VS installed in a non-default location and I noticed that the Cael source fails to build in this case. After some digging I found that in the relevant cake file. in which teh code looks in a number preset locations to try and find various editions of VS. Whilst it was easy enough to make the necessary change to the cake file to make the build work, it would be nice to build something into the scripts to handle this out of the box. Simplest thing would be to just provide a way to configure it without modifying the checked in cake files or try to find it automatically - maybe something like the approach here: https://stackoverflow.com/questions/30504/programmatically-retrieve-visual-studio-install-directory in the answer by lauxjpn. Other approaches on this page that try to read HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Microsoft\VisualStudio\<version>\InstallDir don't seem to work anymore as that key doesn't exist on my machine (I have 2019 pro).
Geert van Horrik
@GeertvanHorrik
Good points @mcpherson-sa . Could you please raise a GitHub issue instead so we can mark this>
2 replies
Offline
@Offline-R503B

@GeertvanHorrik Hello, we are using Catel in our project with fody.

We are getting this : https://media.discordapp.net/attachments/717720094196760760/810377190934970388/unknown.png

This shows after first time pressing build and we always have to press build a 2nd time.

I wasn't able to find good information on what can cause this.

So if you can help out here that would be lovely.

Geert van Horrik
@GeertvanHorrik
@Offline-R503B , please create a ticket in Catel.Fody repository with a repro and I can take a look
Offline
@Offline-R503B
Alright.
How would i go about posting a repro about an issue i can not locate?
since obviously as i stated before we cant find any documentation on what can cause this, nor does it give us any indication where it originates from.
Geert van Horrik
@GeertvanHorrik
@Offline-R503B , is the repro public? Then that's the repro ;-)
Offline
@Offline-R503B
Aweseome I am putting up the issue now
Offline
@Offline-R503B
@GeertvanHorrik Thanks again , A small after effect i just noticed :
image.png
Is this something we should worry about?
Ah nvm i see what i did
Obviously if you remove old packages. They cant be referenced :D
Geert van Horrik
@GeertvanHorrik
:)
So do I understand correctly the issue with Fody is fully addressed?
Offline
@Offline-R503B
Yea, so far so good :D
Really improves the workflow :)
Offline
@Offline-R503B
@GeertvanHorrik I think I found out when it happens. We still encounter it but only if changes are applied to the project
And not all changes ill post my findings in a bit
Offline
@Offline-R503B
Do you happen to have an use for a diagnostic output from Catel.Fody weaving?
image.png
Geert van Horrik
@GeertvanHorrik
Yes, definitely. Where is this chat room, is it public? Maybe we can discuss there?
Offline
@Offline-R503B
On discord, I could invite you :)
Geert van Horrik
@GeertvanHorrik
(see private chat)
Galgemaennle
@Galgemaennle
Hi. I'm using the great Catel Framework and especially the DataWindow to serve a GUI to modify a model. It's compiled as a dll to be loaded as a plugin into a 3rd party program. That Program loads the dll and searches its interface by Assembly.LoadFile(...).GetTypes(). Unfortunately, the DLL can't be loaded. I'm able to recreate the issue in an console app. I get System.Reflection.ReflectionTypeLoadException with Catel.MVVM, Version=5.12.16.0 can't be found or a dependency is missing. I've double checked that all dependencies are in the same location to be dynamically loaded. I've also used fody costura to statically merge them together. I also made sure, my dll is compiled with <= .net framework version as the calling app. Figgured out that, using a second dll wrapped around the gui dll and serving the interface works fine (When Catel.MVVM is not part of GetTypes() ). It's somehow hiding some stuff. I'm kinda lost. Any advice very much appreciated
Geert van Horrik
@GeertvanHorrik
Are you sure it's not a first-chance exception, for example for the resource assemblies?
Galgemaennle
@Galgemaennle
I have 7 assemblies from assembly.GetReferencedAssemblies(), event AppDomain.CurrentDomain.AssemblyResolve is fired 3 times. Catel.MVVM, Catel.Core, Catel.Core (all of them for the same version). So all other can be loaded without issues (all of them also merged along with fody). When I load missing catel.dlls manually in the resolve event, it's fine. But I can't append the 3rd party sw. Also don't know why this only fails with catel related dlls. Also tried to add those dlls to the LoadAssembliesOnStartup in the fody weavers. I'm kinda lost, also can't debugs for further details. Hoped, you might give some hints ;)
Geert van Horrik
@GeertvanHorrik
Could it be possible that your assembly is not being loaded and thus not yet kicking in? Maybe try to use:
  1. Costura (embed Catel.Core + Catel.MVVM)
  2. ModuleInit (allows you to execute code when the 3rd party loads your assembly)
rfuzzo
@rfuzzo

Hello, I have a question about the IUIVisualizerService.
I'm using it like so var result = await _UIVisualizerService.ShowAsync(viewModel)
and it constructs the view and everything correctly, the result is true when I click OK, so far everything works.

What I want is to use custom OK and Cancel buttons, I have implemented it with a Command binding to the DataWindow ViewModel, executing this.CloseViewModelAsync(true) inside the ViewModel.
private void ExecuteFinish() => this.CloseViewModelAsync(true);

It closes the View alright, but the result from the IUIVisualizerService is null (bool? is null). Why is that so, and can't I use CloseViewModelAsync to pass the dialogresult?

thanks!

rfuzzo
@rfuzzo
hmm I think I found it... this.CancelAndCloseViewModelAsync(); and this.SaveAndCloseViewModelAsync();
Geert van Horrik
@GeertvanHorrik
Fully correct 👍
rfuzzo
@rfuzzo

thanks, it works great now... after a bit of digging I also found that I have to set base(DataWindowMode.Custom) to remove the standard buttons when using UIVisualizerService.ShowAsync. but in the end, everything is handled via the viewmodel and not the view 👍

I also had to use a catel:DataWindow and not a catel:UserControl, and I abandoned writing a DataWindow wrapper for usercontrols to display modally. It wasn't possible to getViewForViewmodel from within the nested control, but maybe I was just not seeing it. simply calling the 1st order Viewmodel works fine now