These are chat archives for CharlesGust/django-imagr

19th
Nov 2014
Ben Friedland
@BFriedland
Nov 19 2014 00:47
So... I made a large amount of PEP8 compliance tweaks to views.py on the branch pep8_bf because it's the thing we were supposed to do first on the imagr project.
I did it in one commit, which is probably okay since it's only changes to whitespace and line ordering and a handful of variables renamed with "replace all" to make lines short enough for the Flake8 Sublime plugin.
But, across three other commits right afterwards, I also added .DS_Store to the .gitignore, removed an unnecessary html page (there are a few more from the tutorial we aren't using I forgot to remove and will later), and renamed all the mentions of "invalidation_string" to "context_string".
None of this caused any problems running the site, but it did all "combine" into a single pull request when viewed on GitHub, which makes it a little confusing to read, I suppose.
Ben Friedland
@BFriedland
Nov 19 2014 00:54
If you want to double check it (which shouldn't be necessary if you want to save some time...), it's probably easiest to switch GitHub's diff comparison on the pull request page from Unified mode to Split mode, because it shows how all the things line up side by side.
Ben Friedland
@BFriedland
Nov 19 2014 01:00
I'm not sure how much else we need for the "Add front-end views to Imagr" assignment; we have tests, fully completed specifications, and full PEP-8 compliance. We'll need to update the readme, though I'm not entirely sure what to put in it. Probably ctrl-f for "http" and find links left in the comments on views.py, forms.py, models.py and admin.py, then add them all as references in the readme... And perhaps copy-pasting docstrings as well.
To be safe, it's probably best if we ask Dan how important the assignment's specification "Concentrate on the aesthetics of the pages you are creating. Each should look as clean as possible." is... Hopefully he'll think we can go with what we've got. Pure functionality is beautiful, right??
Oh, we also might want to change the site's base.html so it doesn't inherit from admin/base...
Ben Friedland
@BFriedland
Nov 19 2014 01:05
That seems like a learning moment, anyways. I can't remember writing a base.html for a Django site before.
Ben Friedland
@BFriedland
Nov 19 2014 01:31
I took my own advice and updated the readme with descriptions of the views (docstrings) and all the references I could find... We used the Django docs and StackOverflow, mostly.