Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 03:40
    Travis foriequal0/codechain (feature/era-refactor) still failing (1116)
  • 03:35
    Travis CodeChain-io/codechain (snapshot) errored (6891)
  • 03:21
    foriequal0 synchronize #1892
  • 03:17
    majecty review_requested #1918
  • 03:17
    majecty review_requested #1918
  • 03:17
    majecty review_requested #1918
  • 03:17
    majecty labeled #1918
  • 03:17
    majecty opened #1918
  • 03:12
    HoOngEe synchronize #1841
  • 02:48
    foriequal0 synchronize #1916
  • 02:46
    Remagpie synchronize #1911
  • 02:46

    Remagpie on snapshot

    Factor out snapshot notify Move send_snapshot_notify() bef… Defer snapshot timing by one bl… and 1 more (compare)

  • 02:46
    Remagpie closed #1912
  • 01:40
    Travis CodeChain-io/codechain (master) errored (6890)
  • 00:49

    mergify[bot] on master

    Extract a function to verify a … Add `era` to CommonParams Make era nondecreasing and 2 more (compare)

  • 00:49
    mergify[bot] closed #1917
  • Dec 05 16:35
    sgkim126 commented #1908
  • Dec 05 16:34
    sgkim126 review_requested #1908
  • Dec 05 16:18
    foriequal0 commented #1912
  • Dec 05 16:17
    foriequal0 commented #1912
GeunWoo Kim
@GNUp
_______________________________________________ test_from_string_mutisig _______________________________________________

    def test_from_string_mutisig():
        address = AssetAddress.from_string(
>           "tcaqypsyqg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyfzyg3zyg3zyg3zyg3zyg3zyg3zyg3zygsn28hf0"
        )

tests/test_AssetAddress.py:61:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
codechain/primitives/AssetAddress.py:80: in from_string
    return AssetAddress(address_type, MultiSig(n, m, pubkeys), address)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <codechain.primitives.AssetAddress.AssetAddress object at 0x7f012617fe48>, address_type = 3
payload = MultiSig(n=2, m=1, pubkeys=[b'\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11', b'""""""""""""""""""""'])
address = 'tcaqypsyqg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyfzyg3zyg3zyg3zyg3zyg3zyg3zyg3zygsn28hf0'

    def __init__(
        self, address_type: int, payload: Union[H160, str, MultiSig], address: str
    ):
        self.address_type = address_type

        if isinstance(payload, (H160, str)):
            self.payload = H160(payload)
        else:
>           n, m, pubkeys = payload
E           TypeError: 'MultiSig' object is not iterable

codechain/primitives/AssetAddress.py:27: TypeError
__________________________________________ test_from_type_and_payload_mutisig __________________________________________

    def test_from_type_and_payload_mutisig():
        sig = MultiSig(
            2,
            1,
            [
                H160("1111111111111111111111111111111111111111"),
                H160("2222222222222222222222222222222222222222"),
            ],
        )
        address1 = AssetAddress.from_string(
>           "tcaqypsyqg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyfzyg3zyg3zyg3zyg3zyg3zyg3zyg3zygsn28hf0"
        )

tests/test_AssetAddress.py:87:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
codechain/primitives/AssetAddress.py:80: in from_string
    return AssetAddress(address_type, MultiSig(n, m, pubkeys), address)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <codechain.primitives.AssetAddress.AssetAddress object at 0x7f01263df4e0>, address_type = 3
payload = MultiSig(n=2, m=1, pubkeys=[b'\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11', b'""""""""""""""""""""'])
address = 'tcaqypsyqg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyfzyg3zyg3zyg3zyg3zyg3zyg3zyg3zygsn28hf0'

    def __init__(
        self, address_type: int, payload: Union[H160, str, MultiSig], address: str
    ):
        self.address_type = address_type

        if isinstance(payload, (H160, str)):
            self.payload = H160(payload)
        else:
>           n, m, pubkeys = payload
E           TypeError: 'MultiSig' object is not iterable

codechain/primitives/AssetAddress.py:27: TypeError
Joonmo Yang
@Remagpie
I'm working on snapshot synchronization, and currently I'm checking the entire codebase to make sure that CodeChain works even if there are missing blocks/headers in the database.
It's such an hard and tedious work, so it'd be nice if someone let me know the parts that I can skip checking.
Please let me know if you have any information :)
Park Juhyung
@majecty
@GNUp Thank you!
GeunWoo Kim
@GNUp
@foriequal0 Both PR here https://github.com/CodeChain-io/codechain-sdk-python/pulls are ready to be merged.
JinGyeong Jeong
@joojis
Warning: Unknown configuration option `fn_args_layout`
Is this happening only for me?
I see. I should update the rustfmt version to 2019-10-13.
JinGyeong Jeong
@joojis
Kwang Yul Seo
@kseo
Seulgi Kim
@sgkim126
@kseo I'll update toolchains. We don't need the new features yet, but I think we will need async/await soon.
Kwang Yul Seo
@kseo
@sgkim126 okay!
Kwang Yul Seo
@kseo
the rust team published an article on async/await :)
https://blog.rust-lang.org/2019/11/07/Async-await-stable.html
Seulgi Kim
@sgkim126
@/all CodeChain-io/codechain#1850 This PR upgrades rust, rustfmt, clippy, node and typescript.
JinGyeong Jeong
@joojis
GeunWoo Kim
@GNUp
@foriequal0 CodeChain-io/codechain-sdk-python#43 this PR is ready for review
foriequal0
@foriequal0
@GNUp Okay I’ll check that
foriequal0
@foriequal0
Park Juhyung
@majecty
👍
JinGyeong Jeong
@joojis
:thumbsup:
GeunWoo Kim
@GNUp
@foriequal0 I resolved your comments here. CodeChain-io/codechain-sdk-python#43
GeunWoo Kim
@GNUp
@foriequal0 pls check this PR CodeChain-io/codechain-sdk-python#48
GeunWoo Kim
@GNUp
@foriequal0 I resolved your comment. CodeChain-io/codechain-sdk-python#48
Park Juhyung
@majecty
@Remagpie You can find the private key used in CodeChain integration tests here.
CodeChainRepo/test/src/helper/constants.ts
Joonmo Yang
@Remagpie
Thx!
GeunWoo Kim
@GNUp
@foriequal0 I resolved your comments here CodeChain-io/codechain-sdk-python#48
GeunWoo Kim
@GNUp
and pls review this PR CodeChain-io/codechain-sdk-python#49
GeunWoo Kim
@GNUp
@foriequal0 I resolved your comment here CodeChain-io/codechain-sdk-python#49
Seulgi Kim
@sgkim126
@HoOngEe CodeChain-io/codechain#1870 is waiting for your review.
Seonpyo Kim
@HoOngEe
@sgkim126 Sorry for the late check, I'm going to review it from now.
GeunWoo Kim
@GNUp
@foriequal0 I resolved your comment. CodeChain-io/codechain-sdk-python#49
Joonmo Yang
@Remagpie
@sgkim126 Could you check the comment in CodeChain-io/codechain#1873 ?
GeunWoo Kim
@GNUp
@foriequal0 pls review this PR. CodeChain-io/codechain-sdk-python#53
Seulgi Kim
@sgkim126
@Remagpie I commented.
Joonmo Yang
@Remagpie
Thx. I applied the suggestion.
Kwang Yul Seo
@kseo
@sgkim126 what’s this issue about? would you describe more?
CodeChain-io/codechain#1064
Seulgi Kim
@sgkim126
@kseo updated
I'll try to make e2e tests stable. It fails too much now.
Kwang Yul Seo
@kseo
@sgkim126 sounds good. please share the root cause of the flakyness before you start fixing it
Kwang Yul Seo
@kseo
@sgkim126 let’s discuss this issue next week. please take a look at it
CodeChain-io/codechain#1884
Seulgi Kim
@sgkim126
@kseo Okay
Seulgi Kim
@sgkim126
@foriequal0 Why do you archive binaries for pull requests?
foriequal0
@foriequal0
@sgkim126 I’ve left it for just in case and I just didn’t bothered about it. Keeping it doesn’t take some quota and it’ll be removed after 90 days of retention[1].
[1] https://help.github.com/en/actions/automating-your-workflow-with-github-actions/persisting-workflow-data-using-artifacts#about-workflow-artifacts
Joonmo Yang
@Remagpie
@sgkim126 Could add your review to this PR? CodeChain-io/codechain#1900
Seulgi Kim
@sgkim126
@Remagpie I'll do it now.
Park Juhyung
@majecty
CodeChain 2.2.1 is released! The CodeChain Main network and Corgi network are using the 2.2.1 binary.
Kwang Yul Seo
@kseo
good job!
Park Juhyung
@majecty
I'm reviewing "Refactor to introduce the snapshot sync" PR CodeChain-io/codechain#1916
Park Juhyung
@majecty

https://github.com/CodeChain-io/codechain/pull/1916/commits/3a42b52057f4eb9fcce732711a169525a2aafef3

I like this Commit in the PR. Before the commit, code is divided according to whether the validator set is dynamic or static. After the commit, the code is split by what it does first and split again by the dynamic or static validator set. Thanks the change, it is easy to track what's different between the dynamic validator set and the static validator set.

Joonmo Yang
@Remagpie

I like this Commit in the PR. Before the commit, code is divided according to whether the validator set is dynamic or static. After the commit, the code is split by what it does first and split again by the dynamic or static validator set. Thanks the change, it is easy to track what's different between the dynamic validator set and the static validator set.

:smile:

Park Juhyung
@majecty
There is a hidden assumption that move_to_step should be called after jump_to_height function is called. I'll add comments about the assumption in the jump_to_height function.